Lawrence Forman
eb00ff05a8
Ran prettier/linter
2019-07-23 15:17:57 -07:00
Lawrence Forman
a7fe47f295
In @0x/contracts-exchange: Add SignatureWalletError and SignatureValidatorError rich reverts.
...
In `@0x/contracts-exchange`: Change `AssetProxyTransferError` to accept a `revertData` bytes instead of a `revertReason` string.
In `@0x/contracts-exchange`: Aadd `contracts/test/TestRevertReceiver.sol` for testing that validator/wallet reverts are properly wrapped.
2019-07-23 15:17:57 -07:00
Lawrence Forman
2a6f02c764
In @0x/order-utils: Add SignatureWalletError, SignatureValidatorError to ExchangeRevertErrors. Update AssetProxyTransferError to accept arbitrary errorData bytes instead of a revertReason string.
2019-07-23 15:17:57 -07:00
Amir Bandeali
1b2ff1f9ae
Update contracts/exchange/contracts/src/MixinSignatureValidator.sol
...
Co-Authored-By: dorothy-zbornak <lawrence@0xproject.com >
2019-07-23 15:17:57 -07:00
Lawrence Forman
7de9a36d01
In @0x/contracts-exchange: Fix comments in MixinSignatureValidator.sol.
2019-07-23 15:17:57 -07:00
Lawrence Forman
cfa8796b18
In @0x/contracts-exchange: Fix line count linter error.
2019-07-23 15:17:57 -07:00
Lawrence Forman
3c88ede02c
In @0x/order-utils: Add TransactionSignatureError to ExchangeRevertErrors.
...
In `@0x/contracts-exchange`: Add `TransactionSignatureError`, supplanting `TransactionErrorCodes.BAD_SIGNATURE`, and associated test.
2019-07-23 15:17:57 -07:00
Lawrence Forman
a0223835b8
In @0x/order-utils: Add signerAddress and signature to ExchangeRevertErrors.SignatureError.
...
In `@0x/contracts-exchange`: Add `signerAddress` and `signature` to `SignatureError` reverts.
2019-07-23 15:17:56 -07:00
Lawrence Forman
ac18359410
Switch order of parameters in some rich reverts for easier dirty parsing.
2019-07-23 15:17:56 -07:00
Lawrence Forman
8194e3d3c5
In @0x/contracts-exchange: More efficient revert string extraction in MixinAssetProxyDispatcher.sol
2019-07-23 15:17:56 -07:00
Lawrence Forman
440c4fe9b9
In @0x/contracts-utils switch from encodePacked to encodeWithSelector in RichErrors.StandardError
2019-07-23 15:17:56 -07:00
Lawrence Forman
e54f5d563f
In @0x/contracts-utils add natspec comments RichErrors.StandardError
2019-07-23 15:17:56 -07:00
Lawrence Forman
5781ab5436
Add PRs to changelogs
2019-07-23 15:17:56 -07:00
Lawrence Forman
f8009dbb27
In @0x/contracts-test-utils: Update CHANGELOG
2019-07-23 15:17:56 -07:00
Lawrence Forman
15efe3ae31
Fix linter errors
2019-07-23 15:17:56 -07:00
Lawrence Forman
991348bbbe
In @0x/contracts-extensions: Upgrade tests for rich reverts
2019-07-23 15:17:56 -07:00
Lawrence Forman
233336ea16
Ran prettier and linter
2019-07-23 15:17:56 -07:00
Lawrence Forman
20d8c1b51a
In @0x/contracts-exchange: Update tests for rich reverts
2019-07-23 15:17:56 -07:00
Lawrence Forman
06499f2155
In @0x/contract-wrappers: Update tests
2019-07-23 15:17:56 -07:00
Lawrence Forman
5b1d9396d7
In @0x/order-utils: Rename Exchange RevertError error codes.
2019-07-23 15:17:56 -07:00
Lawrence Forman
633c5d5938
In @0x/utils add encode() method to RevertError
2019-07-23 15:17:56 -07:00
Lawrence Forman
2e846159a8
In @0x/dev-utils: swap order of equality check in RevertError chai helper from actual.equals(expected) to expected.equals(actual).
2019-07-23 15:17:56 -07:00
Lawrence Forman
4408604c2d
In @0x/contracts-exchange: upgrading tests...
2019-07-23 15:17:56 -07:00
Lawrence Forman
15db5c8059
In @0x/contracts-exchange: Fix busted TestAssetProxyDispatcher.sol
2019-07-23 15:17:56 -07:00
Lawrence Forman
53121b1dd4
In @0x/order-utils: add AssetProxyTransferError Exchange RevertError
2019-07-23 15:17:56 -07:00
Lawrence Forman
c36dff6354
In @0x/contracts-exchange: Fix dispatchTransferFrom so it preserves the assetData.
2019-07-23 15:17:56 -07:00
Lawrence Forman
94a91ed5c8
In @0x/dev-utils: Tweak equality assertion failure actual and expected rendering to be more readable
2019-07-23 15:17:56 -07:00
Lawrence Forman
162a812189
In @0x/typescript-typings: Add types for @0x/dev-utils chai helpers in types/@0x.
...
In `@0x/dev-utils`: remove global typescript types for chai helpers in lieu of defining them in `@0x/typescript-typings`
2019-07-23 15:17:56 -07:00
Lawrence Forman
f06f0785f1
In @0x/contracts-test-utils: Inherit OrderStatus from @0x/types
2019-07-23 15:17:28 -07:00
Lawrence Forman
1aae68c614
In @0x/dev-utils: Break out RevertError helper code into a separate file from chai_setup.ts.
...
In `@0x/dev-utils`: Add chai support for ganache and geth transaction reverts.
2019-07-23 15:17:28 -07:00
Lawrence Forman
703a0fde3c
In @0x/utils: Add AnyRevertError type that matches with any revert error
2019-07-23 15:17:28 -07:00
Lawrence Forman
abb71cd074
In @0x/order-utils: Rename ExchangeErrors to ExchangeRevertErrors.
2019-07-23 15:17:28 -07:00
Lawrence Forman
79cf9156eb
In @0x/contracts-test-utils add generatePseudoRandomOrderHash() to orderUtils.
2019-07-23 15:16:49 -07:00
Lawrence Forman
3a6664282c
In @0x/contracts-exchange: fix contract bugs introduced by changes
2019-07-23 15:16:49 -07:00
Lawrence Forman
e00ac37cb2
In @0x/dev-utils fix the RevertError chai helper's equal override not passing all arguments to previous handler.
...
In `@0x/dev-utils` add more `RevertError` chai helper tests for backwards compatibility with `rejectedWith`.
In `@0x/dev-utils` instead of overriding `rejectedWith`, add a new method `revertWith`.
In `@0x/dev-utils` clean up the code for the `RevertError` chai helper.
2019-07-23 15:16:49 -07:00
Lawrence Forman
6583ac9ba1
Make @0x/base-contract _throwIfRevertWithReasonCallResult decode and throw RevertErrors.
...
Remove no longer necessary dependency on `ethers.js` in `@0x/base-contract`.
2019-07-23 15:16:49 -07:00
Lawrence Forman
42963ea77d
Use new RevertError nomenclature.
...
Tweak `RevertError` coercion in chai helper.
Add more `RevertError` chai helper tests.
2019-07-23 15:15:17 -07:00
Lawrence Forman
6231724f49
Rename RichRevertReason to RevertError.
...
Rename `StandardError` to `StringRevertError`.
Rename `RichRevertAbi` to `RevertErrorAbi`.
Make `RevertError` extend `Error` so it can be thrown.
Add `RevertError` tests.
2019-07-23 15:15:17 -07:00
Lawrence Forman
5b25eb4fbd
Fix linter errors.
2019-07-23 15:15:17 -07:00
Lawrence Forman
565cc7b3c8
Ran prettier
2019-07-23 15:15:17 -07:00
Lawrence Forman
71dc2690aa
Export StandardError from @0x/utils
2019-07-23 15:15:17 -07:00
Lawrence Forman
3accd48ea8
Remove chai plugin dependencies from @0x/contract-test-utils and @0x/order-utils
2019-07-23 15:15:17 -07:00
Lawrence Forman
ed78bde359
Make the chai helper for rich reverts in dev-utils more robust.
...
Add rich reverts chai helper tests to `dev-utils`
2019-07-23 15:14:52 -07:00
Lawrence Forman
ff1a3ab307
Add Exchange rich revert types to @0x/order-utils
2019-07-23 15:14:13 -07:00
Lawrence Forman
26643a489b
Add RichRevertReason type and utilities to @0x/utils
2019-07-23 15:13:26 -07:00
Lawrence Forman
5955a541a3
In order-utils, inherit chaiSetup from @0x/dev-utils
2019-07-23 15:13:26 -07:00
Lawrence Forman
995669cccd
In contract-wrappers, inherit chaiSetup from @0x/dev-utils
2019-07-23 15:13:26 -07:00
Lawrence Forman
371dc347cc
Inherit chaiSetup from @0x/dev-utils
2019-07-23 15:13:26 -07:00
Lawrence Forman
9a162e5d5c
Add RichRevertAbi to etherem-types
2019-07-23 15:13:26 -07:00
Lawrence Forman
9319f362bb
Add chaiSetup function wtih rich revert support to @0x/dev-utils
2019-07-23 15:12:33 -07:00
