Fix linter errors.

This commit is contained in:
Lawrence Forman 2019-04-03 22:06:48 -04:00 committed by Amir Bandeali
parent 565cc7b3c8
commit 5b25eb4fbd
4 changed files with 12 additions and 14 deletions

View File

@ -349,15 +349,16 @@ contract MixinExchangeCore is
// Validate Maker signature (check only if first time seen)
if (orderInfo.orderTakerAssetFilledAmount == 0) {
if (!isValidSignature(
orderInfo.orderHash,
order.makerAddress,
signature)) {
rrevert(SignatureError(
orderInfo.orderHash,
SignatureErrorCodes.BAD_SIGNATURE
));
}
if (!isValidSignature(
orderInfo.orderHash,
order.makerAddress,
signature
)) {
rrevert(SignatureError(
orderInfo.orderHash,
SignatureErrorCodes.BAD_SIGNATURE
));
}
}
}

View File

@ -40,8 +40,6 @@ contract RichErrors is
);
}
// solhint-enable func-name-mixedcase
/// @dev Reverts an encoded rich revert reason `errorData`.
/// @param errorData ABI encoded error data.
function rrevert(bytes memory errorData)

View File

@ -18,6 +18,7 @@
pragma solidity ^0.5.5;
contract MRichErrors {
// solhint-disable func-name-mixedcase
@ -31,8 +32,6 @@ contract MRichErrors {
pure
returns (bytes memory);
// solhint-enable func-name-mixedcase
/// @dev Reverts an encoded rich revert reason `errorData`.
/// @param errorData ABI encoded error data.
function rrevert(bytes memory errorData)

View File

@ -46,7 +46,7 @@ export function decodeRichRevertReason(bytes: string | Buffer): RichRevertReason
*/
export abstract class RichRevertReason {
// Map of types registered via `registerType`.
private static _typeRegistry: ObjectMap<RichRevertReasonRegistryItem> = {};
private static readonly _typeRegistry: ObjectMap<RichRevertReasonRegistryItem> = {};
public abi: RichRevertAbi;
public values: ValueMap = {};