901d400d62
* UniswapV3 VIP (#237) * `@0x/contracts-zero-ex`: Add UniswapV3Feature * `@0x/contracts-zero-ex`: Add UniswapV3 VIP `@0x/contract-artifacts`: Regenerate. `@0x/contract-wrappers`: Regenerate. `@0x/asset-swapper`: Add UniswapV3 VIP support. * address review comments and appease linter * `@0x/contracts-zero-ex`: Add UniswapV3Feature tests * Multiplex UniswapV3 (#241) * Add UniswapV3 support to Multiplex batchFill * Add AssetSwapper support for Multiplex UniswapV3 * fix repo scripts that use PKG= env var (#242) Co-authored-by: Lawrence Forman <me@merklejerk.com> * `@0x/asset-swapper`: Adjust uniswap gas overhead Co-authored-by: Lawrence Forman <me@merklejerk.com> Co-authored-by: mzhu25 <mchl.zhu.96@gmail.com> * OTC orders feature (#244) * Add OTC orders feature contracts * Address PR feedback * Remove partial fills for takerSigned variant * Add function to query the min valid nonce * Add ETH support * Tightly pack expiry, nonceBucket, and nonce * Address PR feedback * OTC orders unit tests * Bump prettier version * Skip unnecessary math if takerTokenFillAmount == order.takerAmount * appease CI * Update contract-artifacts and contract-wrappers and CHANGELOGs * `@0x/contracts-zero-ex`: Address spot check feedback * `regen wrappers * prettier * `@0x/asset-swapper`: prettier and tweak gas schedule slightly for uni3 Co-authored-by: Lawrence Forman <me@merklejerk.com> Co-authored-by: mzhu25 <mchl.zhu.96@gmail.com>
66 lines
1.6 KiB
Markdown
66 lines
1.6 KiB
Markdown
<!--- Thank you for taking the time to file an Issue -->
|
|
|
|
<!--- Before submitting please check to see if this issue was already reported -->
|
|
|
|
<!--- Prefix your issue title with the package name it relates to (e.g., `0x.js: ` or `general:`) -->
|
|
|
|
## Expected Behavior
|
|
|
|
<!--- If you're describing a bug, tell us what should happen -->
|
|
|
|
<!--- If you're suggesting a package change/improvement, tell us how it should work -->
|
|
|
|
<!--- If you're suggesting a contract or protocol change/improvement, visit our ZEIPs repo -->
|
|
|
|
## Current Behavior
|
|
|
|
<!--- If describing a bug, tell us what happens instead of the expected behavior -->
|
|
|
|
<!--- If suggesting a change/improvement, explain the difference from current behavior -->
|
|
|
|
## Possible Solution
|
|
|
|
<!--- Not obligatory, but suggest a fix/reason for the bug, -->
|
|
|
|
<!--- or ideas how to implement the addition or change -->
|
|
|
|
## Steps to Reproduce (for bugs)
|
|
|
|
<!--- Provide a link to a live example, or an unambiguous set of steps to -->
|
|
|
|
<!--- reproduce this bug. Include code to reproduce, if relevant -->
|
|
|
|
```
|
|
1.
|
|
2.
|
|
3.
|
|
```
|
|
|
|
## Context
|
|
|
|
<!--- How has this issue affected you? What are you trying to accomplish? -->
|
|
|
|
<!--- Providing context helps us come up with a solution that is most useful in the real world -->
|
|
|
|
## Your Environment
|
|
|
|
<!--- Include as many relevant details about the environment you experienced the bug in -->
|
|
|
|
| Package | Version |
|
|
| ------: | :------ |
|
|
|
|
<!-- For example:
|
|
| `0x.js` | 2.0.4 |
|
|
| `Exchange Contract` | v2 |
|
|
-->
|
|
|
|
| Network |
|
|
| ------- |
|
|
| NAME |
|
|
|
|
<!-- For example:
|
|
| mainnet |
|
|
| kovan |
|
|
| testrpc |
|
|
-->
|