Greg Hysen
|
ab13ce96cc
|
Renamed addAssetProxy back to registerAssetProxy; this seemed to cause less confusion. Also updated the function description.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
ac0c35424b
|
Reverting earlier change: interfaces now inherit from other interfaces
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
41242a6660
|
Clarified that 0x0 could be passed into AssetProxyDispatcher
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
e80f203efc
|
Inlined decodeMetadata in the proxies and removed encodeMetadata (already exists in Typescript). This simplifies the code.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
dbd65cdb04
|
Added @TODO for safeTransferFrom support in ERC721 proxy
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
e4dd33a675
|
Removed outdated TODO comment in MixinSettlementProxy
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
0e3544e1f9
|
Miscellaneous style changes to the contracts package; specifically tests
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
f4589b5bd4
|
Ran prettier
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
3b7068e8d0
|
renaming after tokenTransferProxy was removed
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
2a8fc705c7
|
Commented out 0x.js tests until migration package is ready.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
c19fb1dffc
|
Removed ERC20 V1 Proxy + TokenTransferProxy
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
436a6605fb
|
Updated commenting. Noted that transferFrom succeeds or throws on all transferFrom implementations.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
84eddc3d94
|
switched to constants in default order params.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
dfe6b2844b
|
Reverted change that allowed ERC721 transfer proxy to be called with amount 0. This now throws.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
6be5fe928e
|
Removed takerTokenAddress and makerTokenAddress from Order struct.
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
167654c9a0
|
Added clarity to not-authorized test case in dispatcher
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
6d6179fb2c
|
toUnsigned -> toBuffer in assetProxyUtils
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
80d06d358a
|
Unrolled the loop that copies the Order struct in FillOrderNoThrow. Saves 900 gas
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
1cace49b74
|
address -> IAssetProxy where possible for clarity
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
7ab5442163
|
Reverted to calling read/write uint256
|
2018-04-20 13:56:18 -07:00 |
|
Greg Hysen
|
4d42f64fa3
|
More testing of common functionality across proxies
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
8d83243378
|
Updates to proxy tests.
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
e1a74b6bdd
|
More authorized -> owner in test comments
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
44919c353e
|
Removed unnecessary deployments in test
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
cf8523da5f
|
Moved ERC721 FillOrderNoThrow tests into wrapper
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
10707ebc3a
|
Style improvements to the Asset Proxy tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
8374a51e6a
|
Replaced instances of accounts[0] with owner in contracts test cases
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
4e48de1116
|
Minor changes to typescript tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
b3b29f527e
|
Minor fixes to the contracts
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
37cfeed0f5
|
Rearranged preconditions in ERC721 proxy
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
cb27fe17cd
|
Changed order of encode/decode functions in token proxies
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
682ab76ba1
|
Updated name of AssetProxyChanged -> AssetProxySet
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
c811b710eb
|
Explicity declare memory for complex types, where possible
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
d0930b9048
|
Improved readability of FillOrderNoThrow II
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
591645758a
|
Improved readability of FillOrderNoThrow
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
4e093369f6
|
Updated ERC20 v1 proxy names in tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
be8e8791b7
|
Ran prettier/linter on new contract tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
b13a2e71ad
|
Added comments around deploying contracts to helper/wrapper tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
28678214d2
|
TS styles in core contract tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
f75d03c9ae
|
Added more comments to proxy tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
51508a732d
|
Cleaned up TS in dispatcher tests
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
326d8d3976
|
Proxy Metadata -> Data
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
f559a5510b
|
Cleaning up some wording
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
bf8b123dfc
|
Removed some unused ERC721 tokens
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
32a7442845
|
Minor style improvements to asset proxy utils
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
a0dfdefd16
|
ethereum-js for encoding/decoding asset proxy data
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
e7b0c24d9d
|
Added memory to bytes arrays, where possible
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
1707f1940d
|
Replaced read/write Uint256 with generic bytes32, plus casting
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
5dd708aae8
|
Updated public -> external
|
2018-04-20 13:56:17 -07:00 |
|
Greg Hysen
|
2477ea2fcf
|
Removed unused dependency
|
2018-04-20 13:56:17 -07:00 |
|