@0x/order-utils: Add takerAssetFillAmount field to IncompleteFillError type.

`@0x/order-utils`: Add `IncompleteMarketSellError` and `IncompleteMarketBuyError` `RevertError` types.
This commit is contained in:
Lawrence Forman
2019-08-16 12:41:18 -04:00
parent a3f6160898
commit fb6e8a4608
2 changed files with 36 additions and 2 deletions

View File

@@ -57,6 +57,14 @@
{
"note": "Add `ExchangeRevertErrors.SignatureErrorCode.InvalidSigner`.",
"pr": 2042
},
{
"note": "Add `takerAssetFillAmount` field to `IncompleteFillError` type",
"pr": "TODO"
},
{
"note": "Add `IncompleteMarketSellError` and `IncompleteMarketBuyError` `RevertError` types",
"pr": "TODO"
}
]
},

View File

@@ -208,8 +208,32 @@ export class TransactionExecutionError extends RevertError {
}
export class IncompleteFillError extends RevertError {
constructor(orderHash?: string) {
super('IncompleteFillError', 'IncompleteFillError(bytes32 orderHash)', { orderHash });
constructor(takerAssetFillAmount?: BigNumber, orderHash?: string) {
super(
'IncompleteFillError',
'IncompleteFillError(uint256 takerAssetFillAmount, bytes32 orderHash)',
{ takerAssetFillAmount, orderHash },
);
}
}
export class IncompleteMarketSellError extends RevertError {
constructor(takerAssetFillAmount?: BigNumber, orderHashes?: string[]) {
super(
'IncompleteMarketSellError',
'IncompleteMarketSellError(uint256 takerAssetFillAmount, bytes32[] orderHashes)',
{ takerAssetFillAmount, orderHashes },
);
}
}
export class IncompleteMarketBuyError extends RevertError {
constructor(makerAssetFillAmount?: BigNumber, orderHashes?: string[]) {
super(
'IncompleteMarketBuyError',
'IncompleteMarketBuyError(uint256 makerAssetFillAmount, bytes32[] orderHashes)',
{ makerAssetFillAmount, orderHashes },
);
}
}
@@ -233,6 +257,8 @@ const types = [
TransactionSignatureError,
TransactionExecutionError,
IncompleteFillError,
IncompleteMarketSellError,
IncompleteMarketBuyError,
];
// Register the types we've defined.