crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Return void and throw error instead of logging and returning boolean

Browse Source
This commit is contained in:
Steve Klebanoff
2019-01-04 09:01:13 -08:00
parent 442de09bbe
commit f1a7efc97e
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/monorepo-scripts/src/utils/discord.ts
View File

@@ -4,11 +4,10 @@ import { constants } from '../constants';
import { utils } from './utils';
export const alertDiscordAsync = async (releaseNotes: string): Promise<boolean> => {
export const alertDiscordAsync = async (releaseNotes: string): Promise<void> => {
const webhookUrl = constants.discordAlertWebhookUrl;
if (!webhookUrl) {
utils.log('Not alerting to discord because webhook url not set');
return false;
throw new Error("No discord webhook url, can't alert");
}
utils.log('Alerting discord...');
@@ -23,5 +22,5 @@ export const alertDiscordAsync = async (releaseNotes: string): Promise<boolean>
},
body: JSON.stringify(payload),
});
return true;
return;
};