crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In @0x/contracts-exchange: Change validator/wallet return value test to == 1 instead of != 0.

Browse Source
This commit is contained in:
Lawrence Forman 2019-04-12 17:55:29 -04:00 committed by Amir Bandeali
parent eb00ff05a8
commit c24bb139dd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contracts/exchange/contracts/src/MixinSignatureValidator.sol
View File

@ -280,7 +280,7 @@ contract MixinSignatureValidator is
(bool didSucceed, bytes memory returnData) = walletAddress.staticcall(callData); (bool didSucceed, bytes memory returnData) = walletAddress.staticcall(callData);
// Return data should be a single bool. // Return data should be a single bool.
if (didSucceed && returnData.length == 32) { if (didSucceed && returnData.length == 32) {
return returnData.readUint256(0) != 0; return returnData.readUint256(0) == 1;
} }
// Static call to verifier failed. // Static call to verifier failed.
rrevert(SignatureWalletError( rrevert(SignatureWalletError(
@ -338,7 +338,7 @@ contract MixinSignatureValidator is
(bool didSucceed, bytes memory returnData) = validatorAddress.staticcall(callData); (bool didSucceed, bytes memory returnData) = validatorAddress.staticcall(callData);
// Return data should be a single bool. // Return data should be a single bool.
if (didSucceed && returnData.length == 32) { if (didSucceed && returnData.length == 32) {
return returnData.readUint256(0) != 0; return returnData.readUint256(0) == 1;
} }
// Static call to verifier failed. // Static call to verifier failed.
rrevert(SignatureValidatorError( rrevert(SignatureValidatorError(