From c24bb139dd2f3cbfea3c70a13fa417d6e2e9c66e Mon Sep 17 00:00:00 2001 From: Lawrence Forman Date: Fri, 12 Apr 2019 17:55:29 -0400 Subject: [PATCH] In `@0x/contracts-exchange`: Change validator/wallet return value test to `== 1` instead of `!= 0`. --- contracts/exchange/contracts/src/MixinSignatureValidator.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/exchange/contracts/src/MixinSignatureValidator.sol b/contracts/exchange/contracts/src/MixinSignatureValidator.sol index 6019ce2f33..a34ad2ed08 100644 --- a/contracts/exchange/contracts/src/MixinSignatureValidator.sol +++ b/contracts/exchange/contracts/src/MixinSignatureValidator.sol @@ -280,7 +280,7 @@ contract MixinSignatureValidator is (bool didSucceed, bytes memory returnData) = walletAddress.staticcall(callData); // Return data should be a single bool. if (didSucceed && returnData.length == 32) { - return returnData.readUint256(0) != 0; + return returnData.readUint256(0) == 1; } // Static call to verifier failed. rrevert(SignatureWalletError( @@ -338,7 +338,7 @@ contract MixinSignatureValidator is (bool didSucceed, bytes memory returnData) = validatorAddress.staticcall(callData); // Return data should be a single bool. if (didSucceed && returnData.length == 32) { - return returnData.readUint256(0) != 0; + return returnData.readUint256(0) == 1; } // Static call to verifier failed. rrevert(SignatureValidatorError(