crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asset-s: fix bug: expiry is BigNumber, not string

Browse Source
This commit is contained in:
F. Eugene Aumson 2020-05-05 12:43:41 -04:00
parent 401410089c
commit c046943269
No known key found for this signature in database
GPG Key ID: 23E6737B1374A24A
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/asset-swapper/src/utils/quote_requestor.ts
View File

@ -267,6 +267,7 @@ export class QuoteRequestor {
...response, ...response,
makerAssetAmount: new BigNumber(response.makerAssetAmount), makerAssetAmount: new BigNumber(response.makerAssetAmount),
takerAssetAmount: new BigNumber(response.takerAssetAmount), takerAssetAmount: new BigNumber(response.takerAssetAmount),
expirationTimeSeconds: new BigNumber(response.expirationTimeSeconds),
}; };
}); });

4
packages/asset-swapper/test/quote_requestor_test.ts
View File

@ -204,7 +204,7 @@ describe('QuoteRequestor', async () => {
takerAssetData, takerAssetData,
makerAssetAmount: new BigNumber(expectedParams.sellAmount), makerAssetAmount: new BigNumber(expectedParams.sellAmount),
takerAssetAmount: new BigNumber(expectedParams.sellAmount), takerAssetAmount: new BigNumber(expectedParams.sellAmount),
expirationTimeSeconds: makeThreeMinuteExpiryJson(), expirationTimeSeconds: new BigNumber(makeThreeMinuteExpiryJson()),
}; };
mockedRequests.push({ mockedRequests.push({
endpoint: 'https://1337.0.0.1', endpoint: 'https://1337.0.0.1',
@ -298,7 +298,7 @@ describe('QuoteRequestor', async () => {
takerAssetData, takerAssetData,
makerAssetAmount: new BigNumber(expectedParams.buyAmount), makerAssetAmount: new BigNumber(expectedParams.buyAmount),
takerAssetAmount: new BigNumber(expectedParams.buyAmount), takerAssetAmount: new BigNumber(expectedParams.buyAmount),
expirationTimeSeconds: makeThreeMinuteExpiryJson(), expirationTimeSeconds: new BigNumber(makeThreeMinuteExpiryJson()),
}; };
mockedRequests.push({ mockedRequests.push({
endpoint: 'https://1337.0.0.1', endpoint: 'https://1337.0.0.1',