From c046943269748cc93fbb85aa5cd3e933074bca90 Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Tue, 5 May 2020 12:43:41 -0400 Subject: [PATCH] asset-s: fix bug: expiry is BigNumber, not string --- packages/asset-swapper/src/utils/quote_requestor.ts | 1 + packages/asset-swapper/test/quote_requestor_test.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/asset-swapper/src/utils/quote_requestor.ts b/packages/asset-swapper/src/utils/quote_requestor.ts index 7e8fb3ac07..cc8fedd907 100644 --- a/packages/asset-swapper/src/utils/quote_requestor.ts +++ b/packages/asset-swapper/src/utils/quote_requestor.ts @@ -267,6 +267,7 @@ export class QuoteRequestor { ...response, makerAssetAmount: new BigNumber(response.makerAssetAmount), takerAssetAmount: new BigNumber(response.takerAssetAmount), + expirationTimeSeconds: new BigNumber(response.expirationTimeSeconds), }; }); diff --git a/packages/asset-swapper/test/quote_requestor_test.ts b/packages/asset-swapper/test/quote_requestor_test.ts index 4ae9e765da..9e00d67165 100644 --- a/packages/asset-swapper/test/quote_requestor_test.ts +++ b/packages/asset-swapper/test/quote_requestor_test.ts @@ -204,7 +204,7 @@ describe('QuoteRequestor', async () => { takerAssetData, makerAssetAmount: new BigNumber(expectedParams.sellAmount), takerAssetAmount: new BigNumber(expectedParams.sellAmount), - expirationTimeSeconds: makeThreeMinuteExpiryJson(), + expirationTimeSeconds: new BigNumber(makeThreeMinuteExpiryJson()), }; mockedRequests.push({ endpoint: 'https://1337.0.0.1', @@ -298,7 +298,7 @@ describe('QuoteRequestor', async () => { takerAssetData, makerAssetAmount: new BigNumber(expectedParams.buyAmount), takerAssetAmount: new BigNumber(expectedParams.buyAmount), - expirationTimeSeconds: makeThreeMinuteExpiryJson(), + expirationTimeSeconds: new BigNumber(makeThreeMinuteExpiryJson()), }; mockedRequests.push({ endpoint: 'https://1337.0.0.1',