Add todo comments
This commit is contained in:
committed by
Leonid Logvinov
parent
c89eec4261
commit
a10bb4b2fa
@@ -47,6 +47,7 @@ export class EventWatcher {
|
||||
this._lastMempoolEvents = pendingEvents;
|
||||
}
|
||||
private async _getMempoolEventsAsync(): Promise<Web3.LogEntry[]> {
|
||||
// TODO: Allow users to listen to any number of confirmations deep, not just mempool
|
||||
const mempoolFilter = {
|
||||
fromBlock: BlockParamLiteral.Pending,
|
||||
toBlock: BlockParamLiteral.Pending,
|
||||
@@ -54,6 +55,7 @@ export class EventWatcher {
|
||||
const pendingEvents = await this._web3Wrapper.getLogsAsync(mempoolFilter);
|
||||
return pendingEvents;
|
||||
}
|
||||
// TODO: Let's emit out own LogEntry type that has property isRemoved rather then removed
|
||||
private async _emitDifferencesAsync(logs: Web3.LogEntry[], isRemoved: boolean): Promise<void> {
|
||||
for (const log of logs) {
|
||||
const logEvent = {
|
||||
|
@@ -10,7 +10,7 @@ export class AbiDecoder {
|
||||
constructor(abiArrays: Web3.AbiDefinition[][]) {
|
||||
_.map(abiArrays, this.addABI.bind(this));
|
||||
}
|
||||
// This method can only decode logs from the 0x smart contracts
|
||||
// This method can only decode logs from the 0x & ERC20 smart contracts
|
||||
public tryToDecodeLogOrNoop<ArgsType extends ContractEventArgs>(
|
||||
log: Web3.LogEntry): LogWithDecodedArgs<ArgsType>|RawLog {
|
||||
const methodId = log.topics[0];
|
||||
|
Reference in New Issue
Block a user