Address feedback
This commit is contained in:
@@ -433,7 +433,7 @@ export class ExchangeWrapper extends ContractWrapper {
|
||||
*/
|
||||
public async batchCancelOrderAsync(orderCancellationRequests: OrderCancellationRequest[]): Promise<void> {
|
||||
const makers = _.map(orderCancellationRequests, cancellationRequest => cancellationRequest.order.maker);
|
||||
assert.hashAtMostOneUniqueValue(makers, ExchangeContractErrs.MULTIPLE_MAKERS_IN_SINGLE_CANCEL_BATCH);
|
||||
assert.hashAtMostOneUniqueValue(makers, ExchangeContractErrs.MULTIPLE_MAKERS_IN_SINGLE_CANCEL_BATCH_DISALLOWED);
|
||||
const maker = makers[0];
|
||||
await assert.isSenderAddressAsync('maker', maker, this.web3Wrapper);
|
||||
_.forEach(orderCancellationRequests,
|
||||
|
@@ -169,7 +169,7 @@ export const ExchangeContractErrs = strEnum([
|
||||
'INSUFFICIENT_MAKER_FEE_BALANCE',
|
||||
'INSUFFICIENT_MAKER_FEE_ALLOWANCE',
|
||||
'TRANSACTION_SENDER_IS_NOT_FILL_ORDER_TAKER',
|
||||
'MULTIPLE_MAKERS_IN_SINGLE_CANCEL_BATCH',
|
||||
'MULTIPLE_MAKERS_IN_SINGLE_CANCEL_BATCH_DISALLOWED',
|
||||
'INSUFFICIENT_REMAINING_FILL_AMOUNT',
|
||||
'MULTIPLE_TAKER_TOKENS_IN_FILL_UP_TO_DISALLOWED',
|
||||
]);
|
||||
|
Reference in New Issue
Block a user