Revert after cascade

2018-02-14 15:15:52 -08:00
parent d0f32d1865
commit 6bb93b8170
1 changed files with 7 additions and 6 deletions
--- a/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol
+++ b/packages/contracts/src/contracts/current/protocol/Exchange/MixinSignatureValidator.sol
@@ -68,13 +68,14 @@ contract MixinSignatureValidator is
            );
            isValid = signer == recovered;
            return;
-        
-        // Anything else is illegal
-        } else {
-            revert();
-          
        }
-        return false;
+        
+        // Anything else is illegal (We do not return false because
+        // the signature may actually be valid, just not in a format
+        // that we currently support. In this case returning false
+        // may lead the caller to incorrectly believe that the
+        // signature was invalid.)
+        revert();
    }
    
    function get32(bytes b, uint256 index)