crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop |undefined from type of optional param

Browse Source 
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2720#discussion_r500453526
This commit is contained in:
F. Eugene Aumson 2020-10-14 13:23:02 -04:00
parent 2b1a1ba0db
commit 2cf31f05a1
No known key found for this signature in database
GPG Key ID: 23E6737B1374A24A
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/asset-swapper/src/utils/quote_requestor.ts
View File

@ -117,7 +117,7 @@ export class QuoteRequestor {
makerAssetData: string, makerAssetData: string,
takerAssetData: string, takerAssetData: string,
assetFillAmount: BigNumber, assetFillAmount: BigNumber,
comparisonPrice?: BigNumber | undefined, comparisonPrice?: BigNumber,
): TakerRequestQueryParams { ): TakerRequestQueryParams {
const { buyAmountBaseUnits, sellAmountBaseUnits, ...rest } = inferQueryParams( const { buyAmountBaseUnits, sellAmountBaseUnits, ...rest } = inferQueryParams(
marketOperation, marketOperation,