From 2cf31f05a1b402f5e8f7853c60dc760baa0c6b3b Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Wed, 14 Oct 2020 13:23:02 -0400 Subject: [PATCH] Drop `|undefined` from type of optional param Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2720#discussion_r500453526 --- packages/asset-swapper/src/utils/quote_requestor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/asset-swapper/src/utils/quote_requestor.ts b/packages/asset-swapper/src/utils/quote_requestor.ts index 8dd01a51fb..1c87ca426c 100644 --- a/packages/asset-swapper/src/utils/quote_requestor.ts +++ b/packages/asset-swapper/src/utils/quote_requestor.ts @@ -117,7 +117,7 @@ export class QuoteRequestor { makerAssetData: string, takerAssetData: string, assetFillAmount: BigNumber, - comparisonPrice?: BigNumber | undefined, + comparisonPrice?: BigNumber, ): TakerRequestQueryParams { const { buyAmountBaseUnits, sellAmountBaseUnits, ...rest } = inferQueryParams( marketOperation,