* v2-prototype: Fix tslint issues Add `are` to boolean naming conventions Fix tslint Fix the tsutils version, fixing ts typings issue Rename some variables in multi_sig_with_time_lock.ts Remove extra awaitTransactionMinedAsync calls Update artifacts Update yarn.lock Fix warnings in Metacoin Upgrade UglifyJS to include ES6 support Add CancelOrder and MatchOrder types Add missing return types Ignore classnames linter rule Apply changes to test/exchange/match_orders.ts Fix some unhandled promise rejections Add awaitTransactionMinedAsync after every sent transaction Add missing blockchainLifecycle calls to contracts tests # Conflicts: # packages/contracts/src/utils/exchange_wrapper.ts # packages/contracts/test/asset_proxy/proxies.ts # packages/contracts/test/exchange/dispatcher.ts # packages/contracts/test/multi_sig_with_time_lock.ts
159 lines
7.3 KiB
TypeScript
159 lines
7.3 KiB
TypeScript
import { BlockchainLifecycle } from '@0xproject/dev-utils';
|
|
import { BigNumber } from '@0xproject/utils';
|
|
import * as chai from 'chai';
|
|
import ethUtil = require('ethereumjs-util');
|
|
|
|
import { TestLibsContract } from '../../src/contract_wrappers/generated/test_libs';
|
|
import { addressUtils } from '../../src/utils/address_utils';
|
|
import { artifacts } from '../../src/utils/artifacts';
|
|
import { assetProxyUtils } from '../../src/utils/asset_proxy_utils';
|
|
import { chaiSetup } from '../../src/utils/chai_setup';
|
|
import { constants } from '../../src/utils/constants';
|
|
import { OrderFactory } from '../../src/utils/order_factory';
|
|
import { orderUtils } from '../../src/utils/order_utils';
|
|
import { SignedOrder } from '../../src/utils/types';
|
|
import { provider, txDefaults, web3Wrapper } from '../../src/utils/web3_wrapper';
|
|
|
|
chaiSetup.configure();
|
|
const expect = chai.expect;
|
|
|
|
const blockchainLifecycle = new BlockchainLifecycle(web3Wrapper);
|
|
|
|
describe('Exchange libs', () => {
|
|
let signedOrder: SignedOrder;
|
|
let orderFactory: OrderFactory;
|
|
let libs: TestLibsContract;
|
|
|
|
before(async () => {
|
|
await blockchainLifecycle.startAsync();
|
|
});
|
|
after(async () => {
|
|
await blockchainLifecycle.revertAsync();
|
|
});
|
|
before(async () => {
|
|
const accounts = await web3Wrapper.getAvailableAddressesAsync();
|
|
const makerAddress = accounts[0];
|
|
libs = await TestLibsContract.deployFrom0xArtifactAsync(artifacts.TestLibs, provider, txDefaults);
|
|
|
|
const defaultOrderParams = {
|
|
...constants.STATIC_ORDER_PARAMS,
|
|
exchangeAddress: libs.address,
|
|
makerAddress,
|
|
feeRecipientAddress: addressUtils.generatePseudoRandomAddress(),
|
|
makerAssetData: assetProxyUtils.encodeERC20ProxyData(addressUtils.generatePseudoRandomAddress()),
|
|
takerAssetData: assetProxyUtils.encodeERC20ProxyData(addressUtils.generatePseudoRandomAddress()),
|
|
};
|
|
const privateKey = constants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(makerAddress)];
|
|
orderFactory = new OrderFactory(privateKey, defaultOrderParams);
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await blockchainLifecycle.startAsync();
|
|
signedOrder = orderFactory.newSignedOrder();
|
|
});
|
|
afterEach(async () => {
|
|
await blockchainLifecycle.revertAsync();
|
|
});
|
|
|
|
describe('LibOrder', () => {
|
|
describe('getOrderHash', () => {
|
|
it('should output the correct orderHash', async () => {
|
|
const orderHashHex = await libs.publicGetOrderHash.callAsync(signedOrder);
|
|
expect(orderUtils.getOrderHashHex(signedOrder)).to.be.equal(orderHashHex);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('LibMath', () => {
|
|
describe('isRoundingError', () => {
|
|
it('should return false if there is a rounding error of 0.1%', async () => {
|
|
const numerator = new BigNumber(20);
|
|
const denominator = new BigNumber(999);
|
|
const target = new BigNumber(50);
|
|
// rounding error = ((20*50/999) - floor(20*50/999)) / (20*50/999) = 0.1%
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.false();
|
|
});
|
|
|
|
it('should return false if there is a rounding of 0.09%', async () => {
|
|
const numerator = new BigNumber(20);
|
|
const denominator = new BigNumber(9991);
|
|
const target = new BigNumber(500);
|
|
// rounding error = ((20*500/9991) - floor(20*500/9991)) / (20*500/9991) = 0.09%
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.false();
|
|
});
|
|
|
|
it('should return true if there is a rounding error of 0.11%', async () => {
|
|
const numerator = new BigNumber(20);
|
|
const denominator = new BigNumber(9989);
|
|
const target = new BigNumber(500);
|
|
// rounding error = ((20*500/9989) - floor(20*500/9989)) / (20*500/9989) = 0.011%
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.true();
|
|
});
|
|
|
|
it('should return true if there is a rounding error > 0.1%', async () => {
|
|
const numerator = new BigNumber(3);
|
|
const denominator = new BigNumber(7);
|
|
const target = new BigNumber(10);
|
|
// rounding error = ((3*10/7) - floor(3*10/7)) / (3*10/7) = 6.67%
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.true();
|
|
});
|
|
|
|
it('should return false when there is no rounding error', async () => {
|
|
const numerator = new BigNumber(1);
|
|
const denominator = new BigNumber(2);
|
|
const target = new BigNumber(10);
|
|
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.false();
|
|
});
|
|
|
|
it('should return false when there is rounding error <= 0.1%', async () => {
|
|
// randomly generated numbers
|
|
const numerator = new BigNumber(76564);
|
|
const denominator = new BigNumber(676373677);
|
|
const target = new BigNumber(105762562);
|
|
// rounding error = ((76564*105762562/676373677) - floor(76564*105762562/676373677)) /
|
|
// (76564*105762562/676373677) = 0.0007%
|
|
const isRoundingError = await libs.publicIsRoundingError.callAsync(numerator, denominator, target);
|
|
expect(isRoundingError).to.be.false();
|
|
});
|
|
});
|
|
|
|
describe('getPartialAmount', () => {
|
|
it('should return the numerator/denominator*target', async () => {
|
|
const numerator = new BigNumber(1);
|
|
const denominator = new BigNumber(2);
|
|
const target = new BigNumber(10);
|
|
|
|
const partialAmount = await libs.publicGetPartialAmount.callAsync(numerator, denominator, target);
|
|
const expectedPartialAmount = 5;
|
|
expect(partialAmount).to.be.bignumber.equal(expectedPartialAmount);
|
|
});
|
|
|
|
it('should round down', async () => {
|
|
const numerator = new BigNumber(2);
|
|
const denominator = new BigNumber(3);
|
|
const target = new BigNumber(10);
|
|
|
|
const partialAmount = await libs.publicGetPartialAmount.callAsync(numerator, denominator, target);
|
|
const expectedPartialAmount = 6;
|
|
expect(partialAmount).to.be.bignumber.equal(expectedPartialAmount);
|
|
});
|
|
|
|
it('should round .5 down', async () => {
|
|
const numerator = new BigNumber(1);
|
|
const denominator = new BigNumber(20);
|
|
const target = new BigNumber(10);
|
|
|
|
const partialAmount = await libs.publicGetPartialAmount.callAsync(numerator, denominator, target);
|
|
const expectedPartialAmount = 0;
|
|
expect(partialAmount).to.be.bignumber.equal(expectedPartialAmount);
|
|
});
|
|
});
|
|
});
|
|
});
|