* Install open zeppelin contracts * Init foundry in governance * Add wrapped ZRX token * Add governance contracts testing to CI * Set optimizer runs to default * Upgrade to patched version of openzeppelin/contracts * Test stakingakng / unwrapping ZRX * Init npm package * Lint fix, removing lib from gitignore * Add openzeppelin contracts git submodule for foundry * Add vanilla governor contract * Fix reference paths to imported packages * Temporarily switch to using a mocked version of ZRX * Ignore foundry's lib in link checker * Fix a conflict in gitignore between forge lib adn built lib * Upload governance code coverage report to coveralls * Flesh out test scenarios for wrapping/unwrapping * Add basic ERC20 name and symbol tests * Wire in basic timelock controller and governor test setup * Test basic governor properties * Add basic voting power delegation tests * Add proposal execution happy path test * Split ERC20Votes logic between wrapped token and ZeroExVotes contracts * Exclude BaseTest from coverage in coveralls * Add protocol specific governor with produciton governance settings * Add a dedicated instance for the treasury governor This is currently using the default 1 token 1 vote mechanism but will be migrated * Add test for updating governance settings for voting delay, voting period and proposal threshold * Create seperate timelock contract instance for treasury and protocol * Test updating the timlock min delay * Set timelock delay to 2 days for protocol and 1 sec for treasury * Remove timelock from treasury governor * Refactor _checkpointsLookup to return entire Checkpoint instad of just number of votes * Update the totalSupply checkpoints updating logic * Quadratic voting power transfers and delegations * Fix workflow yaml * Initialise ZeroExVotes behind a ERC1967Proxy Test it cannot be reinitialised * Remove obsoleted console.logs from test * Storage pack Checkpoint enum * Remove keeping track of total balances for voting * Switch to using the foundry artifact in test * Fix rebase issue * Add timelock control over the treasury governor * Add test for wrapped token transfer * Emit separate events for changing linear and quadratic voting power * Add the ability to cancel a proposal * Limit the governors' cancel function to security council only * Eject security council after a proposal is cancelled * Add ability for governance to set the security council * Merge the governors test suites into one reusable set of tests * Add an empty test function to base test contract to remove it from coverage reports. Fudge but no other way to ignore it in report * Security council can rollback protocol upgrades * Upgrade to solidity 0.8.19 * Move IZeroExGovernor to src * Abstract Security council interface into its own * Emit events when assigning and ejecting the security council * Use a cast to bytes4 instead of LibBytes Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com> * Writing total supply checkpoints and setup of quorum percentage of quadratic total supply for treasure governor * Add test for transferring tokens when delegating * Rename IZeroExSecurityCouncil to ISecurityCouncil * Add security council restrictions to governors * Remove obsolete overflow check * Improve test coverage * Upgrade open-zeppelin contracts to 4.8.2 * Test delegation by signature * Test non security council requests to rollback protocol changes cannot be executed * Better revert messages * Test correct interfaces are supported * Remove obsoleted funciton * Further test delegation by signature scenario * Split the delegation functionality tests * Add test for initialisation of voting contract * Add test for reading checkpoints * Update code comments * Fix compilation warnings * Run smt checker * Add checkpoint tests * Rename parameter in moveEntireVotingPower to match the one in movePartialVotingPower * Switch moveEntireVotingPower to a more generic moveVotingPower implementation as in the open-zeppelin contracts * Install foundry earlier in CI * Switch movePartialVotingPower to the generic moveVotingPower implementation * Write totalSupplyCheckpoints via the generic _writeCheckpoint * Add threshold for quadratic voting power * Remove autoinserted code by OZ * Add openzeppelin/contracts-upgradable * Add initializable base to Voting contract * Fix terminogy error in natspec * Fix code comment * Remove obsoleted overrides and add a missing modifier to moveVotingPower * Remove amount check Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com> * Fix a calculation error and clean tests * Update thresholds for treasury governor * Fix testShouldNotBeAbleToDelegateWithSignatureAfterExpiry * Update from @duncancmt without "memory-safe" the IR optimizer produces significantly worse code and it disables the stack limit evader Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com> * Add onlyProxy to initializer * Fix quadratic voting weight base * Rename voting parameter for clarity * Make addresses immutable (#680) * Make addresses immutable * Fix linting issues --------- Co-authored-by: elenadimitrova <elena@arenabg.com> * Prevent griefing by a malicious ZeroExVotes upgrade (#681) * Gas optimization * Minimal change to prevent malicious ZeroExVotes from griefing * Add demonstration of griefing upgrade * Fix rebase issues with tests * Fix prettier issues * Add checks to test --------- Co-authored-by: elenadimitrova <elena@arenabg.com> * Rename SecurityCouncil contract * Add timestamp to delegator balance updates * Make quadraticThreshold `immutable` for gas efficiency * Remove the logic for ejecting security council * Switch balance timestamp to be a block number * Test votes migration for adding a new vote weight mechanism (#674) * Add Emacs files to .gitignore * Make some functions unproected to demonstrate a migration * Add example (broken) migration * Add migration test for voting logic * Try to simplify tests * Fix compilation errors * Fix underflow test with new logic * Flesh out migration test for voting * Replace cube root library * Fix stack too deep in coverage --------- Co-authored-by: elenadimitrova <elena@arenabg.com> * Change test case to testFail * Update contracts/governance/test/ZeroExVotesMigration.sol Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com> --------- Co-authored-by: duncancmt <1207590+duncancmt@users.noreply.github.com> Co-authored-by: Duncan Townsend <git@duncancmt.com>
161 lines
5.4 KiB
YAML
161 lines
5.4 KiB
YAML
name: Continuous Integration
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
- development
|
|
pull_request:
|
|
|
|
jobs:
|
|
build:
|
|
name: Build and test
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
ARBITRUM_RPC_URL: ${{ secrets.ARBITRUM_RPC_URL }}
|
|
AVALANCHE_RPC_URL: ${{ secrets.AVALANCHE_RPC_URL }}
|
|
BSC_RPC_URL: ${{ secrets.BSC_RPC_URL }}
|
|
FANTOM_RPC_URL: ${{ secrets.FANTOM_RPC_URL }}
|
|
MAINNET_RPC_URL: ${{ secrets.MAINNET_RPC_URL }}
|
|
OPTIMISM_RPC_URL: ${{ secrets.OPTIMISM_RPC_URL }}
|
|
POLYGON_RPC_URL: ${{ secrets.POLYGON_RPC_URL }}
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
with:
|
|
submodules: recursive
|
|
|
|
- name: Setup Node
|
|
uses: actions/setup-node@v3
|
|
with:
|
|
node-version: '16'
|
|
|
|
- name: Install dependencies
|
|
run: yarn install --frozen-lockfile
|
|
|
|
- name: Add foundry
|
|
uses: foundry-rs/foundry-toolchain@v1
|
|
with:
|
|
version: nightly
|
|
|
|
- name: Build solution
|
|
run: yarn build
|
|
|
|
- name: Lint typescript
|
|
run: yarn lint:ts
|
|
|
|
- name: Lint solidity
|
|
run: yarn lint:contracts
|
|
|
|
- name: Run prettier
|
|
run: yarn prettier:ci
|
|
|
|
- name: Check dependent packages have consistent versions
|
|
run: yarn deps_versions:ci
|
|
|
|
- name: Check diff in docs
|
|
run: yarn diff_md_docs:ci
|
|
|
|
- name: Check for broken links in markdown files
|
|
run: yarn test:links
|
|
|
|
- name: Test doc generation
|
|
run: yarn test:generate_docs:ci
|
|
|
|
- name: Test @0x/contracts-*
|
|
run: |
|
|
yarn wsrun \
|
|
-p @0x/contracts-multisig \
|
|
-p @0x/contracts-utils \
|
|
-p @0x/contracts-exchange-libs \
|
|
-p @0x/contracts-erc721 \
|
|
-p @0x/contracts-erc1155 \
|
|
-p @0x/contracts-asset-proxy \
|
|
-p @0x/contracts-broker \
|
|
-p @0x/contracts-zero-ex \
|
|
-m --serial -c test:ci
|
|
|
|
- name: Test local @0x/contracts-*
|
|
run: |
|
|
yarn wsrun \
|
|
-p @0x/contracts-test-utils \
|
|
-p @0x/contract-addresses \
|
|
-p @0x/contract-artifacts \
|
|
-p @0x/contract-wrappers-test \
|
|
-p @0x/order-utils \
|
|
-m --serial -c test:ci
|
|
|
|
- name: Run Forge build for erc20
|
|
working-directory: contracts/erc20
|
|
run: |
|
|
forge --version
|
|
forge build --sizes
|
|
|
|
- name: Run Forge tests for erc20
|
|
working-directory: contracts/erc20
|
|
run: |
|
|
forge test -vvv --gas-report
|
|
|
|
- name: Run Forge coverage for erc20
|
|
working-directory: contracts/erc20
|
|
run: |
|
|
forge coverage --report summary --report lcov
|
|
|
|
- name: Upload the coverage report to Coveralls
|
|
uses: coverallsapp/github-action@master
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
base-path: ./contracts/erc20/
|
|
path-to-lcov: ./contracts/erc20/lcov.info
|
|
|
|
- name: Run Forge build for zero-ex
|
|
working-directory: contracts/zero-ex
|
|
run: |
|
|
forge --version
|
|
forge build --sizes
|
|
|
|
- name: Run Forge tests for zero-ex
|
|
working-directory: contracts/zero-ex
|
|
run: |
|
|
forge test -vvv --gas-report
|
|
|
|
- name: Run Forge coverage for zero-ex
|
|
working-directory: contracts/zero-ex
|
|
run: |
|
|
forge coverage --report summary --report lcov
|
|
|
|
- name: Upload the coverage report to Coveralls
|
|
uses: coverallsapp/github-action@master
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
base-path: ./contracts/zero-ex/
|
|
path-to-lcov: ./contracts/zero-ex/lcov.info
|
|
|
|
- name: Check coverage threshold
|
|
uses: VeryGoodOpenSource/very_good_coverage@v2
|
|
with:
|
|
path: ./contracts/zero-ex/lcov.info
|
|
min_coverage: 6.98
|
|
exclude: '**/tests'
|
|
|
|
- name: Run Forge build on governance contracts
|
|
working-directory: ./contracts/governance
|
|
run: |
|
|
forge --version
|
|
forge build --sizes
|
|
|
|
- name: Run Forge tests on governance contracts
|
|
working-directory: ./contracts/governance
|
|
run: |
|
|
forge test -vvv --gas-report
|
|
|
|
- name: Run Forge coverage on governance contracts
|
|
working-directory: ./contracts/governance
|
|
run: |
|
|
forge coverage --report lcov
|
|
|
|
- name: Upload the coverage report to Coveralls
|
|
uses: coverallsapp/github-action@master
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
base-path: ./contracts/governance/
|
|
path-to-lcov: ./contracts/governance/lcov.info
|