904 lines
42 KiB
TypeScript
904 lines
42 KiB
TypeScript
import {
|
|
addressUtils,
|
|
chaiSetup,
|
|
constants,
|
|
LogDecoder,
|
|
OrderFactory,
|
|
provider,
|
|
txDefaults,
|
|
web3Wrapper,
|
|
} from '@0x/contracts-test-utils';
|
|
import { BlockchainLifecycle } from '@0x/dev-utils';
|
|
import { assetDataUtils, ExchangeRevertErrors, orderHashUtils, signatureUtils } from '@0x/order-utils';
|
|
import { SignatureType, SignedOrder } from '@0x/types';
|
|
import { BigNumber, providerUtils, StringRevertError } from '@0x/utils';
|
|
import * as chai from 'chai';
|
|
import * as crypto from 'crypto';
|
|
import { LogWithDecodedArgs } from 'ethereum-types';
|
|
import ethUtil = require('ethereumjs-util');
|
|
|
|
import {
|
|
artifacts,
|
|
TestSignatureValidatorContract,
|
|
TestSignatureValidatorSignatureValidatorApprovalEventArgs,
|
|
TestValidatorWalletContract,
|
|
} from '../src';
|
|
|
|
import { ValidatorWalletAction } from './utils';
|
|
|
|
chaiSetup.configure();
|
|
const expect = chai.expect;
|
|
|
|
const blockchainLifecycle = new BlockchainLifecycle(web3Wrapper);
|
|
// tslint:disable:no-unnecessary-type-assertion
|
|
describe('MixinSignatureValidator', () => {
|
|
const SIGNATURE_LENGTH = 65;
|
|
let chainId: number;
|
|
let signedOrder: SignedOrder;
|
|
let orderFactory: OrderFactory;
|
|
let signatureValidator: TestSignatureValidatorContract;
|
|
let validatorWallet: TestValidatorWalletContract;
|
|
let validatorWalletRevertReason: string;
|
|
let signerAddress: string;
|
|
let signerPrivateKey: Buffer;
|
|
let notSignerAddress: string;
|
|
let signatureValidatorLogDecoder: LogDecoder;
|
|
|
|
before(async () => {
|
|
await blockchainLifecycle.startAsync();
|
|
});
|
|
after(async () => {
|
|
await blockchainLifecycle.revertAsync();
|
|
});
|
|
before(async () => {
|
|
chainId = await providerUtils.getChainIdAsync(provider);
|
|
const accounts = await web3Wrapper.getAvailableAddressesAsync();
|
|
const makerAddress = accounts[0];
|
|
signerAddress = makerAddress;
|
|
notSignerAddress = accounts[1];
|
|
signatureValidator = await TestSignatureValidatorContract.deployFrom0xArtifactAsync(
|
|
artifacts.TestSignatureValidator,
|
|
provider,
|
|
txDefaults,
|
|
new BigNumber(chainId),
|
|
);
|
|
validatorWallet = await TestValidatorWalletContract.deployFrom0xArtifactAsync(
|
|
artifacts.TestValidatorWallet,
|
|
provider,
|
|
txDefaults,
|
|
signatureValidator.address,
|
|
);
|
|
validatorWalletRevertReason = await validatorWallet.REVERT_REASON.callAsync();
|
|
|
|
// Approve the validator for both signers.
|
|
await Promise.all(
|
|
[signerAddress, notSignerAddress].map(async (addr: string) => {
|
|
const tx1 = signatureValidator.setSignatureValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
true,
|
|
{ from: addr },
|
|
);
|
|
const tx2 = signatureValidator.setOrderValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
true,
|
|
{ from: addr },
|
|
);
|
|
return Promise.all([tx1, tx2]);
|
|
}),
|
|
);
|
|
|
|
const defaultOrderParams = {
|
|
...constants.STATIC_ORDER_PARAMS,
|
|
makerAddress,
|
|
feeRecipientAddress: addressUtils.generatePseudoRandomAddress(),
|
|
makerAssetData: assetDataUtils.encodeERC20AssetData(addressUtils.generatePseudoRandomAddress()),
|
|
takerAssetData: assetDataUtils.encodeERC20AssetData(addressUtils.generatePseudoRandomAddress()),
|
|
makerFeeAssetData: assetDataUtils.encodeERC20AssetData(addressUtils.generatePseudoRandomAddress()),
|
|
takerFeeAssetData: assetDataUtils.encodeERC20AssetData(addressUtils.generatePseudoRandomAddress()),
|
|
makerFee: constants.ZERO_AMOUNT,
|
|
takerFee: constants.ZERO_AMOUNT,
|
|
domain: {
|
|
verifyingContractAddress: signatureValidator.address,
|
|
chainId,
|
|
},
|
|
};
|
|
|
|
signatureValidatorLogDecoder = new LogDecoder(web3Wrapper, artifacts);
|
|
signerPrivateKey = constants.TESTRPC_PRIVATE_KEYS[accounts.indexOf(makerAddress)];
|
|
orderFactory = new OrderFactory(signerPrivateKey, defaultOrderParams);
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await blockchainLifecycle.startAsync();
|
|
});
|
|
afterEach(async () => {
|
|
await blockchainLifecycle.revertAsync();
|
|
});
|
|
|
|
type ValidateCallAsync = (
|
|
order: SignedOrder,
|
|
signerAddress: string,
|
|
signatureHex: string,
|
|
validatorAction?: ValidatorWalletAction,
|
|
) => Promise<any>;
|
|
|
|
const createHashSignatureTests = (validateCallAsync: ValidateCallAsync) => {
|
|
it('should revert when signature is empty', async () => {
|
|
const emptySignature = constants.NULL_BYTES;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureError(
|
|
ExchangeRevertErrors.SignatureErrorCode.InvalidLength,
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
emptySignature,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signedOrder.makerAddress, emptySignature);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when signature type is unsupported', async () => {
|
|
const unsupportedSignatureType = SignatureType.NSignatureTypes;
|
|
const unsupportedSignatureHex = `0x${Buffer.from([unsupportedSignatureType]).toString('hex')}`;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureError(
|
|
ExchangeRevertErrors.SignatureErrorCode.Unsupported,
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
unsupportedSignatureHex,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signedOrder.makerAddress, unsupportedSignatureHex);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when SignatureType=Illegal', async () => {
|
|
const illegalSignatureHex = `0x${Buffer.from([SignatureType.Illegal]).toString('hex')}`;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureError(
|
|
ExchangeRevertErrors.SignatureErrorCode.Illegal,
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
illegalSignatureHex,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signedOrder.makerAddress, illegalSignatureHex);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return false when SignatureType=Invalid and signature has a length of zero', async () => {
|
|
const signatureHex = `0x${Buffer.from([SignatureType.Invalid]).toString('hex')}`;
|
|
const isValidSignature = await validateCallAsync(signedOrder, signedOrder.makerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when SignatureType=Invalid and signature length is non-zero', async () => {
|
|
const fillerData = ethUtil.toBuffer('0xdeadbeef');
|
|
const signatureType = ethUtil.toBuffer(`0x${SignatureType.Invalid}`);
|
|
const signatureBuffer = Buffer.concat([fillerData, signatureType]);
|
|
const signatureHex = ethUtil.bufferToHex(signatureBuffer);
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureError(
|
|
ExchangeRevertErrors.SignatureErrorCode.InvalidLength,
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
signatureHex,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signedOrder.makerAddress, signatureHex);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=EIP712 and signature is valid', async () => {
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(signedOrder, signerAddress, signedOrder.signature);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=EIP712 and signature is invalid', async () => {
|
|
const signature = Buffer.concat([
|
|
crypto.randomBytes(SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer([SignatureType.EIP712]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature.
|
|
// This will fail because `signerAddress` signed the message, but we're passing in `notSignerAddress`
|
|
const isValidSignature = await validateCallAsync(signedOrder, notSignerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should return true when SignatureType=EthSign and signature is valid', async () => {
|
|
// Create EthSign signature
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const orderHashWithEthSignPrefixHex = signatureUtils.addSignedMessagePrefix(orderHashHex);
|
|
const orderHashWithEthSignPrefixBuffer = ethUtil.toBuffer(orderHashWithEthSignPrefixHex);
|
|
const ecSignature = ethUtil.ecsign(orderHashWithEthSignPrefixBuffer, signerPrivateKey);
|
|
// Create 0x signature from EthSign signature
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(ecSignature.v),
|
|
ecSignature.r,
|
|
ecSignature.s,
|
|
ethUtil.toBuffer([SignatureType.EthSign]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(signedOrder, signerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=EthSign and signature is invalid', async () => {
|
|
// Create EthSign signature
|
|
const signature = Buffer.concat([
|
|
crypto.randomBytes(SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer([SignatureType.EthSign]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature.
|
|
// This will fail because `signerAddress` signed the message, but we're passing in `notSignerAddress`
|
|
const isValidSignature = await validateCallAsync(signedOrder, signerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should return true when SignatureType=Wallet and signature is valid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=Wallet and signature is invalid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
notSignerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when validator attempts to update state and SignatureType=Wallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.UpdateState,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when validator reverts and SignatureType=Wallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Revert,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=Validator, signature is valid and validator is approved', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.Validator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=Validator, signature is invalid and validator is approved', async () => {
|
|
const signature = Buffer.concat([
|
|
crypto.randomBytes(SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.Validator]),
|
|
]);
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
ethUtil.bufferToHex(signature),
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when validator attempts to update state and SignatureType=Validator', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.Validator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureValidatorError(
|
|
orderHashHex,
|
|
signerAddress,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signerAddress, signatureHex, ValidatorWalletAction.UpdateState);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when validator reverts and SignatureType=Validator', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.Validator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureValidatorError(
|
|
orderHashHex,
|
|
signerAddress,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signerAddress, signatureHex, ValidatorWalletAction.Revert);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when SignatureType=Validator, signature is valid and validator is not approved', async () => {
|
|
// Set approval of signature validator to false
|
|
await signatureValidator.setSignatureValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
false,
|
|
{ from: signerAddress },
|
|
);
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.Validator]),
|
|
]);
|
|
// Validate signature
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
const expectedError = new ExchangeRevertErrors.SignatureValidatorNotApprovedError(
|
|
signerAddress,
|
|
validatorWallet.address,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=EIP1271Wallet and signature is valid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=EIP1271Wallet and signature is invalid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Reject,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when validator attempts to update state and SignatureType=EIP1271Wallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.UpdateState,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when validator reverts and SignatureType=EIP1271Wallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271Wallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Revert,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=Presigned and signer has presigned hash', async () => {
|
|
// Presign hash
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
await signatureValidator.preSign.awaitTransactionSuccessAsync(orderHashHex, {
|
|
from: signedOrder.makerAddress,
|
|
});
|
|
// Validate presigned signature
|
|
const signature = ethUtil.toBuffer(`0x${SignatureType.PreSigned}`);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await validateCallAsync(signedOrder, signedOrder.makerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=Presigned and signer has not presigned hash', async () => {
|
|
const signature = ethUtil.toBuffer(`0x${SignatureType.PreSigned}`);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await validateCallAsync(signedOrder, signedOrder.makerAddress, signatureHex);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
};
|
|
|
|
describe('isValidHashSignature', () => {
|
|
const validateCallAsync = async (
|
|
order: SignedOrder,
|
|
validSigner: string,
|
|
signatureHex: string,
|
|
validatorAction?: ValidatorWalletAction,
|
|
) => {
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(order);
|
|
if (validatorAction !== undefined) {
|
|
await validatorWallet.setValidateAction.awaitTransactionSuccessAsync(
|
|
orderHashHex,
|
|
validatorAction,
|
|
validSigner,
|
|
);
|
|
}
|
|
return signatureValidator.isValidHashSignature.callAsync(orderHashHex, order.makerAddress, signatureHex);
|
|
};
|
|
|
|
beforeEach(async () => {
|
|
signedOrder = await orderFactory.newSignedOrderAsync();
|
|
});
|
|
|
|
it('should revert when SignatureType=OrderValidator', async () => {
|
|
const inappropriateSignatureHex = `0x${Buffer.from([SignatureType.OrderValidator]).toString('hex')}`;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureError(
|
|
ExchangeRevertErrors.SignatureErrorCode.InappropriateSignatureType,
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
inappropriateSignatureHex,
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
inappropriateSignatureHex,
|
|
ValidatorWalletAction.Accept,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when message was signed by a Trezor One (firmware version 1.6.2)', async () => {
|
|
// messageHash translates to 0x2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
|
|
const messageHash = ethUtil.bufferToHex(ethUtil.toBuffer('++++++++++++++++++++++++++++++++'));
|
|
const signer = '0xc28b145f10f0bcf0fc000e778615f8fd73490bad';
|
|
const v = ethUtil.toBuffer('0x1c');
|
|
const r = ethUtil.toBuffer('0x7b888b596ccf87f0bacab0dcb483124973f7420f169b4824d7a12534ac1e9832');
|
|
const s = ethUtil.toBuffer('0x0c8e14f7edc01459e13965f1da56e0c23ed11e2cca932571eee1292178f90424');
|
|
const trezorSignatureType = ethUtil.toBuffer(`0x${SignatureType.EthSign}`);
|
|
const signature = Buffer.concat([v, r, s, trezorSignatureType]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await signatureValidator.isValidHashSignature.callAsync(
|
|
messageHash,
|
|
signer,
|
|
signatureHex,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return true when message was signed by a Trezor Model T (firmware version 2.0.7)', async () => {
|
|
// messageHash translates to 0x2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b2b
|
|
const messageHash = ethUtil.bufferToHex(ethUtil.toBuffer('++++++++++++++++++++++++++++++++'));
|
|
const signer = '0x98ce6d9345e8ffa7d99ee0822272fae9d2c0e895';
|
|
const v = ethUtil.toBuffer('0x1c');
|
|
const r = ethUtil.toBuffer('0x423b71062c327f0ec4fe199b8da0f34185e59b4c1cb4cc23df86cac4a601fb3f');
|
|
const s = ethUtil.toBuffer('0x53810d6591b5348b7ee08ee812c874b0fdfb942c9849d59512c90e295221091f');
|
|
const trezorSignatureType = ethUtil.toBuffer(`0x${SignatureType.EthSign}`);
|
|
const signature = Buffer.concat([v, r, s, trezorSignatureType]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await signatureValidator.isValidHashSignature.callAsync(
|
|
messageHash,
|
|
signer,
|
|
signatureHex,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
createHashSignatureTests(validateCallAsync);
|
|
});
|
|
|
|
describe('isValidOrderSignature', () => {
|
|
const validateCallAsync = async (
|
|
order: SignedOrder,
|
|
validSigner: string,
|
|
signatureHex: string,
|
|
validatorAction?: ValidatorWalletAction,
|
|
) => {
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(order);
|
|
if (validatorAction !== undefined) {
|
|
await validatorWallet.setValidateAction.awaitTransactionSuccessAsync(
|
|
orderHashHex,
|
|
validatorAction,
|
|
validSigner,
|
|
);
|
|
}
|
|
return signatureValidator.isValidOrderSignature.callAsync(order, order.makerAddress, signatureHex);
|
|
};
|
|
|
|
beforeEach(async () => {
|
|
signedOrder = await orderFactory.newSignedOrderAsync();
|
|
});
|
|
|
|
it('should return true when SignatureType=OrderValidator, signature is valid and validator is approved', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.OrderValidator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=OrderValidator, signature is invalid and validator is approved', async () => {
|
|
const signature = Buffer.concat([
|
|
crypto.randomBytes(SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.OrderValidator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when `isValidOrderSignature` attempts to update state and SignatureType=OrderValidator', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.OrderValidator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderValidatorError(
|
|
orderHashHex,
|
|
signedOrder.makerAddress,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signerAddress, signatureHex, ValidatorWalletAction.UpdateState);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when `isValidOrderSignature` reverts and SignatureType=OrderValidator', async () => {
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.OrderValidator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderValidatorError(
|
|
orderHashHex,
|
|
signerAddress,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(signedOrder, signerAddress, signatureHex, ValidatorWalletAction.Revert);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should throw when SignatureType=OrderValidator, signature is valid and validator is not approved', async () => {
|
|
// Set approval of signature validator to false
|
|
await signatureValidator.setOrderValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
false,
|
|
{ from: signerAddress },
|
|
);
|
|
const signature = Buffer.concat([
|
|
ethUtil.toBuffer(signedOrder.signature).slice(0, SIGNATURE_LENGTH),
|
|
ethUtil.toBuffer(validatorWallet.address),
|
|
ethUtil.toBuffer([SignatureType.OrderValidator]),
|
|
]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
signerAddress,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderValidatorNotApprovedError(
|
|
signerAddress,
|
|
validatorWallet.address,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=OrderWallet and signature is valid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=OrderWallet and signature is invalid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Reject,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when validator attempts to update state and SignatureType=OrderWallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.UpdateState,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when validator reverts and SignatureType=OrderWallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Revert,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should return true when SignatureType=EIP1271OrderWallet and signature is valid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.ValidateSignature,
|
|
);
|
|
expect(isValidSignature).to.be.true();
|
|
});
|
|
|
|
it('should return false when SignatureType=EIP1271OrderWallet and signature is invalid', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
// Validate signature
|
|
const isValidSignature = await validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Reject,
|
|
);
|
|
expect(isValidSignature).to.be.false();
|
|
});
|
|
|
|
it('should revert when validator attempts to update state and SignatureType=EIP1271OrderWallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
constants.NULL_BYTES,
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.UpdateState,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
it('should revert when validator reverts and SignatureType=EIP1271OrderWallet', async () => {
|
|
signedOrder.makerAddress = validatorWallet.address;
|
|
const orderHashHex = orderHashUtils.getOrderHashHex(signedOrder);
|
|
const signature = Buffer.concat([ethUtil.toBuffer([SignatureType.EIP1271OrderWallet])]);
|
|
const signatureHex = ethUtil.bufferToHex(signature);
|
|
const expectedError = new ExchangeRevertErrors.SignatureOrderWalletError(
|
|
orderHashHex,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
new StringRevertError(validatorWalletRevertReason).encode(),
|
|
);
|
|
const tx = validateCallAsync(
|
|
signedOrder,
|
|
validatorWallet.address,
|
|
signatureHex,
|
|
ValidatorWalletAction.Revert,
|
|
);
|
|
return expect(tx).to.revertWith(expectedError);
|
|
});
|
|
|
|
createHashSignatureTests(validateCallAsync);
|
|
});
|
|
|
|
describe('setSignatureValidatorApproval', () => {
|
|
it('should emit a SignatureValidatorApprovalSet with correct args when a validator is approved', async () => {
|
|
const approval = true;
|
|
const res = await signatureValidator.setSignatureValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
approval,
|
|
{
|
|
from: signerAddress,
|
|
},
|
|
);
|
|
expect(res.logs.length).to.equal(1);
|
|
const log = signatureValidatorLogDecoder.decodeLogOrThrow(res.logs[0]) as LogWithDecodedArgs<
|
|
TestSignatureValidatorSignatureValidatorApprovalEventArgs
|
|
>;
|
|
const logArgs = log.args;
|
|
expect(logArgs.signerAddress).to.equal(signerAddress);
|
|
expect(logArgs.validatorAddress).to.equal(validatorWallet.address);
|
|
expect(logArgs.approved).to.equal(approval);
|
|
});
|
|
it('should emit a SignatureValidatorApprovalSet with correct args when a validator is disapproved', async () => {
|
|
const approval = false;
|
|
const res = await signatureValidator.setSignatureValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
approval,
|
|
{
|
|
from: signerAddress,
|
|
},
|
|
);
|
|
expect(res.logs.length).to.equal(1);
|
|
const log = signatureValidatorLogDecoder.decodeLogOrThrow(res.logs[0]) as LogWithDecodedArgs<
|
|
TestSignatureValidatorSignatureValidatorApprovalEventArgs
|
|
>;
|
|
const logArgs = log.args;
|
|
expect(logArgs.signerAddress).to.equal(signerAddress);
|
|
expect(logArgs.validatorAddress).to.equal(validatorWallet.address);
|
|
expect(logArgs.approved).to.equal(approval);
|
|
});
|
|
it('should emit a SignatureValidatorApprovalSet with correct args when an order validator is approved', async () => {
|
|
const approval = true;
|
|
const res = await signatureValidator.setOrderValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
approval,
|
|
{
|
|
from: signerAddress,
|
|
},
|
|
);
|
|
expect(res.logs.length).to.equal(1);
|
|
const log = signatureValidatorLogDecoder.decodeLogOrThrow(res.logs[0]) as LogWithDecodedArgs<
|
|
TestSignatureValidatorSignatureValidatorApprovalEventArgs
|
|
>;
|
|
const logArgs = log.args;
|
|
expect(logArgs.signerAddress).to.equal(signerAddress);
|
|
expect(logArgs.validatorAddress).to.equal(validatorWallet.address);
|
|
expect(logArgs.approved).to.equal(approval);
|
|
});
|
|
it('should emit a SignatureValidatorApprovalSet with correct args when am order validator is disapproved', async () => {
|
|
const approval = false;
|
|
const res = await signatureValidator.setOrderValidatorApproval.awaitTransactionSuccessAsync(
|
|
validatorWallet.address,
|
|
approval,
|
|
{
|
|
from: signerAddress,
|
|
},
|
|
);
|
|
expect(res.logs.length).to.equal(1);
|
|
const log = signatureValidatorLogDecoder.decodeLogOrThrow(res.logs[0]) as LogWithDecodedArgs<
|
|
TestSignatureValidatorSignatureValidatorApprovalEventArgs
|
|
>;
|
|
const logArgs = log.args;
|
|
expect(logArgs.signerAddress).to.equal(signerAddress);
|
|
expect(logArgs.validatorAddress).to.equal(validatorWallet.address);
|
|
expect(logArgs.approved).to.equal(approval);
|
|
});
|
|
});
|
|
});
|
|
// tslint:disable:max-file-line-count
|
|
// tslint:enable:no-unnecessary-type-assertion
|