916b4d3a26
Added assertions on addresses for public methods Throw a helpful error message when signer address is not instantiated address in PrivateKeyWalletSubprovider Update changelog and rename derivationBasePath to baseDerivationPath When returning undefined use pattern of IfExists Added configuration object for MnemonicWallet Put constants back into each individual wallet rather than in walletUtils Delete accidental package-lock.json
216 lines
11 KiB
TypeScript
216 lines
11 KiB
TypeScript
import { JSONRPCResponsePayload } from '@0xproject/types';
|
|
import * as chai from 'chai';
|
|
import * as ethUtils from 'ethereumjs-util';
|
|
import * as _ from 'lodash';
|
|
import Web3ProviderEngine = require('web3-provider-engine');
|
|
|
|
import { GanacheSubprovider, MnemonicWalletSubprovider } from '../../src/';
|
|
import {
|
|
DoneCallback,
|
|
LedgerCommunicationClient,
|
|
LedgerSubproviderErrors,
|
|
WalletSubproviderErrors,
|
|
} from '../../src/types';
|
|
import { chaiSetup } from '../chai_setup';
|
|
import { fixtureData } from '../utils/fixture_data';
|
|
import { reportCallbackErrors } from '../utils/report_callback_errors';
|
|
|
|
chaiSetup.configure();
|
|
const expect = chai.expect;
|
|
|
|
describe('MnemonicWalletSubprovider', () => {
|
|
let subprovider: MnemonicWalletSubprovider;
|
|
before(async () => {
|
|
subprovider = new MnemonicWalletSubprovider({
|
|
mnemonic: fixtureData.TEST_RPC_MNEMONIC,
|
|
baseDerivationPath: fixtureData.TEST_RPC_MNEMONIC_BASE_DERIVATION_PATH,
|
|
});
|
|
});
|
|
describe('direct method calls', () => {
|
|
describe('success cases', () => {
|
|
it('returns the accounts', async () => {
|
|
const accounts = await subprovider.getAccountsAsync();
|
|
expect(accounts[0]).to.be.equal(fixtureData.TEST_RPC_ACCOUNT_0);
|
|
expect(accounts[1]).to.be.equal(fixtureData.TEST_RPC_ACCOUNT_1);
|
|
expect(accounts.length).to.be.equal(10);
|
|
});
|
|
it('signs a personal message', async () => {
|
|
const data = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING));
|
|
const ecSignatureHex = await subprovider.signPersonalMessageAsync(data, fixtureData.TEST_RPC_ACCOUNT_0);
|
|
expect(ecSignatureHex).to.be.equal(fixtureData.PERSONAL_MESSAGE_SIGNED_RESULT);
|
|
});
|
|
it('signs a personal message with second address', async () => {
|
|
const data = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING));
|
|
const ecSignatureHex = await subprovider.signPersonalMessageAsync(data, fixtureData.TEST_RPC_ACCOUNT_1);
|
|
expect(ecSignatureHex).to.be.equal(fixtureData.PERSONAL_MESSAGE_ACCOUNT_1_SIGNED_RESULT);
|
|
});
|
|
it('signs a transaction', async () => {
|
|
const txHex = await subprovider.signTransactionAsync(fixtureData.TX_DATA);
|
|
expect(txHex).to.be.equal(fixtureData.TX_DATA_SIGNED_RESULT);
|
|
});
|
|
it('signs a transaction with the second address', async () => {
|
|
const txData = { ...fixtureData.TX_DATA, from: fixtureData.TEST_RPC_ACCOUNT_1 };
|
|
const txHex = await subprovider.signTransactionAsync(txData);
|
|
expect(txHex).to.be.equal(fixtureData.TX_DATA_ACCOUNT_1_SIGNED_RESULT);
|
|
});
|
|
});
|
|
describe('failure cases', () => {
|
|
it('throws an error if address is invalid ', async () => {
|
|
const txData = { ...fixtureData.TX_DATA, from: '0x0' };
|
|
return expect(subprovider.signTransactionAsync(txData)).to.be.rejectedWith(
|
|
WalletSubproviderErrors.FromAddressMissingOrInvalid,
|
|
);
|
|
});
|
|
it('throws an error if address is valid format but not found', async () => {
|
|
const txData = { ...fixtureData.TX_DATA, from: fixtureData.NULL_ADDRESS };
|
|
return expect(subprovider.signTransactionAsync(txData)).to.be.rejectedWith(
|
|
`${WalletSubproviderErrors.AddressNotFound}: ${fixtureData.NULL_ADDRESS}`,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
describe('calls through a provider', () => {
|
|
let provider: Web3ProviderEngine;
|
|
before(() => {
|
|
provider = new Web3ProviderEngine();
|
|
provider.addProvider(subprovider);
|
|
const ganacheSubprovider = new GanacheSubprovider({});
|
|
provider.addProvider(ganacheSubprovider);
|
|
provider.start();
|
|
});
|
|
describe('success cases', () => {
|
|
it('returns a list of accounts', (done: DoneCallback) => {
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'eth_accounts',
|
|
params: [],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.be.a('null');
|
|
expect(response.result[0]).to.be.equal(fixtureData.TEST_RPC_ACCOUNT_0);
|
|
expect(response.result.length).to.be.equal(10);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('signs a personal message with eth_sign', (done: DoneCallback) => {
|
|
const messageHex = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING));
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'eth_sign',
|
|
params: [fixtureData.TEST_RPC_ACCOUNT_0, messageHex],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.be.a('null');
|
|
expect(response.result).to.be.equal(fixtureData.PERSONAL_MESSAGE_SIGNED_RESULT);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('signs a personal message with personal_sign', (done: DoneCallback) => {
|
|
const messageHex = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING));
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'personal_sign',
|
|
params: [messageHex, fixtureData.TEST_RPC_ACCOUNT_0],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.be.a('null');
|
|
expect(response.result).to.be.equal(fixtureData.PERSONAL_MESSAGE_SIGNED_RESULT);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
});
|
|
describe('failure cases', () => {
|
|
it('should throw if `data` param not hex when calling eth_sign', (done: DoneCallback) => {
|
|
const nonHexMessage = 'hello world';
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'eth_sign',
|
|
params: [fixtureData.TEST_RPC_ACCOUNT_0, nonHexMessage],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.not.be.a('null');
|
|
expect(err.message).to.be.equal('Expected data to be of type HexString, encountered: hello world');
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('should throw if `data` param not hex when calling personal_sign', (done: DoneCallback) => {
|
|
const nonHexMessage = 'hello world';
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'personal_sign',
|
|
params: [nonHexMessage, fixtureData.TEST_RPC_ACCOUNT_0],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.not.be.a('null');
|
|
expect(err.message).to.be.equal('Expected data to be of type HexString, encountered: hello world');
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('should throw if `address` param not found when calling personal_sign', (done: DoneCallback) => {
|
|
const messageHex = ethUtils.bufferToHex(ethUtils.toBuffer(fixtureData.PERSONAL_MESSAGE_STRING));
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'personal_sign',
|
|
params: [messageHex, fixtureData.NULL_ADDRESS],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.not.be.a('null');
|
|
expect(err.message).to.be.equal(
|
|
`${WalletSubproviderErrors.AddressNotFound}: ${fixtureData.NULL_ADDRESS}`,
|
|
);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('should throw if `from` param missing when calling eth_sendTransaction', (done: DoneCallback) => {
|
|
const tx = {
|
|
to: '0xafa3f8684e54059998bc3a7b0d2b0da075154d66',
|
|
value: '0xde0b6b3a7640000',
|
|
};
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'eth_sendTransaction',
|
|
params: [tx],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.not.be.a('null');
|
|
expect(err.message).to.be.equal(WalletSubproviderErrors.SenderInvalidOrNotSupplied);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
it('should throw if `from` param invalid address when calling eth_sendTransaction', (done: DoneCallback) => {
|
|
const tx = {
|
|
to: '0xafa3f8684e54059998bc3a7b0d2b0da075154d66',
|
|
from: '0xIncorrectEthereumAddress',
|
|
value: '0xde0b6b3a7640000',
|
|
};
|
|
const payload = {
|
|
jsonrpc: '2.0',
|
|
method: 'eth_sendTransaction',
|
|
params: [tx],
|
|
id: 1,
|
|
};
|
|
const callback = reportCallbackErrors(done)((err: Error, response: JSONRPCResponsePayload) => {
|
|
expect(err).to.not.be.a('null');
|
|
expect(err.message).to.be.equal(WalletSubproviderErrors.SenderInvalidOrNotSupplied);
|
|
done();
|
|
});
|
|
provider.sendAsync(payload, callback);
|
|
});
|
|
});
|
|
});
|
|
});
|