Remco Bloemen
|
d652deea23
|
Merge branch 'fix/contracts/robustMatching' of github.com:0xProject/0x.js into fix/contracts/robustMatching
|
2018-08-24 18:54:15 -07:00 |
|
Amir Bandeali
|
c8500cab10
|
Fix build
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c28c3db63f
|
Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow variations
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
a09ee90739
|
Add tests for matchOrders
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
7d5a23969d
|
Add reentrancy tests for fillOrder and wrapper functions
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
56c3c29feb
|
Update ReentrantERC20Token with new functions and check that revert is occuring for correct reason
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
c75212bef0
|
Add nonReentrant modifiers on functions that use getCurrentContextAddress only, add lockMutex modifier on functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6d0dedc62c
|
Split modifiers into check only and check, lock, unlock
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
cf12daea2f
|
Add ReentrantToken
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
6f88e9bdbd
|
Add internal fill functions, add reentrancy guard to public functions that make external calls
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
d8cb56caa3
|
Add ReentrancyGuard contract
|
2018-08-24 17:30:56 -07:00 |
|
Amir Bandeali
|
044415e23d
|
Remove redundant sload from getCurrentContextAddress
|
2018-08-24 17:30:56 -07:00 |
|
Remco Bloemen
|
6b866d6053
|
Revert maker not equal taker check
|
2018-08-24 17:29:52 -07:00 |
|
Amir Bandeali
|
74ce893f52
|
Merge pull request #1003 from 0xProject/feature/contracts/roundup
[contracts] Add getPartialAmountCeil and isRoundingErrorCeil
|
2018-08-24 17:29:09 -07:00 |
|
Amir Bandeali
|
cc1fac9bbe
|
Fix linting errors
|
2018-08-24 17:02:42 -07:00 |
|
Remco Bloemen
|
e215992859
|
Fix mixin api
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
29971f36cf
|
Split into assertFillable and assertValidFill
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
3e4493b389
|
Disallow self filling
|
2018-08-24 16:46:24 -07:00 |
|
Remco Bloemen
|
e6e7bae445
|
Remove BUG_ from revert reasons
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
a1d8943552
|
Document accetable price check
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
07e56b3cc7
|
Fix taker overpay check
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
b16f5f55fb
|
Check fillable early
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
d92fd43791
|
Update for new assertValidFill signature
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
e706fa76ac
|
Add overfill and price assertion to assertValidFill
|
2018-08-24 16:46:23 -07:00 |
|
Remco Bloemen
|
11328bd93d
|
Skip self-transfers
|
2018-08-24 16:26:48 -07:00 |
|
Remco Bloemen
|
bc686fcbf3
|
Stylistic fixes
|
2018-08-24 16:17:02 -07:00 |
|
Remco Bloemen
|
80291caf7c
|
Append -Floor to getPartialAmount and isRoundingError
|
2018-08-24 16:16:44 -07:00 |
|
Greg Hysen
|
a27112cbef
|
SignatureType.Trezor -> SignatureType.EthSign in Signature Validator tests
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
bb4d449e92
|
Test case for Trezor Model T signature
|
2018-08-24 14:40:00 -07:00 |
|
Greg Hysen
|
241534a63d
|
Fixed trezor personal message in client+contracts; added a test using message signed by Trezor One (firmware v1.6.2)
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
1932aff35c
|
Remove Trezor SignatureType
|
2018-08-24 14:40:00 -07:00 |
|
Amir Bandeali
|
8ce4f9c784
|
Remove SignatureType.Caller
|
2018-08-24 14:39:08 -07:00 |
|
Remco Bloemen
|
f6080367fe
|
Disambiguate the operator precedence
|
2018-08-24 14:11:45 -07:00 |
|
Remco Bloemen
|
7f78d7da9d
|
Add tests
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
6734f2f1bc
|
Add docs
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
0fb7617a78
|
Fix incorect modulus
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
4219af1430
|
Add DIVISION_BY_ZERO to getPartialAmount for consistency
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
c109d1f545
|
Remove .only
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
50fab9feb3
|
Improve getPartialAmountCeil docs
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
3dad6ee55e
|
Add tests for getPartialAmountCeil
|
2018-08-24 14:09:51 -07:00 |
|
Remco Bloemen
|
5d70df771b
|
Add isRoundingErrorCeil
|
2018-08-24 14:09:50 -07:00 |
|
Remco Bloemen
|
ab5df342e1
|
Add getPartialAmountCeil
|
2018-08-24 14:09:50 -07:00 |
|
Amir Bandeali
|
6a9669a409
|
Rethrow Wallet and Validator errors
|
2018-08-24 14:06:46 -07:00 |
|
Remco Bloemen
|
e68942ee78
|
Handle zero case
|
2018-08-24 13:45:10 -07:00 |
|
Remco Bloemen
|
4159e45aff
|
Update tests
|
2018-08-24 13:45:10 -07:00 |
|
Remco Bloemen
|
92497d7df4
|
Fix isRoundingError
|
2018-08-24 13:45:10 -07:00 |
|
Amir Bandeali
|
070eff6f3a
|
Rename TestStaticCall => TestStaticCallReceiver
|
2018-08-24 13:32:04 -07:00 |
|
Amir Bandeali
|
681ed822ec
|
Revert if undefined function called in AssetProxies
|
2018-08-24 13:19:07 -07:00 |
|
Amir Bandeali
|
0a1ae2c311
|
Remove pragma experimental v0.5.0 and use staticcall is assembly
|
2018-08-24 13:19:07 -07:00 |
|
Amir Bandeali
|
c5f8b9c2d2
|
Add pragma experimental v0.5.0 to SignatureValidator and add tests
|
2018-08-24 13:19:07 -07:00 |
|