Fabio Berger
d8df6968d3
remove unused import
2018-06-22 10:37:25 +02:00
Fabio Berger
0515c6acde
Merge pull request #752 from 0xProject/make-promises-safe-preloader
...
Use make-promises-safe as a preloader instead of manually importing
2018-06-22 10:32:06 +02:00
Amir Bandeali
607b44e01d
Check that assetProxy exists before attempting transfer
2018-06-21 22:45:15 -07:00
Amir Bandeali
5c0bae2070
Merge pull request #751 from 0xProject/feature/contracts/compilerRuns
...
Updated compiler runs to be 1,000,000
2018-06-21 22:06:31 -07:00
Alex Browne
4012e31115
Use make-promises-safe as a preloader instead of manually importing
2018-06-21 19:17:33 -07:00
Greg Hysen
2d8e9eda56
Converted hashZeroExTransaction to assembly. Saves 1k gas
2018-06-21 18:49:17 -07:00
Greg Hysen
c131d82699
Updated compiler runs to be 1,000,000
2018-06-21 17:58:39 -07:00
Amir Bandeali
b333ed91de
Add event to setSignatureValidatorApproval, rename signer => signerAddress accross all contracts
2018-06-21 16:10:12 -07:00
Amir Bandeali
6a073d5f86
Add senderAddress to Fill and Cancel logs, add comments to events and types
2018-06-21 16:09:38 -07:00
Austin Roberts
a3ba7683f4
Remove unreachable PreSigned check
...
This code was unreachable, as it had the exact same condition as line 206.
2018-06-21 14:15:20 -05:00
Fabio Berger
a0b225b8b1
Test revert reasons in proxy tests
2018-06-21 17:43:48 +02:00
Fabio Berger
323e8756ba
remove only
2018-06-21 17:27:26 +02:00
Fabio Berger
ada5428df7
Check revert reasons in Authorizable tests
2018-06-21 17:23:59 +02:00
Fabio Berger
7869c19245
Change revert reason in ownable to be similar to all other revert reasons
2018-06-21 17:23:42 +02:00
Fabio Berger
5706b29c8c
remove .only
2018-06-21 17:06:44 +02:00
Fabio Berger
eaabe15863
Update core tests to actually check revert message
2018-06-21 16:53:05 +02:00
Greg Hysen
6d5b16725d
Set settleOrder and settleMatchedOrders to private
2018-06-20 17:27:45 -07:00
Greg Hysen
8ee6e26608
Removed MixinSettlement. Moved settleOrder into MixinExchangeCore and settleMatchedOrders into MixinMatchOrders
2018-06-20 15:36:28 -07:00
Greg Hysen
491a322ceb
Linter
2018-06-20 13:54:39 -07:00
Greg Hysen
12e16d532b
Renamed constants in test wallet/validator
2018-06-20 13:54:39 -07:00
Greg Hysen
7814a391d8
Few more minor #nit wording changes
2018-06-20 13:54:39 -07:00
Greg Hysen
322151b0d5
Changed wording of two tests #nit
2018-06-20 13:54:39 -07:00
Greg Hysen
4a136cafda
Minor improvements to MixinSignatureValidator tests
2018-06-20 13:54:39 -07:00
Greg Hysen
d0df25d9e2
Remove .only
2018-06-20 13:54:39 -07:00
Greg Hysen
8d003dbc30
Fixed two mislabelled revert reasons + Signature Validator revert tests working on Geth
2018-06-20 13:54:39 -07:00
Greg Hysen
2c7358d64f
Minor style tweaks
2018-06-20 13:54:39 -07:00
Greg Hysen
d46e3f6778
Twenty new tests for MixinSignatureValidator. Fixed handling of unsupported types. Fixed trezor prefix.
2018-06-20 13:54:39 -07:00
Fabio Berger
5bfdffda11
Add support for approveAll in assetWrapper and fillOrderScenarios
2018-06-20 19:14:04 +02:00
Fabio Berger
3ce449e167
Improve verbose logging
2018-06-20 19:12:31 +02:00
Fabio Berger
5c0183c71e
Fix merge variable name issue
2018-06-20 14:08:56 +02:00
Fabio Berger
fb7d425244
Add support for setting allowance to unlimited
2018-06-20 13:56:27 +02:00
Fabio Berger
3fab40efe5
Add noop conditionals for clarity
2018-06-20 13:55:45 +02:00
Fabio Berger
0bbdbc9e63
Rename for clarity
2018-06-20 13:55:28 +02:00
Fabio Berger
9bc481ff62
Split balance and allowance amount types in prep of adding the "unlimited" allowance enum value
2018-06-20 13:36:57 +02:00
Fabio Berger
32dea43d2e
Remove unneeded explicit type def
2018-06-20 13:31:57 +02:00
Fabio Berger
632da71a8d
Add TS 2.7 numeric separators to improve readability
2018-06-20 13:31:21 +02:00
Fabio Berger
2ffab22185
Merge branch 'v2-prototype' into feature/combinatorial-testing
...
* v2-prototype: (22 commits)
Fix closing parens in liborder
Update after rebase
ERC721Proxy Always call safeTransferFrom
Rename makerEpoch => orderEpoch
Make cancelOrdersUpTo compatible with sender abstraction
Update PR template
Use Image component instead of img tag
Assembler orderHash function
Optimize and remove redundant encodePacked
Fix linting issue
Fix bug where we do fetch balances on wallet login
Check network state immediately instead of waiting for delay
Fix onboarding persisting when changing routes
Consolidate account state messaging logic
Only elevate wallet zIndex when onboarding is in progress
Rebase and update feedback
Run linter
Add Portal v2 logging
Simplified handling of source < 32 edge case
Basic EIP712 encoder
...
2018-06-20 13:25:29 +02:00
Fabio Berger
5541327968
Add ability for verbose logging
2018-06-20 13:24:09 +02:00
Jacob Evans
096eaa20d7
Merge pull request #637 from 0xProject/bug/contracts/eip712-191-prefix
...
Add missing EIP191 prefix for EIP712 and Execute Transaction
2018-06-20 10:54:51 +10:00
Jacob Evans
512bd84cc2
Fix closing parens in liborder
2018-06-20 10:27:45 +10:00
Jacob Evans
25fa29e6e1
Update after rebase
2018-06-20 10:01:41 +10:00
Jacob Evans
bddc47f9b2
ERC721Proxy Always call safeTransferFrom
2018-06-20 10:00:59 +10:00
Amir Bandeali
6b08e6b809
Rename makerEpoch => orderEpoch
2018-06-19 13:52:23 -07:00
Amir Bandeali
e92926e881
Make cancelOrdersUpTo compatible with sender abstraction
2018-06-19 13:04:55 -07:00
Fabio Berger
f35af1fb6d
Fix typo
2018-06-19 17:53:16 +02:00
Fabio Berger
c0e008c601
Rename NewOrderFactory to OrderFactoryFromScenario for clarity
2018-06-19 17:41:10 +02:00
Fabio Berger
9acf4458c0
Remove hack in ERC20Wrapper
2018-06-19 17:38:15 +02:00
Fabio Berger
70de264d4d
Cleanup coreCombinatorialUtils
2018-06-19 17:31:26 +02:00
Fabio Berger
1a0b9e4612
Comments and cleanup
2018-06-19 17:25:08 +02:00
Remco Bloemen
66dc70c057
Merge pull request #683 from 0xProject/fix/contracts/memcpy
...
Simplified handling of source < 32 edge case
2018-06-19 13:53:25 +02:00
