Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Amir Bandeali
4c78b7d4bb
Merge pull request #2055 from 0xProject/feat/3.0/optimizeConstants
...
Refactor library usage
2019-08-16 07:40:54 -07:00
Amir Bandeali
7ac30c5153
Merge branch '3.0' into feat/3.0/optimizeConstants
2019-08-15 15:20:48 -07:00
Greg Hysz
64bc99101c
Merge pull request #2059 from 0xProject/feature/contracts/3.0/fillOrderAssertionWrapper
...
Fill Order Assertion Wrapper
2019-08-15 00:12:40 +02:00
Greg Hysen
09b5018e65
Readability improvements
2019-08-14 23:45:07 +02:00
Alex Towle
6b4e632101
@0x:contracts-exchange
Refactored internal.ts so that it is more readable
2019-08-14 10:39:36 -07:00
Alex Towle
0134b2874b
@0x:contracts-exchange
Addressed remaining review comments
2019-08-13 17:05:38 -07:00
Alex Towle
e2308aabed
@0x:contracts-exchange
Reduced the code size of internal.ts
2019-08-13 17:04:42 -07:00
Alex Towle
327c6e8ac2
Completed the calculateMatchedFillResultsWithMaximalFill tests
2019-08-13 17:04:25 -07:00
Alex Towle
e9d49d96a6
Changed the testing style to be more assertion based rather than reference based to leverage the fixtures from the integration tests
2019-08-13 17:04:25 -07:00
Alex Towle
929bb86a54
Wrote some test cases for assertValidMatch
2019-08-13 17:04:25 -07:00
Alex Towle
f58e28d1be
Implemented reference functions and added tests for _calculateCompleteRightFill
2019-08-13 17:04:25 -07:00
Alex Towle
cdabe21e7a
Fixed the tests by using the IsolatedExchange
2019-08-13 17:04:25 -07:00
Alex Towle
a7520eeaa8
Wrote some initial test cases for the matchOrders calculate functions
2019-08-13 17:02:00 -07:00
Amir Bandeali
d6772b4a0a
Fix linting errors
2019-08-13 16:11:57 -07:00
Amir Bandeali
5016d50c2b
Move calculateFillResults tests to exchange-libs package
2019-08-13 16:11:09 -07:00
Amir Bandeali
7d5276ad11
Remove LibExchangeSelectors.sol
2019-08-13 16:04:33 -07:00
Greg Hysen
dd4541c825
Fill Order Assertion Wrapper
2019-08-13 17:51:40 +02:00
Lawrence Forman
fc18db10be
@0x/contracts-exchange
: Add tests for when callback signature types return incorrect data.
2019-08-12 19:10:24 -04:00
Lawrence Forman
6df190edbb
@0x/contracts-exchange
: Light changes to address PR comments.
2019-08-12 18:20:50 -04:00
Lawrence Forman
5b0b8a9717
@0x/contracts-exchange
: Remove explicit signerAddress
parameter from many MixinSignatureValidator
functions.
2019-08-12 18:10:57 -04:00
Lawrence Forman
370df0d495
@0x/contracts-dev-utils
: Prettier.
...
`@0x/contracts-exchange`: Update reentrancy tests.
`@0x/contracts-exchange`: Add all mutator functions to
`ExchangeFunctions` type.
`@0x/contracts-tes-utils`: Remove unused import.
2019-08-09 22:15:33 -04:00
Lawrence Forman
d4e300d0a4
@0x/contracts-dev-util
: Remove references to marketXOrdersNoThrow
.
...
`@0x/contracts-exchange`: Remove references to `marketXOrdersNoThrow`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c83864af9c
@0x/contracts-exchange
: Fix broken tests.
...
`@0x/contracts-test-utils`: Remove unecessary wait timeout in
`LogDecoder`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
a2234b745c
@0x/contracts-exchange
: Create semi-automated reentrancy testing.
...
`@0x/contracts-exchange`: Remove old reentrancy tests.
`@0x/contracts-exchange`: Remove `ReentrantERC20Token` contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
3dd8dac146
@0x/contracts-exchange
: Update Wallet
signature type behavior to match v2.1.
...
`@0x/contracts-exchange`: Add EOA tests to `signature_validator`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
0d05411cd2
@0x/contracts-exchange
: Update CHANGELOG, lint, prettify.
2019-08-09 22:15:33 -04:00
Lawrence Forman
7ce65e3cfe
@0x/contracts-exchange
: Wrap up tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ea1501abd1
@0x/contracts-exchange
: Change how order hashes and signatures are computed for wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ca28b8f93e
@0x/contracts-exchange
: Make marketBuy/SellNoThrow
the default.
...
`@0x/contracts-exchange`: Add more `wrapper_unit_tests` tests.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c18e8ba242
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
1f3f0dce11
@0x/contracts-exchange
: Add fillOrderNoThrow
tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
b73008d83d
@0x/contracts-exchange
: Fix fillOrKillOrder()
tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
10a8291391
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ab094ab174
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
29a82f8471
@0x/contracts
: Create TestWrapperFunctions
contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
e3aa76cd09
@0x/contracts-exchange
: Light refactoring in
...
`isolated_fill_order.ts` and `isolated_exchange_wrapper.ts`.
2019-08-08 11:43:55 -04:00
Lawrence Forman
6d502b6898
@0x/contracts-exchange
: Use TransactionHelper
to call and execute
...
contract functions.
2019-08-06 15:31:30 -04:00
Lawrence Forman
b6dfc791d4
@0x/contracts-exchange
: Correct test case name.
2019-08-06 15:31:30 -04:00
Lawrence Forman
7002dc63bd
@0x/contracts-exchange
: Fix typos in comments.
2019-08-06 15:31:30 -04:00
Lawrence Forman
6345faa4a9
`@0x/contracts-exchange-libs: Appease the linter and prettier gods.
2019-08-06 15:30:59 -04:00
Lawrence Forman
4711ce5532
@0x/contracts-exchange
: Remove _assertValidFill()
.
...
`@0x/contracts-exchange`: Add `_settleOrder()` unit tests.
`@0x/contracts-exchange`: Add explicit tests for
`_calculateFillResults()`.
`@0x/contracts-exchange`: Add overflow tests to `isolated_fill_order`
tests.
`@0x/contracts-exchange`: Add explicit `takerAssetFillAmount = 0` test
to `isolated_fill_order` tests.
2019-08-06 15:30:59 -04:00
Lawrence Forman
51391b7f0e
@0x/contracts-exchange-libs
: Correct internal variable naming in src/index.ts
.
...
`@0x/contracts-utils`: Correct internal variable naming in `src/index.ts`.
`@0x/contracts-exchange`: Remove functions from `TestExchangeInternals.sol` that are now in other packages.
`@0x/contracts-exchange`: Remove `TestExchangeMath.sol`. Exchange math functions are now tested in `@0x/contracts-exchange-libs`.
`@0x/contracts-exchange`: Move `ReferenceFunctions` to default package export.
`@0x/contracts-exchange`: Update `match_order.ts` tests to use reference math functions instead of `TestExchangeMath`.
`@0x/contracts-exchange`: Remove `_updateFilledState()` combinatorial tests in favor of normal unit testing. Combinatorial testing was overkill.
`@0x/contracts-exchange`: Update/refactor `calculateFillResults()` combinatorial tests to use the reference functions and hide them behind `TEST_ALL`.
2019-08-06 15:30:59 -04:00
Lawrence Forman
a3cdb63ae1
@0x/contracts-exchange
: Rename TestIsolatedExchange
to just IsolatedExchange
.
2019-08-06 15:30:30 -04:00
Lawrence Forman
9d5b23acd3
@0x/contracts-exchange
: Update tests in isolated_fill_order.ts
.
2019-08-06 15:30:30 -04:00
Lawrence Forman
41e04c0178
@0x/contracts-exchange
: Add a buttload of tests to
...
`isolated_fill_order.ts`.
2019-08-06 15:30:30 -04:00
Lawrence Forman
898213bb85
@0x/contracts-exchange
: Update tests for moved types.
2019-08-06 15:30:30 -04:00
Lawrence Forman
c54d69e5ae
@0x/contracts-exchange
: Create reference functions test util.
...
`@0x/contracts-exchange`: Use reference functions to assert fill results
in `isolated_fill_order` tests.
2019-08-06 15:27:39 -04:00
Lawrence Forman
e2bd80253b
@0x/contracts-exchange
: More TestIsolatedExchange
rework.
2019-08-06 15:27:39 -04:00
Lawrence Forman
039cc6e28b
@0x/contracts-exchange
: Allow fetching of balance of multiple assets
...
in `TestIsolatedExchange` contract.
`@0x/contracts-exchange`: Refactor `IsolatedExchangeWrapper` to be more
extensible.
2019-08-06 15:27:39 -04:00