Remco Bloemen
4bf4f96f47
Fix LibBytes.equals
2018-06-23 13:53:38 +02:00
Remco Bloemen
384cd2f605
Add trailing garbage testcase for LibBytes.equals
2018-06-23 13:53:38 +02:00
Remco Bloemen
425af46f98
Rename bytes.equals
2018-06-23 13:53:38 +02:00
Remco Bloemen
c83ee04662
Add slice and sliceDestructive
2018-06-23 13:53:38 +02:00
Remco Bloemen
2054cd78da
Rename bytes.rawAddress and add bytes.contentAddress
2018-06-23 13:53:38 +02:00
Remco Bloemen
88982f98ff
Rename read/writeBytesWithLength
2018-06-23 13:53:38 +02:00
Remco Bloemen
2ea0b839d3
Using LibBytes for bytes
2018-06-23 13:53:38 +02:00
Remco Bloemen
afd83e59b8
Make LibBytes a library
2018-06-23 13:53:38 +02:00
Remco Bloemen
7f84049538
Merge LibMem and LibBytes
2018-06-23 13:53:38 +02:00
Remco Bloemen
98840c9c5f
Use provided mem in refernce memcpy
2018-06-23 13:53:38 +02:00
Amir Bandeali
26cacfa247
Merge pull request #749 from 0xProject/feature/contracts/transactionHashAsm
...
Converted `hashZeroExTransaction` to assembly. Saves 1k gas
2018-06-22 16:57:50 -07:00
Greg Hysen
7fcd34eb36
Apply mask to address to zero-out unused bytes.
2018-06-22 16:35:50 -07:00
Fabio Berger
2f6f815d81
Fix tslint
2018-06-22 18:54:18 +02:00
Fabio Berger
1e03fbe1a8
Fix prettier
2018-06-22 18:50:02 +02:00
Fabio Berger
4409f11b24
Rename ContractLibErrors to RevertReasons
2018-06-22 18:45:45 +02:00
Fabio Berger
7a216901be
Remove revert reason 'Exchange' prefix
2018-06-22 18:41:55 +02:00
Fabio Berger
0e7c254b93
Move constants over to ContractLibError enum and update all tests
2018-06-22 18:36:15 +02:00
Fabio Berger
ba14850c9a
Standardize ERC20 error strings given convention
2018-06-22 18:35:35 +02:00
Fabio Berger
59d3a21993
Fix test now that contract reverts with message
2018-06-22 17:39:41 +02:00
Fabio Berger
d2faa49bf4
Merge branch 'v2-prototype' into refactor/check-revert-reasons
...
* v2-prototype:
Check that assetProxy exists before attempting transfer
2018-06-22 17:15:51 +02:00
Fabio Berger
438c0e27ea
Merge pull request #748 from 0xProject/fix/contracts/nullAssetProxy
...
Check that assetProxy exists before attempting transfer
2018-06-22 17:14:22 +02:00
Fabio Berger
4c14372b4a
Add revert reason checks to wrapper tests
2018-06-22 17:12:52 +02:00
Fabio Berger
8b4077d7de
Fix tests
2018-06-22 17:12:31 +02:00
Fabio Berger
914b009361
Change Whitelist error messages to conform to rest and added revert reason checks to transactions tests
2018-06-22 17:12:17 +02:00
Fabio Berger
daa50442c9
Add revert reason checks to match_orders tests
2018-06-22 14:28:01 +02:00
Fabio Berger
76fd7f47eb
Fix tests
2018-06-22 14:13:44 +02:00
Fabio Berger
3ce295a2af
Merge branch 'v2-prototype' into refactor/check-revert-reasons
...
* v2-prototype: (40 commits)
Use make-promises-safe as a preloader instead of manually importing
Updated compiler runs to be 1,000,000
Add event to setSignatureValidatorApproval, rename signer => signerAddress accross all contracts
Add senderAddress to Fill and Cancel logs, add comments to events and types
Fix Island component
Add missing image assets for Chris and Mel
Fix some bugs in sol-cov
Remove unreachable PreSigned check
Fix linting
Buttons look hella disabled now
Remove border radius, fix width issue for unlock step
Add Chris and Mel to about page
fix linter issues
only call getLocationByOffset if source if defined
Set settleOrder and settleMatchedOrders to private
Prevent prettier issue
Support mobile friendly onboarding flows
Removed MixinSettlement. Moved `settleOrder` into `MixinExchangeCore` and `settleMatchedOrders` into `MixinMatchOrders`
Migrations after rebasing
Linter
...
2018-06-22 10:39:07 +02:00
Fabio Berger
a30107ab86
Check revert reason in dispatcher tests
2018-06-22 10:38:08 +02:00
Fabio Berger
d8df6968d3
remove unused import
2018-06-22 10:37:25 +02:00
Fabio Berger
0515c6acde
Merge pull request #752 from 0xProject/make-promises-safe-preloader
...
Use make-promises-safe as a preloader instead of manually importing
2018-06-22 10:32:06 +02:00
Amir Bandeali
607b44e01d
Check that assetProxy exists before attempting transfer
2018-06-21 22:45:15 -07:00
Amir Bandeali
5c0bae2070
Merge pull request #751 from 0xProject/feature/contracts/compilerRuns
...
Updated compiler runs to be 1,000,000
2018-06-21 22:06:31 -07:00
Alex Browne
4012e31115
Use make-promises-safe as a preloader instead of manually importing
2018-06-21 19:17:33 -07:00
Greg Hysen
2d8e9eda56
Converted hashZeroExTransaction to assembly. Saves 1k gas
2018-06-21 18:49:17 -07:00
Greg Hysen
c131d82699
Updated compiler runs to be 1,000,000
2018-06-21 17:58:39 -07:00
Amir Bandeali
b333ed91de
Add event to setSignatureValidatorApproval, rename signer => signerAddress accross all contracts
2018-06-21 16:10:12 -07:00
Amir Bandeali
6a073d5f86
Add senderAddress to Fill and Cancel logs, add comments to events and types
2018-06-21 16:09:38 -07:00
Austin Roberts
a3ba7683f4
Remove unreachable PreSigned check
...
This code was unreachable, as it had the exact same condition as line 206.
2018-06-21 14:15:20 -05:00
Fabio Berger
a0b225b8b1
Test revert reasons in proxy tests
2018-06-21 17:43:48 +02:00
Fabio Berger
323e8756ba
remove only
2018-06-21 17:27:26 +02:00
Fabio Berger
ada5428df7
Check revert reasons in Authorizable tests
2018-06-21 17:23:59 +02:00
Fabio Berger
7869c19245
Change revert reason in ownable to be similar to all other revert reasons
2018-06-21 17:23:42 +02:00
Fabio Berger
5706b29c8c
remove .only
2018-06-21 17:06:44 +02:00
Fabio Berger
eaabe15863
Update core tests to actually check revert message
2018-06-21 16:53:05 +02:00
Greg Hysen
6d5b16725d
Set settleOrder and settleMatchedOrders to private
2018-06-20 17:27:45 -07:00
Greg Hysen
8ee6e26608
Removed MixinSettlement. Moved settleOrder into MixinExchangeCore and settleMatchedOrders into MixinMatchOrders
2018-06-20 15:36:28 -07:00
Greg Hysen
491a322ceb
Linter
2018-06-20 13:54:39 -07:00
Greg Hysen
12e16d532b
Renamed constants in test wallet/validator
2018-06-20 13:54:39 -07:00
Greg Hysen
7814a391d8
Few more minor #nit wording changes
2018-06-20 13:54:39 -07:00
Greg Hysen
322151b0d5
Changed wording of two tests #nit
2018-06-20 13:54:39 -07:00
