protocol

crowetic/protocol

Fork 0

Commit Graph

Author	SHA1	Message	Date
Jacob Evans	88c99396a2	Rename OrderAlreadyCancelledOrFilled -> OrderCancelled. Remove try catch of throwing errors in favour of returning the Errors in a OrderValidationResult	2018-08-16 11:12:35 +10:00
Jacob Evans	622509c508	[Order-utils] Order is valid when maker amount is very small Previously our min fillable calculation would throw a rounding error when encountering a valid order (with a small maker amount). This was inconsistent with the on-chain logic which allowed this order to be filled.	2018-08-15 13:06:32 +10:00

Author

SHA1

Message

Date

Jacob Evans

88c99396a2

Rename OrderAlreadyCancelledOrFilled -> OrderCancelled.

Remove try catch of throwing errors in favour of returning the Errors in a OrderValidationResult

2018-08-16 11:12:35 +10:00

Jacob Evans

622509c508

[Order-utils] Order is valid when maker amount is very small

Previously our min fillable calculation would throw a rounding error
when encountering a valid order (with a small maker amount). This was
inconsistent with the on-chain logic which allowed this order to be
filled.

2018-08-15 13:06:32 +10:00

2 Commits