Lawrence Forman
6b8bc55c74
@0x/contracts-test-utils
: web3Wrapper
is created with shouldAllowUnlimitedContractSize
if UNLIMITED_CONTRACT_SIZE
environment variable is set.
2019-08-21 10:59:34 -04:00
Lawrence Forman
edef3bc30e
@0x/contracts-exchange
: Fix failing wrapper.ts
test.
2019-08-21 10:59:34 -04:00
Lawrence Forman
0c7f09b832
ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
34d075ce8c
@0x/contracts-exchange
: Update marketBuy/SellOrdersNoThrow()
to NOT be destructive to the orders.
...
`@0x/contracts-exchange`: Fix wrapper unit tests to use the actual order hash algorithm, since it can't be overridden anymore.
2019-08-21 10:59:34 -04:00
Lawrence Forman
8c06d660ea
Update CHANGELOGs with PR numbers.
2019-08-21 10:59:34 -04:00
Lawrence Forman
748566b4fb
@0x/contracts-exchange
: Tweak exchangeDataEncoder
test utility to work with marketBuy/SellFillOrKill()
functions.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fb38867e78
Ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
a2613625c6
@0x/contracts-exchange
: Squelch linter errors in LibExchangeRichErrorDecoder
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
89f1d54ebc
@0x/contracts-dev-utils
: Add marketBuy/SellOrdersNoThrow
and marketBuy/SellOrdersFillOrKill
to LibTransactionDecoder
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fd2a240c9f
@0x/contracts-exchange`: Update changelog.
2019-08-21 10:59:34 -04:00
Lawrence Forman
96bef08ac2
@0x/contracts-exchange
: Rename marketSellOrders
and marketBuyOrders
back to marketSellOrdersNoThrow
and marketBuyOrdersNoThrow
.
...
`@0x/contracts-exchange`: Introduce new `marketSellOrdersFillOrKill` and `marketBuyOrdersFillOrKill` functions.
`@0x/contracts-exchange`: Add new rich error types: `IncompleteMarketBuyError` and `IncompleteMarketSellError`.
`@0x/contracts-exchange`: Use `abi.decode()` in `LibExchangeRichErrorDecoder` over `LibBytes`.
2019-08-21 10:59:34 -04:00
Lawrence Forman
1698519a6a
@0x/contracts-exchange
: Overridden functions in ReentrancyTester
now return sane values.
2019-08-21 10:59:34 -04:00
Lawrence Forman
d8372f73bc
@0x/contracts-exchange-libs
: Add new revert types and use abi.decode()
instead of LibBytes
.
2019-08-21 10:59:34 -04:00
Michael Zhu
66f175b659
post-rebase fix
2019-08-20 17:41:26 -07:00
Michael Zhu
755ef35955
prettier
2019-08-20 17:24:59 -07:00
Michael Zhu
b5d6156ffa
use mocha extensions
2019-08-20 17:24:59 -07:00
Michael Zhu
8dd8cf8673
might as well change ethValueAdjustment to number too
2019-08-20 17:24:59 -07:00
Michael Zhu
9e46099ced
change fractionalNumberOfOrdersToFill to number
2019-08-20 17:24:59 -07:00
Michael Zhu
9f4fe259f9
update some RichErrors and @return directives per comments
2019-08-20 17:24:59 -07:00
Michael Zhu
3c169388e2
refactor + address comments on forwarder mixins
2019-08-20 17:24:59 -07:00
Michael Zhu
b9e75769a3
add tests for partially filled, unfillable orders
2019-08-20 17:24:59 -07:00
Michael Zhu
17a9edd8c3
check order statuses
2019-08-20 17:24:59 -07:00
Michael Zhu
090b83a237
tests for invalid fee assets
2019-08-20 17:24:59 -07:00
Michael Zhu
e5ee794895
slipped through from a previous commit
2019-08-20 17:24:59 -07:00
Michael Zhu
2b572cc28f
fix lint
2019-08-20 17:24:59 -07:00
Michael Zhu
88544ae0ef
fix dependencies
2019-08-20 17:24:59 -07:00
Michael Zhu
146d56be84
use new lib function names
2019-08-20 17:24:59 -07:00
Michael Zhu
1934dddcbe
use different maker/taker amounts in tests
2019-08-20 17:24:59 -07:00
Michael Zhu
f1c51bd0db
refactor + revert when takerFeeAssetData is neither WETH nor makerAssetData
2019-08-20 17:24:59 -07:00
Michael Zhu
d91fc59a28
change marketSell/marketBuy to return relevant amounts, change marketBuy so that makerAssetBuyAmount == makerAssetAcquiredAmount
2019-08-20 17:24:59 -07:00
Michael Zhu
f8025feda2
update tests to use RevertErrors
2019-08-20 17:24:58 -07:00
Michael Zhu
c9f0c46017
forwarder rich errors second pass
2019-08-20 17:24:58 -07:00
Michael Zhu
5879aeac52
forwarder rich errors first pass
2019-08-20 17:24:58 -07:00
Michael Zhu
3da55ad836
lint
2019-08-20 17:23:55 -07:00
Michael Zhu
26bfcccedc
use ForwarderTestFactory for most forwarder tests + some comments in forwarder_test_factory
2019-08-20 17:23:55 -07:00
Michael Zhu
af6243afb0
handle reverts and ERC721 in ForwarderTestFactory + refactoring
2019-08-20 17:23:55 -07:00
Michael Zhu
673a341626
make approveMakerAssetProxy an external function and update comments
2019-08-20 17:23:55 -07:00
Michael Zhu
a1aee7111a
minor fixes
2019-08-20 17:23:55 -07:00
Michael Zhu
688209e272
refactoring and marketBuyTestAsync
2019-08-20 17:23:55 -07:00
Michael Zhu
116945047b
forwarder test factory first pass (supports orders with no fees and percentage fees)
2019-08-20 17:23:55 -07:00
Michael Zhu
1b8a9e16e2
slightly restructure contracts to fix bug in the WETH-fee case
2019-08-20 17:23:55 -07:00
Michael Zhu
7ff7e9d2e7
Tests for orders without fees, orders with percentage-based fees (no forwarder fees)
2019-08-20 17:23:55 -07:00
Michael Zhu
15c0d622c9
Update function definitions, require that makerAsset is the same across orders, approve proxy to transfer makerAsset (for percentage-based fees)
2019-08-20 17:23:55 -07:00
Michael Zhu
25087f3c92
Remove fee abstraction from Forwarder contracts (first pass)
2019-08-20 17:23:55 -07:00
Michael Zhu
34be9830af
fix imports and inheritance, update tests for forwarder
2019-08-20 17:23:55 -07:00
Amir Bandeali
430d068d78
Add truffle compile to build in CI
2019-08-20 12:57:31 -07:00
Amir Bandeali
f09cadb7b3
Add truffle compile option to contract packages
2019-08-20 12:49:33 -07:00
Amir Bandeali
c366a4bd83
Update copyright dates
2019-08-20 12:49:01 -07:00
Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Amir Bandeali
4c78b7d4bb
Merge pull request #2055 from 0xProject/feat/3.0/optimizeConstants
...
Refactor library usage
2019-08-16 07:40:54 -07:00