F. Eugene Aumson
bca8c5eccc
DevUtils.sol: Upgrade for v3 ( #2161 )
...
* Exhibit bug in getSimulatedOrderTransferResults
* Fix getSimulatedOrderTransferResults
* dev-utils/package.json: add quantify_bytecode cmd
* Fix typo in log message
* Reduce compiler optimization runs
In order to reduce the EVM bytecode object length of the DevUtils
contract to be under the EIP-170 limit of 24 KB.
2019-09-18 19:36:06 -04:00
Amir Bandeali
bb46f184ed
Remove use of generatePseudoRandomAddress in favor of randomAddress
2019-09-17 10:46:58 -07:00
Amir Bandeali
67ef17f929
Consolidate TransactionSignatureError with SignatureError
2019-09-08 18:55:42 -07:00
Amir Bandeali
35bf179b70
Clear compiler warnings
2019-09-07 22:20:47 -07:00
Amir Bandeali
10c62c10aa
Use _getOrderHashAndFilledAmount instead of getOrderInfo to reduce sloads
2019-09-07 22:10:46 -07:00
Amir Bandeali
8317628c61
Create internal function that calculates orderHash and orderTakerAssetFilledAmount
2019-09-07 22:10:05 -07:00
Amir Bandeali
0e96a1c8ba
Remove restrictions that maker/takerAssetData must be the same for each order in marketBuy/Sell functions
2019-09-06 14:34:16 -07:00
Amir Bandeali
cf35a8032d
Update contracts/exchange/contracts/src/MixinProtocolFees.sol
...
Update comment
Co-Authored-By: James Towle <jalextowle@gmail.com>
2019-09-04 11:34:17 -07:00
Amir Bandeali
90ac5ec577
Fix tests
2019-09-03 20:11:48 -07:00
Amir Bandeali
d1eb414749
Use new rich reverts where applicable
2019-09-03 20:11:47 -07:00
Amir Bandeali
e5706606a0
Create private functions for encoding orders/transactions with their hash to be passed into EIP1271 compliant contract
2019-09-03 20:11:43 -07:00
Amir Bandeali
49725c8c33
Styling and comment updates
2019-09-03 17:52:41 -07:00
Amir Bandeali
cb8cf1f107
Add back batchFillOrders
2019-09-03 11:06:45 -07:00
Amir Bandeali
ea8669439f
Minor styling and naming changes
2019-09-03 09:48:21 -07:00
Amir Bandeali
75a8b1c081
Use same taker numerator/denominator for all math in calculateFillResults
2019-09-03 09:48:16 -07:00
Amir Bandeali
73144fa4d5
Fix _setCurrentContextAddressIfRequired
2019-09-02 20:35:20 -07:00
Amir Bandeali
a6b60f3230
Create _readSignatureType with minimal validation
2019-09-02 20:34:23 -07:00
Amir Bandeali
48dfb3317a
Fix tests
2019-09-02 14:36:27 -07:00
Amir Bandeali
b3b0496c49
Fix build and linting errors
2019-09-02 11:41:13 -07:00
Amir Bandeali
e880447714
Refactor EIP1271Wallet and Validator types to use new EIP1271SignatureError
2019-09-02 11:38:52 -07:00
Amir Bandeali
fd4d10e7a4
Create EIP1271SignatureError rich revert
2019-09-02 11:37:39 -07:00
Amir Bandeali
18b65a61ff
Fix build
2019-09-01 19:14:16 -07:00
Amir Bandeali
02a1e17f50
Reuse EIP1271 wallet code with internal function
2019-09-01 18:53:57 -07:00
Amir Bandeali
d131c39e46
Create _setCurrentContextAddressIfRequired function in MixinTransactions
2019-09-01 18:31:46 -07:00
Amir Bandeali
dd499591e9
Make assetProxies mapping internal (getter function already exists)
2019-09-01 15:13:57 -07:00
Amir Bandeali
c0f1e5f17f
Make fillOrderNoThrow internal only, remove batchFillOrders
2019-09-01 12:22:00 -07:00
Amir Bandeali
b888e48a30
Remove getOrdersInfo
2019-09-01 11:24:16 -07:00
Amir Bandeali
8410ee9d2f
Remove unnecessary public functions
2019-09-01 11:01:01 -07:00
Amir Bandeali
b7238c702b
Increase optimizer runs
2019-09-01 11:00:07 -07:00
Amir Bandeali
b20503c5a2
Fix off by 1 error
2019-08-30 11:39:28 -07:00
Amir Bandeali
d0869a8840
Fix linting errors
2019-08-30 11:39:28 -07:00
Amir Bandeali
c156bfc534
Remove TestValidatorWallet DataType
2019-08-30 11:39:28 -07:00
Amir Bandeali
5f8e092c96
Move EIP1271 selectors to their own interface
2019-08-30 11:39:27 -07:00
Amir Bandeali
87c9f9af71
Remove example contracts
2019-08-30 11:37:40 -07:00
Amir Bandeali
65e5ecf49d
Encode arguments with selector before passing into EIP1271 isValidSignature
2019-08-30 11:32:22 -07:00
Alex Towle
2c1393fb09
@0x:contracts-exchange
Addressed lingering review comments
2019-08-29 23:50:48 -07:00
Alex Towle
dba0d8469d
@0x:contracts-exchange
Addressed review feedback
2019-08-29 15:20:52 -07:00
Alex Towle
75e6c45285
@0x:contracts-exchange
Added the tests for getOrdersInfo
back into the exchange
2019-08-28 17:02:43 -07:00
Alex Towle
e64e0d7421
@0x:contracts-exchange
Added getOrdersInfo
back into the exchange
2019-08-28 16:42:29 -07:00
Alex Towle
13d5a5e2ec
@0x:contracts-exchange
Added a test to ensure that registerAssetProxy
will fail for non-contract proxies
2019-08-28 16:24:36 -07:00
Alex Towle
df4282fb34
Fixed issues after rebase
2019-08-28 15:50:23 -07:00
Alex Towle
861aebb2e3
@0x:contracts-exchange
Refactored the protocol fee tests and added tests for batchFillOrders
2019-08-28 15:08:40 -07:00
Alex Towle
cc7b8359b4
@0x:contracts-exchange
Added tests for matchOrders protocol fees
2019-08-28 15:05:33 -07:00
Alex Towle
dd0d848530
@0x:contracts-exchange
Added tests for fillOrder protocol fees
2019-08-28 15:05:33 -07:00
Alex Towle
7f17033ce3
@0x:contracts-exchange
Added protocol fees to fillOrders and matchOrders
2019-08-28 15:05:13 -07:00
Alex Towle
bf3751fd9e
@0x:contracts-exchange
Added the MixinProtocolFees contract
2019-08-28 15:03:32 -07:00
Amir Bandeali
5fe231b689
Reorder Cancel event args for consistency
2019-08-28 15:01:30 -07:00
Amir Bandeali
5ee7c2f9dc
Reorder Fill event args to get around stack limit
2019-08-28 15:01:30 -07:00
Alex Towle
2c970a0466
@0x:contracts-exchange
Added protocol fees to fill order
2019-08-28 15:01:30 -07:00
Alex Towle
415af90ae7
@0x:contracts-exchange
Added the MixinStakingManager contract
2019-08-28 14:53:45 -07:00