James Towle
|
f66212ce23
|
Merge pull request #2051 from jalextowle/feature/3.0/exchange-libs/unit-tests
`@0x:contracts-exchange-libs` Added unit tests to exchange-libs
|
2019-08-14 10:52:10 -07:00 |
|
Alex Towle
|
6b4e632101
|
@0x:contracts-exchange Refactored internal.ts so that it is more readable
|
2019-08-14 10:39:36 -07:00 |
|
Alex Towle
|
0134b2874b
|
@0x:contracts-exchange Addressed remaining review comments
|
2019-08-13 17:05:38 -07:00 |
|
Alex Towle
|
e2308aabed
|
@0x:contracts-exchange Reduced the code size of internal.ts
|
2019-08-13 17:04:42 -07:00 |
|
Alex Towle
|
36fac3532c
|
Removed unused reference functions
|
2019-08-13 17:04:42 -07:00 |
|
Alex Towle
|
327c6e8ac2
|
Completed the calculateMatchedFillResultsWithMaximalFill tests
|
2019-08-13 17:04:25 -07:00 |
|
Alex Towle
|
e9d49d96a6
|
Changed the testing style to be more assertion based rather than reference based to leverage the fixtures from the integration tests
|
2019-08-13 17:04:25 -07:00 |
|
Alex Towle
|
929bb86a54
|
Wrote some test cases for assertValidMatch
|
2019-08-13 17:04:25 -07:00 |
|
Alex Towle
|
f58e28d1be
|
Implemented reference functions and added tests for _calculateCompleteRightFill
|
2019-08-13 17:04:25 -07:00 |
|
Alex Towle
|
cdabe21e7a
|
Fixed the tests by using the IsolatedExchange
|
2019-08-13 17:04:25 -07:00 |
|
Alex Towle
|
a7520eeaa8
|
Wrote some initial test cases for the matchOrders calculate functions
|
2019-08-13 17:02:00 -07:00 |
|
Amir Bandeali
|
070147db52
|
Fix build errors
|
2019-08-13 16:43:55 -07:00 |
|
Amir Bandeali
|
55436510b6
|
Regenerate boilerplate for exchange-libs package
|
2019-08-13 16:20:35 -07:00 |
|
Amir Bandeali
|
dc31294440
|
Move LibExchangeRichErrors to exchange-libs package
|
2019-08-13 16:20:35 -07:00 |
|
Amir Bandeali
|
d3b8070fd6
|
Fix TestValidatorWallet by using new LibOrder and LibZeroExTransaction hashing
|
2019-08-13 16:19:48 -07:00 |
|
Amir Bandeali
|
26e4d66163
|
Remove unimplemented functions from interface
|
2019-08-13 16:19:48 -07:00 |
|
Amir Bandeali
|
7cfceebeb8
|
Remove unused ABIEncoderV2 pragma
|
2019-08-13 16:19:48 -07:00 |
|
Amir Bandeali
|
0e2616f16b
|
Rename _rrevert to rrevert
|
2019-08-13 16:19:48 -07:00 |
|
Amir Bandeali
|
ccce7e001e
|
Compile all contracts by default, regenerate boilerplate
|
2019-08-13 16:19:48 -07:00 |
|
Amir Bandeali
|
3afce213c0
|
Add rrevert to safeDiv in LibSafeMath
|
2019-08-13 16:11:57 -07:00 |
|
Amir Bandeali
|
45f229c531
|
Move LibEIP712ExchangeDomain tests to own file
|
2019-08-13 16:11:57 -07:00 |
|
Amir Bandeali
|
d6772b4a0a
|
Fix linting errors
|
2019-08-13 16:11:57 -07:00 |
|
Amir Bandeali
|
5016d50c2b
|
Move calculateFillResults tests to exchange-libs package
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
24eaf93db8
|
Move all exchange-libs tests to separate files
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
2e519b534d
|
Fix build in OrderValidationUtils
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
31c2b36039
|
Fix build errors in exchange package contracts
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
245956c658
|
Create test contracts for each exchange lib
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
0df360c5e8
|
Fix compile errors
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
9b786df828
|
Update test contracts
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
ae859fa01e
|
Update Exchange contract to use libraries
|
2019-08-13 16:11:09 -07:00 |
|
Amir Bandeali
|
7eb64eb3dc
|
Update test contracts
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
f45014f75b
|
Convert LibOrder and LibZeroExTransaction to libraries
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
74a5c8c23c
|
Simplify LibEIP712ExchangeDomain to be used only for generating domain hash
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
28e781db15
|
Convert LibFillResults to library
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
6ca9d4ee78
|
Convert LibMath to library
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
52dcd998c4
|
Add library implementation of SafeMath
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
a8cd168345
|
Cleanup imports
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
b05a2a90d0
|
Move FillResults calculations into LibFillResults
|
2019-08-13 16:09:48 -07:00 |
|
Amir Bandeali
|
242715240b
|
Do not inherit libs
|
2019-08-13 16:07:07 -07:00 |
|
Amir Bandeali
|
65f17fd76e
|
Make LibEIP712 a library
|
2019-08-13 16:04:33 -07:00 |
|
Amir Bandeali
|
58ee4447a1
|
Remove remaining hard coded selectors
|
2019-08-13 16:04:33 -07:00 |
|
Amir Bandeali
|
d153ac0951
|
Make remaining functions public
|
2019-08-13 16:04:33 -07:00 |
|
Amir Bandeali
|
2e97cfa5e5
|
Remove LibAssetProxyIds and TestLibConstants
|
2019-08-13 16:04:33 -07:00 |
|
Amir Bandeali
|
7d5276ad11
|
Remove LibExchangeSelectors.sol
|
2019-08-13 16:04:33 -07:00 |
|
Amir Bandeali
|
2251e5e418
|
Optimize LibEIP712
|
2019-08-13 16:00:19 -07:00 |
|
Alex Towle
|
e4257fb6c7
|
Addressed review comments and prettified code
|
2019-08-13 11:06:41 -07:00 |
|
Greg Hysen
|
dd4541c825
|
Fill Order Assertion Wrapper
|
2019-08-13 17:51:40 +02:00 |
|
Lawrence Forman
|
98f77394ed
|
@0x/contracts-dev-utils: Update OrderValidationUtils for new isValidOrderSignature() semantics.
|
2019-08-12 19:18:57 -04:00 |
|
Lawrence Forman
|
fc18db10be
|
@0x/contracts-exchange: Add tests for when callback signature types return incorrect data.
|
2019-08-12 19:10:24 -04:00 |
|
Lawrence Forman
|
9382e2e8c7
|
@0x/contracts-exchange: Fix bad resultData assertion in fillOrderNoThrow().
|
2019-08-12 18:53:40 -04:00 |
|