Amir Bandeali
7d5a23969d
Add reentrancy tests for fillOrder and wrapper functions
2018-08-24 17:30:56 -07:00
Fabio Berger
7f90f5ecd4
merge v2-prototype
2018-07-18 12:04:57 +02:00
Amir Bandeali
caa5b4e342
Add tests for getOrderInfo and getOrdersInfo
2018-07-17 13:59:14 -07:00
Fabio Berger
f8dbf57582
Rename assetProxyUtils to assetDataUtils
2018-07-17 15:26:55 +02:00
Alex Browne
9828fa335e
Fix bugs having to do with block timestamps and order expirationTimes
2018-07-16 18:41:37 -07:00
Leonid Logvinov
ba9d3cbdb8
Make it possible to configure block polling interval in base contract wrapper
2018-07-05 15:56:31 +02:00
Alex Browne
5b64b3ea93
Improve robustness of revert reason assertions
2018-07-02 18:57:33 -07:00
Amir Bandeali
2fcc36bbad
Update file structure
2018-06-29 18:05:40 -07:00
Amir Bandeali
d4852092b8
Make registerAssetProxy append only
2018-06-29 16:25:16 -07:00
Fabio Berger
646927962a
Reduce the userAddresses to the individual addresses actually used by tests, as well as only deploy the number of ERC20 tokens needed for each test suite
2018-06-28 10:43:37 +02:00
Fabio Berger
43ae868c69
Merge branch 'refactor/check-revert-reasons' into feature/combinatorial-testing
...
* refactor/check-revert-reasons:
Temporarily switch revert reasons to `TransferFailed`. Should be `InvalidAmount` but because of an oversight in the assembly implementation of `dispatchTransferFrom`, it always throws `TransferFailed`
Expect RevertReason be passed in, not string
Rename RevertReasons to RevertReason since singular enum names are more common
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
# packages/contracts/test/exchange/core.ts
2018-06-26 18:53:44 +02:00
Fabio Berger
9219f9d8ae
Merge branch 'v2-prototype' into feature/combinatorial-testing
...
* v2-prototype: (21 commits)
Don't use variables for revert reasons
Add comments to dispatchTransferFrom
Document IAssetData
Compute bytes4 proxyid constants
Return inplace bytes in LibBytes.readBytesWithLength
Add Greg's documentation to MixinErc721Transfer
Add Greg's documentation to MixinErc20Transfer
Gas golf the transfer success logic
Optimize like in PR #767
Run prettier and fix linting errors
Fix tests
Update tests
Fix AssetProxyUtils
Update tests
Fix ERC721Proxy TokenId
Update AssetProxyUtils
Add IAssetData
WIP
ABI encoded asset data
Remove proxyId argument from dispatchTransferFrom
...
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
2018-06-26 08:13:59 +02:00
Fabio Berger
27670f4da6
Rename RevertReasons to RevertReason since singular enum names are more common
2018-06-26 08:11:14 +02:00
Fabio Berger
e051743a3d
Merge branch 'v2-prototype' into refactor/check-revert-reasons
...
* v2-prototype: (21 commits)
Don't use variables for revert reasons
Add comments to dispatchTransferFrom
Document IAssetData
Compute bytes4 proxyid constants
Return inplace bytes in LibBytes.readBytesWithLength
Add Greg's documentation to MixinErc721Transfer
Add Greg's documentation to MixinErc20Transfer
Gas golf the transfer success logic
Optimize like in PR #767
Run prettier and fix linting errors
Fix tests
Update tests
Fix AssetProxyUtils
Update tests
Fix ERC721Proxy TokenId
Update AssetProxyUtils
Add IAssetData
WIP
ABI encoded asset data
Remove proxyId argument from dispatchTransferFrom
...
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
2018-06-26 08:07:37 +02:00
Amir Bandeali
7ce0f9682f
Fix tests
2018-06-25 16:19:07 -07:00
Fabio Berger
1353723b58
merge check-revert-reasons
2018-06-25 13:02:38 +02:00
Fabio Berger
f811c07454
Move RevertReasons to @0xproject/types package
2018-06-25 12:59:26 +02:00
Fabio Berger
c50da5d034
merge check-revert-reasons
2018-06-25 12:32:16 +02:00
Fabio Berger
9b196ba68c
Merge branch 'v2-prototype' into feature/combinatorial-testing
...
* v2-prototype: (97 commits)
Fix typos in comments
Add modifier and tests for removeAuthorizedAddressAtIndex
Update and add tests
Change removeAuthorizedAddress => removeAuthorizedAddressAtIndex
Move isFunctionRemoveAuthorizedAddress to test
Fix usage of `popLastByte`
Fix LibBytes is a library
Remove `areBytesEqual`
Fix usage of `contentAddress()`
Clean low bits in bytes4
Clean high bits in address
Refactor LibBytes.readBytes4 for consistency
Fix LibBytes.equals
Add trailing garbage testcase for LibBytes.equals
Rename bytes.equals
Add slice and sliceDestructive
Rename bytes.rawAddress and add bytes.contentAddress
Rename read/writeBytesWithLength
Using LibBytes for bytes
Make LibBytes a library
...
# Conflicts:
# packages/contracts/src/utils/constants.ts
# packages/contracts/test/exchange/core.ts
2018-06-25 11:49:14 +02:00
Fabio Berger
2f6f815d81
Fix tslint
2018-06-22 18:54:18 +02:00
Fabio Berger
1e03fbe1a8
Fix prettier
2018-06-22 18:50:02 +02:00
Fabio Berger
4409f11b24
Rename ContractLibErrors to RevertReasons
2018-06-22 18:45:45 +02:00
Fabio Berger
4c14372b4a
Add revert reason checks to wrapper tests
2018-06-22 17:12:52 +02:00
Alex Browne
4012e31115
Use make-promises-safe as a preloader instead of manually importing
2018-06-21 19:17:33 -07:00
Fabio Berger
9acf4458c0
Remove hack in ERC20Wrapper
2018-06-19 17:38:15 +02:00
Fabio Berger
eea86757d5
- Refactor assetWrapper to contain more of the normalizing logic instead of erc20Wrapper and erc721Wrapper
...
- Add burn method to DummyERC721Token
- Add additional methods to assetWrapper to set balance/allowances on ERC20 and ERC721 tokens
- Use approve instead of approveAll for ERC721 tokens
2018-06-15 00:00:02 +02:00
Amir Bandeali
3a5f3e8b55
Unpop byte rather than making deep copy
2018-06-12 11:45:02 -07:00
Amir Bandeali
5910bec52e
Make ZRX_PROXY_ID constant rather than popping it from ZRX_ASSET_DATA
2018-06-12 11:45:02 -07:00
Amir Bandeali
ee8c9b764d
Pop id from assetData before dispatching to AssetProxies
2018-06-12 11:45:02 -07:00
Greg Hysen
e042e0ad32
Converged on naming scheme for asset data: renamed all instances of assetMetadata, proxyData, proxyMetadata to assetData
2018-06-07 15:38:48 -07:00
Fabio Berger
bd3b652cfc
Fixed path
2018-06-07 13:15:13 +02:00
Fabio Berger
73429fc720
merge v2-prototype
2018-06-07 12:27:03 +02:00
fragosti
e0d5b9daf8
Merge branch 'v2-prototype' of https://github.com/0xProject/0x-monorepo into feature/improve-linting
2018-06-06 16:36:11 -07:00
Alex Browne
dd8727d3ae
Apply various fixes based on PR feedback
2018-06-06 12:41:15 -07:00
Alex Browne
167a38e27d
Add Async suffix to relevant assertions
2018-06-06 12:41:14 -07:00
Alex Browne
36b01fbdcf
Add additional gas to calls to fillOrderNoThrow
2018-06-06 12:40:31 -07:00
Alex Browne
577a8dd005
Fix some more test cases, especially those that call increaseTime
2018-06-06 12:40:30 -07:00
Alex Browne
00bf957b53
Add more transactions to Geth on init. Skip tests that are failing.
2018-06-06 12:39:43 -07:00
Alex Browne
1cc9d9c071
Replace constant.REVERT test assertions with expectRevertOrAlwaysFailingTransaction
2018-06-06 12:39:42 -07:00
Fabio Berger
cb754ee125
move generated contract wrappers from contract_wrappers/generated/
to generated_contract_wrappers
in package with no non-generated contract wrappers
2018-06-06 15:39:38 +02:00
fragosti
59cb2132f2
Linter now passes
2018-06-05 11:46:05 -07:00
Amir Bandeali
342432dc76
Update Exchange statuses, revert instead of emmitting event on fill/cancel failures, and remove redundant logic in matchOrders
2018-06-04 15:55:28 -07:00
Fabio Berger
324fab8186
Fix tslint issues
2018-06-01 14:12:18 -07:00
Fabio Berger
4874d55d03
Initial refactor of order-utils. Move many utils from contracts into this package.
2018-05-29 16:58:30 -07:00
Leonid Logvinov
92b0efff5a
Migrate migrations to v2
2018-05-24 13:59:30 -07:00
Alex Browne
b05a3b7aed
Check transaction receipt status codes where applicable
2018-05-23 15:09:17 -07:00
Fabio Berger
9de9bf651b
Fix ExchangeWrapper
2018-05-22 13:15:01 -07:00
Fabio Berger
2b793f372a
Merge branch 'v2-prototype' into refactor/contracts/remove0xjsDep
...
* v2-prototype:
Fix tslint issues
Add `are` to boolean naming conventions
Fix tslint
Fix the tsutils version, fixing ts typings issue
Rename some variables in multi_sig_with_time_lock.ts
Remove extra awaitTransactionMinedAsync calls
Update artifacts
Update yarn.lock
Fix warnings in Metacoin
Upgrade UglifyJS to include ES6 support
Add CancelOrder and MatchOrder types
Add missing return types
Ignore classnames linter rule
Apply changes to test/exchange/match_orders.ts
Fix some unhandled promise rejections
Add awaitTransactionMinedAsync after every sent transaction
Add missing blockchainLifecycle calls to contracts tests
# Conflicts:
# packages/contracts/src/utils/exchange_wrapper.ts
# packages/contracts/test/asset_proxy/proxies.ts
# packages/contracts/test/exchange/dispatcher.ts
# packages/contracts/test/multi_sig_with_time_lock.ts
2018-05-22 13:02:21 -07:00
Fabio Berger
a682b5d90e
Remove 0x.js dep from contracts
2018-05-22 11:18:50 -07:00
Alex Browne
2c496a92ad
Add awaitTransactionMinedAsync after every sent transaction
2018-05-21 16:52:49 -07:00