Amir Bandeali
64c596c922
temp
2019-07-23 15:23:40 -07:00
Amir Bandeali
051997acb0
Fix linting errors
2019-07-23 15:23:40 -07:00
Amir Bandeali
51ef0e1e6d
Add tests for cancelOrderNoThrow and batchCancelOrdersNoThrow
2019-07-23 15:23:40 -07:00
Amir Bandeali
ed0fcf2829
Remove LibAbiEncoder
2019-07-23 15:23:40 -07:00
Amir Bandeali
2ce94b73ad
Use build in abi.encode instead of LibAbiEncoder for fillOrderNoThrow
2019-07-23 15:23:40 -07:00
Amir Bandeali
ef96bff6ec
Add cancelOrderNoThrow and batchCancelOrdersNoThrow
2019-07-23 15:23:40 -07:00
Greg Hysen
afc888f2ef
Updated compiler.json for erc1155 and staking packages, plus removed unnecessary dependencies for staking
2019-07-23 15:23:40 -07:00
Greg Hysen
e823c2af9d
Created boilerplate staking package for stake-based liquidity incentives
2019-07-23 15:23:40 -07:00
Amir Bandeali
18979f3f30
Fix linting error
2019-07-23 15:21:14 -07:00
Amir Bandeali
8bd29596c4
Rename remaining inconsistencies
2019-07-23 15:21:14 -07:00
Lawrence Forman
0cfcb6aa37
Apply suggestions from code review
...
Co-Authored-By: abandeali1 <abandeali1@gmail.com>
2019-07-23 15:21:14 -07:00
Amir Bandeali
6b40812e6d
Fix incorrect CancelUpTo event args
2019-07-23 15:21:14 -07:00
Amir Bandeali
8af253e9ab
Remove accidental recursive function call in TestLibs contract
2019-07-23 15:21:14 -07:00
Amir Bandeali
6763bce627
Add _ to remaining internal/private functions
2019-07-23 15:21:14 -07:00
Amir Bandeali
3217c1e11f
Remove unused SafeMath functions
2019-07-23 15:21:14 -07:00
Amir Bandeali
6ce3e18831
Remove deprecated error libs
2019-07-23 15:21:14 -07:00
Amir Bandeali
3e461ac2e5
Rename internal and private functions
2019-07-23 15:21:14 -07:00
Lawrence Forman
46af2ffcea
In @0x/contracts-exchange
: Merge new transaction tests from rebase.
2019-07-23 15:21:14 -07:00
Lawrence Forman
e5b3a82112
In @0x/contracts-utils
and @0x/contracts-exchange
: Hardcode rich revert selector constants.
2019-07-23 15:21:14 -07:00
Lawrence Forman
9af51aaca1
Add PRs to changelogs.
2019-07-23 15:21:14 -07:00
Lawrence Forman
3bacf09710
Update changelogs
2019-07-23 15:21:14 -07:00
Lawrence Forman
61bdbd2d74
Rebased against 3.0
.
...
Run prettier/linter.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a1293f160f
In @0x/contracts-exchange
: Remove only
from lib_exchange_rich_error_decoder
tests.
2019-07-23 15:21:14 -07:00
Lawrence Forman
847503bff1
In @0x/contracts-exchange
: Add more tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
576242551f
In @0x/contracts-exchange
: Add more tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdb6bee65f
In @0x/contracts-exchange
: Add tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a2846faa61
Move @0x/rich-reverts-decoder
into @0x/contracts-exchange/contracts/src/libs/LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a32544b53a
In @0x/contracts-rich-reverts-decoder
: Add more decoders.
2019-07-23 15:21:14 -07:00
Lawrence Forman
9b093dab0a
In @0x/contracts-rich-reverts
: Move to a single contract file. Inherit from @0x/contracts-exchange/.../MExchangeRichErrorTypes.sol
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
e24b8947e0
In @0x/contracts-exchange
: Pull types and constants from MExchangeRichErrors
into MExchangeRichErrorTypes
.
...
In `@0x/contracts-utils`: Pull types and constants from `MRichErrors` into `MRichErrorTypes`.
2019-07-23 15:21:14 -07:00
Lawrence Forman
7835c6e20c
Create @0x/contracts-rich-reverts-decoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
d942c47f08
In @0x/contracts-exchange
: Change parameter order and naming of some rich revert errors.
...
In `@0x/order-utils`: Change parameter order for `OrderStatusError`.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdaee1375c
In @0x/contracts-exchange
: Update tests for rich reverts
2019-07-23 15:21:14 -07:00
Lawrence Forman
d25a510291
In @0x/contracts-exchange
: upgrading tests...
2019-07-23 15:21:14 -07:00
Amir Bandeali
e42a0979bc
Add return natspec to all MixinTransaction functions
2019-07-23 15:21:14 -07:00
Amir Bandeali
f1a78682aa
Add batch fill method tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
dc4bfde76d
Fix linting errors
2019-07-23 15:21:14 -07:00
Amir Bandeali
e717625f86
Add batchExecuteTransactions tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
41444e7ede
Refactor transaction tests to iclude more combinations and to cover all revert cases
2019-07-23 15:21:14 -07:00
Amir Bandeali
ac9247195b
Don't use exchangeDataEncoder as default for functions that don't involve orders
2019-07-23 15:21:14 -07:00
Amir Bandeali
fc2a59ceaa
Update imports in tests
2019-07-23 15:21:13 -07:00
Amir Bandeali
72f4b216c1
Move exchange specific types. constants, and utils into exchange package
2019-07-23 15:21:13 -07:00
Amir Bandeali
d373f5488a
Add functions with mutex to ReentrantERC20Token and update IExchange with missing function
2019-07-23 15:19:33 -07:00
Amir Bandeali
24906138c7
Make preSign compatible with executeTransaction
2019-07-23 15:19:33 -07:00
Amir Bandeali
f4b3b69b2f
Move constants and exchangeDataEncoder into test-utils package
2019-07-23 15:19:33 -07:00
Amir Bandeali
e80abad19a
Add batchExecuteTransaction
2019-07-23 15:18:26 -07:00
Amir Bandeali
c9c228ffdd
Add return data to executeTransaction
2019-07-23 15:18:26 -07:00
Amir Bandeali
6fc30d31bf
Fix missed conflicts and rebuild
2019-07-23 15:18:26 -07:00
Lawrence Forman
0bcd47b394
Add OrderValidator and WalletOrderValidator signature strategies to Exchange ( #1774 )
...
* In `@0x/contracts-exchange`: Add `SignatureType.OrderValidator` support to contracts and refactor signature validation functions.
* In `@0x/types`: Add `SignatureType.OrderValidator` and `RevertReason.InappropriateSignature`.
* In `@0x/contracts-exchange`: Fix contracts and update tests for `SignatureType.OrderValidator`.
* Ran prettier/linter
* Update changelogs
* In `@0x/order-utils`: Add `SignatureOrderValidatorError` to `ExchangeRevertErrors`.
* In `@0x/contracts-exchange`: Add `SignatureOrderValidatorError` rich revert. Fix rebase issues. Rename `IValidator.isValidOrder` to `IValidator.isValidOrderSignature`.
* In `@0x/contracts-exchange`: Add revert test cases for `OrderValidator` signature type.
* In `@0x/order-utils`: Update changelog.
* In `@0x/contracts-exchange`: Split off `SignatureType.OrderValidator` scheme into its own interface and registry.
* In `@0x/types`: Add `SignatureType.WalletOrderValidator`.
* In `@0x/order-utils`: Add `SignatureWalletOrderValidatorError`.
* In `@0x/contracts-exchange`: Add `SignatureType.WalletOrderValidator` support.
* Ran prettier
* In `@0x/types`: Remove `RevertReason.WalletOrderValidator`.
* Update/fix changelogs in `@0x/contracts-exchange`, `@0x/order-utils`, and `@0x/types`.
* In `@0x/contracts-exchange`: Make `isValidOrderSignature` `external` instead of `public`.
* In `@0x/contracts-exchange`: Change `isValidOrderSignature` back to `public` because passing `calldata` to internal functions isn't supported.
2019-07-23 15:18:26 -07:00
Lawrence Forman
c24bb139dd
In @0x/contracts-exchange
: Change validator/wallet return value test to == 1
instead of != 0
.
2019-07-23 15:17:57 -07:00