Fabio Berger
6a2421c683
Fix tests
2018-06-26 23:17:29 +02:00
Amir Bandeali
b6d8dcb6e1
Make dispatchTransferFrom revert with reason from AssetProxy on failure
2018-06-26 13:57:55 -07:00
Amir Bandeali
08ee1ab2e6
Remove redundant files, hard code function selector in dispatchTransferFrom, and modify revert reason
2018-06-26 13:57:51 -07:00
Greg Hysen
873ec898d8
Updated offset of receiverData length to reflect new assetData encoding.
2018-06-26 12:23:19 -07:00
Remco Bloemen
97a70d14a3
ERC20 Custom storage layout
2018-06-26 12:23:19 -07:00
Remco Bloemen
394fbebfa8
Golf the authorization check
2018-06-26 12:23:19 -07:00
Remco Bloemen
b79588c4a0
ERC20 manual memory layout
2018-06-26 12:23:19 -07:00
Remco Bloemen
3b46e82625
ERC20 inline return
2018-06-26 12:23:19 -07:00
Remco Bloemen
dbaf1fcd43
ERC721 inline return
2018-06-26 12:23:19 -07:00
Remco Bloemen
4caf1271e4
Golf ERC721 transferFrom
2018-06-26 12:23:19 -07:00
Remco Bloemen
6921943aff
Inline ERC20 tranferFrom selector constant
2018-06-26 12:23:19 -07:00
Remco Bloemen
3ce90b8257
Optimize ERC20 transferFrom
2018-06-26 12:23:19 -07:00
Fabio Berger
2a82807be4
Fix type issue
2018-06-26 19:16:57 +02:00
Fabio Berger
43ae868c69
Merge branch 'refactor/check-revert-reasons' into feature/combinatorial-testing
...
* refactor/check-revert-reasons:
Temporarily switch revert reasons to `TransferFailed`. Should be `InvalidAmount` but because of an oversight in the assembly implementation of `dispatchTransferFrom`, it always throws `TransferFailed`
Expect RevertReason be passed in, not string
Rename RevertReasons to RevertReason since singular enum names are more common
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
# packages/contracts/test/exchange/core.ts
2018-06-26 18:53:44 +02:00
Fabio Berger
1bc742aed1
Temporarily switch revert reasons to TransferFailed. Should be InvalidAmount but because of an oversight in the assembly implementation of dispatchTransferFrom, it always throws TransferFailed
2018-06-26 18:49:10 +02:00
Fabio Berger
6dc852774e
Update AbstractAssetWrapper
2018-06-26 08:52:25 +02:00
Fabio Berger
7967ebed57
Rename to singular
2018-06-26 08:51:40 +02:00
Fabio Berger
105b927397
Fix merge issues
2018-06-26 08:43:37 +02:00
Fabio Berger
9219f9d8ae
Merge branch 'v2-prototype' into feature/combinatorial-testing
...
* v2-prototype: (21 commits)
Don't use variables for revert reasons
Add comments to dispatchTransferFrom
Document IAssetData
Compute bytes4 proxyid constants
Return inplace bytes in LibBytes.readBytesWithLength
Add Greg's documentation to MixinErc721Transfer
Add Greg's documentation to MixinErc20Transfer
Gas golf the transfer success logic
Optimize like in PR #767
Run prettier and fix linting errors
Fix tests
Update tests
Fix AssetProxyUtils
Update tests
Fix ERC721Proxy TokenId
Update AssetProxyUtils
Add IAssetData
WIP
ABI encoded asset data
Remove proxyId argument from dispatchTransferFrom
...
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
2018-06-26 08:13:59 +02:00
Fabio Berger
f780e6f235
Expect RevertReason be passed in, not string
2018-06-26 08:11:32 +02:00
Fabio Berger
27670f4da6
Rename RevertReasons to RevertReason since singular enum names are more common
2018-06-26 08:11:14 +02:00
Fabio Berger
e051743a3d
Merge branch 'v2-prototype' into refactor/check-revert-reasons
...
* v2-prototype: (21 commits)
Don't use variables for revert reasons
Add comments to dispatchTransferFrom
Document IAssetData
Compute bytes4 proxyid constants
Return inplace bytes in LibBytes.readBytesWithLength
Add Greg's documentation to MixinErc721Transfer
Add Greg's documentation to MixinErc20Transfer
Gas golf the transfer success logic
Optimize like in PR #767
Run prettier and fix linting errors
Fix tests
Update tests
Fix AssetProxyUtils
Update tests
Fix ERC721Proxy TokenId
Update AssetProxyUtils
Add IAssetData
WIP
ABI encoded asset data
Remove proxyId argument from dispatchTransferFrom
...
# Conflicts:
# packages/contracts/test/asset_proxy/proxies.ts
2018-06-26 08:07:37 +02:00
Fabio Berger
fb03003b3a
Fix inconsistency between contract and reference implementation of order validation logic
2018-06-26 07:50:24 +02:00
Amir Bandeali
a89908540f
Don't use variables for revert reasons
2018-06-25 16:34:06 -07:00
Amir Bandeali
0163984ea4
Add comments to dispatchTransferFrom
2018-06-25 16:19:08 -07:00
Remco Bloemen
db3ce08cab
Document IAssetData
2018-06-25 16:19:08 -07:00
Remco Bloemen
1076959006
Compute bytes4 proxyid constants
2018-06-25 16:19:08 -07:00
Remco Bloemen
5127cbb22c
Return inplace bytes in LibBytes.readBytesWithLength
2018-06-25 16:19:08 -07:00
Remco Bloemen
9175b43542
Add Greg's documentation to MixinErc721Transfer
2018-06-25 16:19:07 -07:00
Remco Bloemen
562fec01d8
Add Greg's documentation to MixinErc20Transfer
2018-06-25 16:19:07 -07:00
Remco Bloemen
b8051c8fed
Gas golf the transfer success logic
2018-06-25 16:19:07 -07:00
Remco Bloemen
4df66a4802
Optimize like in PR #767
2018-06-25 16:19:07 -07:00
Amir Bandeali
a2ff63daa5
Run prettier and fix linting errors
2018-06-25 16:19:07 -07:00
Amir Bandeali
7ce0f9682f
Fix tests
2018-06-25 16:19:07 -07:00
Remco Bloemen
3c6d0dc3e0
Update tests
2018-06-25 16:19:07 -07:00
Remco Bloemen
07734a5184
Update tests
2018-06-25 16:19:07 -07:00
Remco Bloemen
32d4994219
Fix ERC721Proxy TokenId
2018-06-25 16:19:07 -07:00
Remco Bloemen
b7b0185baf
Add IAssetData
2018-06-25 16:19:07 -07:00
Remco Bloemen
7b0c13c121
WIP
2018-06-25 16:19:07 -07:00
Remco Bloemen
a98ecc05af
ABI encoded asset data
2018-06-25 16:19:07 -07:00
Remco Bloemen
f7337c1a05
Remove proxyId argument from dispatchTransferFrom
2018-06-25 16:19:07 -07:00
Fabio Berger
8064914bb7
Prettier fixes
2018-06-25 23:17:56 +02:00
Fabio Berger
1134ff1075
Fix tslint issues
2018-06-25 20:17:00 +02:00
Greg Hysen
94740155e5
Comments for ASM hashing
2018-06-25 11:02:31 -07:00
Fabio Berger
ec9d1ca57e
Document all the contract test options in README
2018-06-25 15:18:02 +02:00
Fabio Berger
ad67a6add5
Check revert reasons in declarative and combinatorial tests
2018-06-25 13:51:00 +02:00
Fabio Berger
1353723b58
merge check-revert-reasons
2018-06-25 13:02:38 +02:00
Fabio Berger
f811c07454
Move RevertReasons to @0xproject/types package
2018-06-25 12:59:26 +02:00
Fabio Berger
bb85382824
Add missing import
2018-06-25 12:47:44 +02:00
Fabio Berger
3ed4a1ba20
Add missing import
2018-06-25 12:47:13 +02:00
