Amir Bandeali
798fb183a5
Address remaining PR feedback
2019-08-23 15:14:04 -07:00
Amir Bandeali
8f8c16bd0e
Add more recursion tests
2019-08-23 09:25:09 -07:00
Amir Bandeali
5e51233b49
Address PR feedback
2019-08-22 17:11:50 -07:00
Amir Bandeali
890bfd18fa
Update tests to use new TransactionInvalidContextError
2019-08-22 17:04:15 -07:00
Amir Bandeali
edb923b8bb
Use TransactionInvalidContextError in _assertExecutableTransaction
2019-08-22 17:04:15 -07:00
Amir Bandeali
7b96fa8d76
Add more unit tests
2019-08-22 17:04:15 -07:00
Amir Bandeali
ca35eed955
Add _assertExecutableTransaction unit tests
2019-08-22 17:04:15 -07:00
Amir Bandeali
eb6637afd5
Add public version of _assertExecutableTransaction
2019-08-22 17:04:15 -07:00
Amir Bandeali
a114bbb30e
Reduce code duplication in unit tests
2019-08-22 17:04:15 -07:00
Amir Bandeali
9d38bf731f
Add transaction gasPrice tests
2019-08-22 17:04:15 -07:00
Amir Bandeali
27e2a76110
Update remaining contracts to use new transaction schema
2019-08-22 17:04:14 -07:00
Amir Bandeali
47da97137f
Add _assertExecutableTransaction function and add gasPrice check
2019-08-22 17:04:14 -07:00
Alex Towle
cd147dbc41
@0x:contracts-exchange
Fixed issues caused by rebase
2019-08-22 17:01:49 -07:00
Alex Towle
0253bba83b
@0x:contracts-exchange
Addressed review comments by completely overhauling transaction_unit_tests.ts
2019-08-22 17:01:49 -07:00
Alex Towle
d845b318b9
@0x:contracts-exchange
Changed the signature validation stub function to not require state
2019-08-22 17:01:49 -07:00
Alex Towle
4b970905cf
@0x:contracts-exchange
Removed code written to transactions
2019-08-22 17:01:49 -07:00
Alex Towle
907771f084
@0x:contracts-exchange
Added unit tests for batchExecuteTransactions
2019-08-22 17:01:49 -07:00
Alex Towle
1724ecd4c3
@0x:contracts-exchange
Added unit tests for executeTransaction
2019-08-22 17:01:48 -07:00
Alex Towle
74b9ad5536
@0x:contracts-exchange
Added unit tests for getCurrentContextAddress
2019-08-22 17:01:48 -07:00
mzhu25
453bf4d195
Merge pull request #2087 from 0xProject/fix/3.0/exchange/execute-noop-transfer
...
remove from != to check and update tests
2019-08-21 17:02:03 -07:00
Michael Zhu
00e87864b1
remove from != to check and update tests
2019-08-21 13:07:59 -07:00
Lawrence Forman
e9a4b0758b
@0x/contracts-exchange
: Remove log decoding in ExchangeWrapper
test class in favor of awaitTransactionSuccessAsync
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
abf076fc05
@0x/contracts-exchange
: Remove unused _getOrderHashes()
function from MixinWrapperFUnctions
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
a497ddfad2
@0x/contracts-exchange
: Update CHANGELOG and run prettier.
2019-08-21 10:59:34 -04:00
Lawrence Forman
e4475c08e8
@0x/contracts-exchange
: Switch to consolidated IncompleteFillError
rich error.
...
`@0x/contracts-exchange`: Allow `marketSell/BuyOrdersNoThrow` to be destructive to orders again.
2019-08-21 10:59:34 -04:00
Lawrence Forman
edef3bc30e
@0x/contracts-exchange
: Fix failing wrapper.ts
test.
2019-08-21 10:59:34 -04:00
Lawrence Forman
0c7f09b832
ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
34d075ce8c
@0x/contracts-exchange
: Update marketBuy/SellOrdersNoThrow()
to NOT be destructive to the orders.
...
`@0x/contracts-exchange`: Fix wrapper unit tests to use the actual order hash algorithm, since it can't be overridden anymore.
2019-08-21 10:59:34 -04:00
Lawrence Forman
8c06d660ea
Update CHANGELOGs with PR numbers.
2019-08-21 10:59:34 -04:00
Lawrence Forman
748566b4fb
@0x/contracts-exchange
: Tweak exchangeDataEncoder
test utility to work with marketBuy/SellFillOrKill()
functions.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fb38867e78
Ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
a2613625c6
@0x/contracts-exchange
: Squelch linter errors in LibExchangeRichErrorDecoder
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fd2a240c9f
@0x/contracts-exchange`: Update changelog.
2019-08-21 10:59:34 -04:00
Lawrence Forman
96bef08ac2
@0x/contracts-exchange
: Rename marketSellOrders
and marketBuyOrders
back to marketSellOrdersNoThrow
and marketBuyOrdersNoThrow
.
...
`@0x/contracts-exchange`: Introduce new `marketSellOrdersFillOrKill` and `marketBuyOrdersFillOrKill` functions.
`@0x/contracts-exchange`: Add new rich error types: `IncompleteMarketBuyError` and `IncompleteMarketSellError`.
`@0x/contracts-exchange`: Use `abi.decode()` in `LibExchangeRichErrorDecoder` over `LibBytes`.
2019-08-21 10:59:34 -04:00
Lawrence Forman
1698519a6a
@0x/contracts-exchange
: Overridden functions in ReentrancyTester
now return sane values.
2019-08-21 10:59:34 -04:00
Amir Bandeali
f09cadb7b3
Add truffle compile option to contract packages
2019-08-20 12:49:33 -07:00
Amir Bandeali
c366a4bd83
Update copyright dates
2019-08-20 12:49:01 -07:00
Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Amir Bandeali
4c78b7d4bb
Merge pull request #2055 from 0xProject/feat/3.0/optimizeConstants
...
Refactor library usage
2019-08-16 07:40:54 -07:00
Amir Bandeali
8402d211bf
Update CHANGELOGs
2019-08-15 16:51:50 -07:00
Amir Bandeali
7ac30c5153
Merge branch '3.0' into feat/3.0/optimizeConstants
2019-08-15 15:20:48 -07:00
Greg Hysz
64bc99101c
Merge pull request #2059 from 0xProject/feature/contracts/3.0/fillOrderAssertionWrapper
...
Fill Order Assertion Wrapper
2019-08-15 00:12:40 +02:00
Greg Hysen
09b5018e65
Readability improvements
2019-08-14 23:45:07 +02:00
Amir Bandeali
1dae1d244c
Rename hashing functions in LibOrder and LibZeroExTransaction
2019-08-14 13:38:12 -07:00
Alex Towle
6b4e632101
@0x:contracts-exchange
Refactored internal.ts so that it is more readable
2019-08-14 10:39:36 -07:00
Alex Towle
0134b2874b
@0x:contracts-exchange
Addressed remaining review comments
2019-08-13 17:05:38 -07:00
Alex Towle
e2308aabed
@0x:contracts-exchange
Reduced the code size of internal.ts
2019-08-13 17:04:42 -07:00
Alex Towle
36fac3532c
Removed unused reference functions
2019-08-13 17:04:42 -07:00
Alex Towle
327c6e8ac2
Completed the calculateMatchedFillResultsWithMaximalFill tests
2019-08-13 17:04:25 -07:00
Alex Towle
e9d49d96a6
Changed the testing style to be more assertion based rather than reference based to leverage the fixtures from the integration tests
2019-08-13 17:04:25 -07:00