Alex Towle
0253bba83b
@0x:contracts-exchange
Addressed review comments by completely overhauling transaction_unit_tests.ts
2019-08-22 17:01:49 -07:00
Alex Towle
d845b318b9
@0x:contracts-exchange
Changed the signature validation stub function to not require state
2019-08-22 17:01:49 -07:00
Alex Towle
4b970905cf
@0x:contracts-exchange
Removed code written to transactions
2019-08-22 17:01:49 -07:00
Alex Towle
907771f084
@0x:contracts-exchange
Added unit tests for batchExecuteTransactions
2019-08-22 17:01:49 -07:00
Alex Towle
1724ecd4c3
@0x:contracts-exchange
Added unit tests for executeTransaction
2019-08-22 17:01:48 -07:00
Alex Towle
74b9ad5536
@0x:contracts-exchange
Added unit tests for getCurrentContextAddress
2019-08-22 17:01:48 -07:00
mzhu25
453bf4d195
Merge pull request #2087 from 0xProject/fix/3.0/exchange/execute-noop-transfer
...
remove from != to check and update tests
2019-08-21 17:02:03 -07:00
Michael Zhu
00e87864b1
remove from != to check and update tests
2019-08-21 13:07:59 -07:00
Lawrence Forman
e9a4b0758b
@0x/contracts-exchange
: Remove log decoding in ExchangeWrapper
test class in favor of awaitTransactionSuccessAsync
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
a497ddfad2
@0x/contracts-exchange
: Update CHANGELOG and run prettier.
2019-08-21 10:59:34 -04:00
Lawrence Forman
e4475c08e8
@0x/contracts-exchange
: Switch to consolidated IncompleteFillError
rich error.
...
`@0x/contracts-exchange`: Allow `marketSell/BuyOrdersNoThrow` to be destructive to orders again.
2019-08-21 10:59:34 -04:00
Lawrence Forman
edef3bc30e
@0x/contracts-exchange
: Fix failing wrapper.ts
test.
2019-08-21 10:59:34 -04:00
Lawrence Forman
0c7f09b832
ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
34d075ce8c
@0x/contracts-exchange
: Update marketBuy/SellOrdersNoThrow()
to NOT be destructive to the orders.
...
`@0x/contracts-exchange`: Fix wrapper unit tests to use the actual order hash algorithm, since it can't be overridden anymore.
2019-08-21 10:59:34 -04:00
Lawrence Forman
748566b4fb
@0x/contracts-exchange
: Tweak exchangeDataEncoder
test utility to work with marketBuy/SellFillOrKill()
functions.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fb38867e78
Ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
96bef08ac2
@0x/contracts-exchange
: Rename marketSellOrders
and marketBuyOrders
back to marketSellOrdersNoThrow
and marketBuyOrdersNoThrow
.
...
`@0x/contracts-exchange`: Introduce new `marketSellOrdersFillOrKill` and `marketBuyOrdersFillOrKill` functions.
`@0x/contracts-exchange`: Add new rich error types: `IncompleteMarketBuyError` and `IncompleteMarketSellError`.
`@0x/contracts-exchange`: Use `abi.decode()` in `LibExchangeRichErrorDecoder` over `LibBytes`.
2019-08-21 10:59:34 -04:00
Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Amir Bandeali
4c78b7d4bb
Merge pull request #2055 from 0xProject/feat/3.0/optimizeConstants
...
Refactor library usage
2019-08-16 07:40:54 -07:00
Amir Bandeali
7ac30c5153
Merge branch '3.0' into feat/3.0/optimizeConstants
2019-08-15 15:20:48 -07:00
Greg Hysz
64bc99101c
Merge pull request #2059 from 0xProject/feature/contracts/3.0/fillOrderAssertionWrapper
...
Fill Order Assertion Wrapper
2019-08-15 00:12:40 +02:00
Greg Hysen
09b5018e65
Readability improvements
2019-08-14 23:45:07 +02:00
Alex Towle
6b4e632101
@0x:contracts-exchange
Refactored internal.ts so that it is more readable
2019-08-14 10:39:36 -07:00
Alex Towle
0134b2874b
@0x:contracts-exchange
Addressed remaining review comments
2019-08-13 17:05:38 -07:00
Alex Towle
e2308aabed
@0x:contracts-exchange
Reduced the code size of internal.ts
2019-08-13 17:04:42 -07:00
Alex Towle
327c6e8ac2
Completed the calculateMatchedFillResultsWithMaximalFill tests
2019-08-13 17:04:25 -07:00
Alex Towle
e9d49d96a6
Changed the testing style to be more assertion based rather than reference based to leverage the fixtures from the integration tests
2019-08-13 17:04:25 -07:00
Alex Towle
929bb86a54
Wrote some test cases for assertValidMatch
2019-08-13 17:04:25 -07:00
Alex Towle
f58e28d1be
Implemented reference functions and added tests for _calculateCompleteRightFill
2019-08-13 17:04:25 -07:00
Alex Towle
cdabe21e7a
Fixed the tests by using the IsolatedExchange
2019-08-13 17:04:25 -07:00
Alex Towle
a7520eeaa8
Wrote some initial test cases for the matchOrders calculate functions
2019-08-13 17:02:00 -07:00
Amir Bandeali
d6772b4a0a
Fix linting errors
2019-08-13 16:11:57 -07:00
Amir Bandeali
5016d50c2b
Move calculateFillResults tests to exchange-libs package
2019-08-13 16:11:09 -07:00
Amir Bandeali
7d5276ad11
Remove LibExchangeSelectors.sol
2019-08-13 16:04:33 -07:00
Greg Hysen
dd4541c825
Fill Order Assertion Wrapper
2019-08-13 17:51:40 +02:00
Lawrence Forman
fc18db10be
@0x/contracts-exchange
: Add tests for when callback signature types return incorrect data.
2019-08-12 19:10:24 -04:00
Lawrence Forman
6df190edbb
@0x/contracts-exchange
: Light changes to address PR comments.
2019-08-12 18:20:50 -04:00
Lawrence Forman
5b0b8a9717
@0x/contracts-exchange
: Remove explicit signerAddress
parameter from many MixinSignatureValidator
functions.
2019-08-12 18:10:57 -04:00
Lawrence Forman
370df0d495
@0x/contracts-dev-utils
: Prettier.
...
`@0x/contracts-exchange`: Update reentrancy tests.
`@0x/contracts-exchange`: Add all mutator functions to
`ExchangeFunctions` type.
`@0x/contracts-tes-utils`: Remove unused import.
2019-08-09 22:15:33 -04:00
Lawrence Forman
d4e300d0a4
@0x/contracts-dev-util
: Remove references to marketXOrdersNoThrow
.
...
`@0x/contracts-exchange`: Remove references to `marketXOrdersNoThrow`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c83864af9c
@0x/contracts-exchange
: Fix broken tests.
...
`@0x/contracts-test-utils`: Remove unecessary wait timeout in
`LogDecoder`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
a2234b745c
@0x/contracts-exchange
: Create semi-automated reentrancy testing.
...
`@0x/contracts-exchange`: Remove old reentrancy tests.
`@0x/contracts-exchange`: Remove `ReentrantERC20Token` contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
3dd8dac146
@0x/contracts-exchange
: Update Wallet
signature type behavior to match v2.1.
...
`@0x/contracts-exchange`: Add EOA tests to `signature_validator`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
0d05411cd2
@0x/contracts-exchange
: Update CHANGELOG, lint, prettify.
2019-08-09 22:15:33 -04:00
Lawrence Forman
7ce65e3cfe
@0x/contracts-exchange
: Wrap up tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ea1501abd1
@0x/contracts-exchange
: Change how order hashes and signatures are computed for wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ca28b8f93e
@0x/contracts-exchange
: Make marketBuy/SellNoThrow
the default.
...
`@0x/contracts-exchange`: Add more `wrapper_unit_tests` tests.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c18e8ba242
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
1f3f0dce11
@0x/contracts-exchange
: Add fillOrderNoThrow
tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
b73008d83d
@0x/contracts-exchange
: Fix fillOrKillOrder()
tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00