It was added due to the introduction of the use of the TakerRequest type
from @0x/quote-server, as it's included in that structure. However,
that structure is primarily used within the quote server as the output
of parameter parsing, and that parsing routine transforms the API key
HEADER from the request into the TakerRequest type. In short, the API
key is input as a header, not a parameter.
Addresses review comment
https://github.com/0xProject/0x-monorepo/pull/2582#discussion_r437624647
This comment recently got moved from one context to another. In the old
context, the whole comment made sense, but in the new context it needed
paring down.
These changes have been exercised via mocha tests in the 0x-api repo.
Not sure why I had to add GetMarketOrdersRfqtOpts to the package
exports. `yarn test:generate_docs:circleci` said:
$ node ./packages/monorepo-scripts/lib/doc_generate.js --package @0x/asset-swapper
GENERATE_DOCS: Generating Typedoc JSON for @0x/asset-swapper...
GENERATE_DOCS: Generating Typedoc Markdown for @0x/asset-swapper...
GENERATE_DOCS: Modifying Markdown To Exclude Unexported Items...
Error: @0x/asset-swapper package needs to export:
GetMarketOrdersRfqtOpts
From it's index.ts. If any are from external dependencies, then add them to the EXTERNAL_TYPE_MAP.
at DocGenerateUtils._lookForMissingReferenceExportsThrowIfExists (/root/repo/packages/monorepo-scripts/lib/utils/doc_generate_utils.js:288:19)
at DocGenerateUtils.<anonymous> (/root/repo/packages/monorepo-scripts/lib/utils/doc_generate_utils.js:255:34)
at step (/root/repo/packages/monorepo-scripts/lib/utils/doc_generate_utils.js:32:23)
at Object.next (/root/repo/packages/monorepo-scripts/lib/utils/doc_generate_utils.js:13:53)
at fulfilled (/root/repo/packages/monorepo-scripts/lib/utils/doc_generate_utils.js:4:58)
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:189:7)
There's one subtlety here: apiKey has been moved to be within the rfqt
namespace, after talking to Fabio and discovering that he only needs to
re-use the API key in 0x API, not in asset-swapper.
* test for returning a 200 with invalid data, and additonal logging for that case
* Ensure RFQ-T response has asset data we expect
* validate signed order schema
* give more descriptive variable names and test an unsigned order
* takeout unused var
