Lawrence Forman
aebb923c2d
@0x/contracts-exchange: Major rework of fill_order_combinatorial_utils.
...
`@0x/contracts-exchange`: Add more arbitrary fee token tests.
`@0x/contracts-exchange`: Fix broken tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
d11444b983
@0x/contracts-exchange: Fix Exchange Wrappers tests.
2019-07-23 15:26:59 -07:00
Lawrence Forman
0508a45681
@0x/contracts-echange: Fix transactions test bug with ExchangeWrapper example due to deduping.
2019-07-23 15:26:59 -07:00
Lawrence Forman
9d257497bd
Ran prettier and fixed linter errors
2019-07-23 15:23:40 -07:00
Lawrence Forman
79f40b4ce0
@0x/contracts-exchange: Enable all exchange tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
1ab62b7a80
@0x/contracts-exchange: Fix broken match orders tests
2019-07-23 15:23:40 -07:00
Lawrence Forman
d2f10d5834
@0x/contracts-exchange: Allow custom ExchangeWrapper.matchOrders() call in MatchOrdersTester.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c326ec9d1e
@0x/contracts-exchange: Rewrote MatchOrderTester class to be simpler and more flexible.
2019-07-23 15:23:40 -07:00
Lawrence Forman
26317d16ff
@0x/contracts-exchange: Fix matchOrders() not paying fees if same feeRecipient but different feeAssetDatas.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c84a0b8415
@0x/contracts-exchange: Fix matchOrders and signature tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
be5336d074
@0x/contracts-exchange: Enable all tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
aecb2efad9
@0x/contracts-exchange: Fix combinatorial fillOrder test bugs.
...
`@0x/contracts-exchange`: Fix emit `Fill` event code.
2019-07-23 15:23:40 -07:00
Lawrence Forman
8c2fa64c47
@0x/contracts-exchange: Remove dependency on LibAbiEncoder.
2019-07-23 15:23:40 -07:00
Lawrence Forman
bca199e118
@0x/contracts-exchange: Fix Fill emit code.
2019-07-23 15:23:40 -07:00
Lawrence Forman
8aa3b535f0
@0x/contracts-exchange: Update fill order tests for arbitrary fee tokens. (Still more to do)
2019-07-23 15:23:40 -07:00
Lawrence Forman
7cb6795d40
@0x/contracts-exchange-libs: Add takerFeeAssetData and makerFeeAssetData to Order struct.
2019-07-23 15:23:40 -07:00
Lawrence Forman
a5f4478e20
@0x/contracts-exchange: Remove zrxAssetData from constructor and remove dependency on LibConstants.
...
`@0x/contracts-exchange`: Update `fillOrder()` and `matchOrders()` to settle arbitrary fees.
`@0x/contracts-exchange`: emit `Fill()` events the hard way to avoid a stack overflow.
2019-07-23 15:23:40 -07:00
Amir Bandeali
051997acb0
Fix linting errors
2019-07-23 15:23:40 -07:00
Amir Bandeali
51ef0e1e6d
Add tests for cancelOrderNoThrow and batchCancelOrdersNoThrow
2019-07-23 15:23:40 -07:00
Amir Bandeali
ed0fcf2829
Remove LibAbiEncoder
2019-07-23 15:23:40 -07:00
Amir Bandeali
2ce94b73ad
Use build in abi.encode instead of LibAbiEncoder for fillOrderNoThrow
2019-07-23 15:23:40 -07:00
Amir Bandeali
ef96bff6ec
Add cancelOrderNoThrow and batchCancelOrdersNoThrow
2019-07-23 15:23:40 -07:00
Lawrence Forman
0cfcb6aa37
Apply suggestions from code review
...
Co-Authored-By: abandeali1 <abandeali1@gmail.com>
2019-07-23 15:21:14 -07:00
Amir Bandeali
6b40812e6d
Fix incorrect CancelUpTo event args
2019-07-23 15:21:14 -07:00
Amir Bandeali
6763bce627
Add _ to remaining internal/private functions
2019-07-23 15:21:14 -07:00
Amir Bandeali
3e461ac2e5
Rename internal and private functions
2019-07-23 15:21:14 -07:00
Lawrence Forman
46af2ffcea
In @0x/contracts-exchange: Merge new transaction tests from rebase.
2019-07-23 15:21:14 -07:00
Lawrence Forman
e5b3a82112
In @0x/contracts-utils and @0x/contracts-exchange: Hardcode rich revert selector constants.
2019-07-23 15:21:14 -07:00
Lawrence Forman
61bdbd2d74
Rebased against 3.0.
...
Run prettier/linter.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a1293f160f
In @0x/contracts-exchange: Remove only from lib_exchange_rich_error_decoder tests.
2019-07-23 15:21:14 -07:00
Lawrence Forman
847503bff1
In @0x/contracts-exchange: Add more tests for LibExchangeRichErrorDecoder.
2019-07-23 15:21:14 -07:00
Lawrence Forman
576242551f
In @0x/contracts-exchange: Add more tests for LibExchangeRichErrorDecoder.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdb6bee65f
In @0x/contracts-exchange: Add tests for LibExchangeRichErrorDecoder.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a2846faa61
Move @0x/rich-reverts-decoder into @0x/contracts-exchange/contracts/src/libs/LibExchangeRichErrorDecoder.
2019-07-23 15:21:14 -07:00
Lawrence Forman
e24b8947e0
In @0x/contracts-exchange: Pull types and constants from MExchangeRichErrors into MExchangeRichErrorTypes.
...
In `@0x/contracts-utils`: Pull types and constants from `MRichErrors` into `MRichErrorTypes`.
2019-07-23 15:21:14 -07:00
Lawrence Forman
d942c47f08
In @0x/contracts-exchange: Change parameter order and naming of some rich revert errors.
...
In `@0x/order-utils`: Change parameter order for `OrderStatusError`.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdaee1375c
In @0x/contracts-exchange: Update tests for rich reverts
2019-07-23 15:21:14 -07:00
Lawrence Forman
d25a510291
In @0x/contracts-exchange: upgrading tests...
2019-07-23 15:21:14 -07:00
Amir Bandeali
e42a0979bc
Add return natspec to all MixinTransaction functions
2019-07-23 15:21:14 -07:00
Amir Bandeali
f1a78682aa
Add batch fill method tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
dc4bfde76d
Fix linting errors
2019-07-23 15:21:14 -07:00
Amir Bandeali
e717625f86
Add batchExecuteTransactions tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
41444e7ede
Refactor transaction tests to iclude more combinations and to cover all revert cases
2019-07-23 15:21:14 -07:00
Amir Bandeali
fc2a59ceaa
Update imports in tests
2019-07-23 15:21:13 -07:00
Amir Bandeali
72f4b216c1
Move exchange specific types. constants, and utils into exchange package
2019-07-23 15:21:13 -07:00
Amir Bandeali
d373f5488a
Add functions with mutex to ReentrantERC20Token and update IExchange with missing function
2019-07-23 15:19:33 -07:00
Amir Bandeali
24906138c7
Make preSign compatible with executeTransaction
2019-07-23 15:19:33 -07:00
Amir Bandeali
e80abad19a
Add batchExecuteTransaction
2019-07-23 15:18:26 -07:00
Amir Bandeali
c9c228ffdd
Add return data to executeTransaction
2019-07-23 15:18:26 -07:00
Amir Bandeali
6fc30d31bf
Fix missed conflicts and rebuild
2019-07-23 15:18:26 -07:00
