James Towle
92a4556956
Merge pull request #2020 from jalextowle/feature/contracts/3.0/rewrite-dispatch-transfer-from
...
Rewrite _dispatchTransferFrom with a Solidity implementation
2019-08-02 13:42:36 -07:00
James Towle
bd42c33daa
Merge pull request #2014 from jalextowle/feature/contracts/3.0/utils-unit-tests
...
Added Unit Tests to Utils
2019-08-02 13:42:14 -07:00
Alex Towle
8c5c81fe70
Change all instances of throw to revert in it tests
2019-08-01 15:13:16 -07:00
Alex Towle
bf8fae2025
Update changelog
2019-08-01 14:53:01 -07:00
Alex Towle
7f2b715ceb
Rewrite _dispatchTransferFrom with a Solidity implementation
2019-08-01 14:53:00 -07:00
Alex Towle
3ca3a2820d
Fixed review comments
2019-07-30 15:53:01 -07:00
Lawrence Forman
3cf48a831b
@0x/contracts-test-utils: Export a custom describe() instead of
...
extending Mocha's ambient declarations.
`@0x/contracts-exchange`: Use `describe.optional` instead of
`blockchainTests.optional` in `test/fill_order.ts`.
2019-07-30 16:59:52 -04:00
Lawrence Forman
d3870fed1c
@0x/contracts-exchange: Update test/fill_order.ts to use the new
...
mocha blockchain extensions.
2019-07-30 16:59:52 -04:00
Amir Bandeali
90d1decb87
Fix build errors
2019-07-24 10:26:28 -07:00
Alex Towle
1d8cb1b107
Addressed lingering review comments
2019-07-23 15:53:26 -07:00
Alex Towle
65e3d9873d
Added ERC1155 Aggregation
2019-07-23 15:53:26 -07:00
Alex Towle
50b22c673e
Addressed review comments
2019-07-23 15:53:26 -07:00
Alex Towle
4ef8b7f733
Rebased onto 3.0
2019-07-23 15:53:26 -07:00
James Towle
e0ec26255b
Fixed lingering issues
2019-07-23 15:53:26 -07:00
James Towle
ffa32f7610
Changed the returndata for batchMatchOrders
2019-07-23 15:53:26 -07:00
James Towle
1c1d257bd9
Addressed lingering review comments
2019-07-23 15:53:26 -07:00
James Towle
5611cb91a0
Adapted tests from matchOrders to test matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
e0cff4b74e
Updated batchMatchOrders to fix an edge case and added tests
2019-07-23 15:53:26 -07:00
James Towle
c1985e6986
Addessed some review comments
2019-07-23 15:53:26 -07:00
James Towle
416b1aee98
Improved the testing for matchOrders and batchMatchOrders
2019-07-23 15:53:26 -07:00
James Towle
7bb9d8b03a
Created a test for case 3 of matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
0473c82029
Improved test coverage for batchMatchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
63bd1a4a22
Ran prettier
2019-07-23 15:53:26 -07:00
James Towle
5a64759c83
Added a reentrancy test for matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
0df68a6e06
Added testing for the BatchMatchOrdersError Rich Error
2019-07-23 15:53:26 -07:00
James Towle
29eff3b515
Rebased onto PR #1900
2019-07-23 15:53:26 -07:00
James Towle
073976de10
Split up TestExchangeInternals into two contracts
2019-07-23 15:53:26 -07:00
James Towle
1fe159f432
Polished MixinMatchOrders and removed unimplemented test
2019-07-23 15:53:26 -07:00
James Towle
adad7f4e3f
Modified the matchOrders tests to test matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
378710533e
Implemented matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
d966848ef8
Implemented batchMatchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
d6d613ca37
Added a new test
2019-07-23 15:53:26 -07:00
James Towle
1a385de367
Improved the efficiency of batchMatchOrders
2019-07-23 15:53:25 -07:00
James Towle
73eb56c072
Added RichErrors to batchMatchOrders
2019-07-23 15:53:25 -07:00
James Towle
9651941cce
Added getMatchOrdersResultsAsync and getBatchMatchOrdersResultsAsync
2019-07-23 15:53:25 -07:00
James Towle
29be79814f
Added a test for partial matching
2019-07-23 15:53:25 -07:00
James Towle
1ea220f44f
Removed batchMatchOrdersWithMaximumFill
2019-07-23 15:53:25 -07:00
James Towle
6cf11554de
Created tests for batchMatchOrders
2019-07-23 15:53:25 -07:00
James Towle
f289b3112b
Implemented batchMatchOrders
2019-07-23 15:53:25 -07:00
James Towle
c61df50167
Updated Changelogs
2019-07-23 15:53:25 -07:00
James Towle
6384518ee1
@0x:contracts-exchange Updated LibMath to use library rich errors
2019-07-23 15:53:25 -07:00
James Towle
53db047a4e
@0x:contracts-exchange Eliminated code duplication within LibExchangeRichErrors and IExchangeRichErrors
2019-07-23 15:53:25 -07:00
James Towle
dabef47ce7
@0x:contracts-exchange Updated MixinTransactions to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
4de1d69282
@0x:contracts-exchange Updated MixinMatchOrders to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
015c35f2b2
@0x:contracts-exchange Updated MixinSignatureValidator to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
5a491b2624
@0x:contracts-exchange Updated MixinWrapperFunctions to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
3d95817dbe
@0x:contracts-exchange Updated MixinAssetProxyDispatcher and MixinExchangeCore to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
f937a0b038
@0x:contracts-utils Added RichErrors to ReentrancyGuard
2019-07-23 15:53:25 -07:00
Lawrence Forman
c788db785b
@0x/contracts-exchange: Use named return values in MixinSignatureValidator.sol
2019-07-23 15:53:25 -07:00
Lawrence Forman
6df41d2562
@0x/contracts-exchange: REALLY make assertValidFill() internal again.
2019-07-23 15:53:25 -07:00
