Xianny
6a852ab0ed
Replace assetDataUtils with DevUtilsContract wherever possible ( #2304 )
...
* Replace assetDataUtils with DevUtilsContract wherever possible
Does not replace from @0x/instant and some @0x/order-utils uses
* Add revertIfInvalidAssetData to LibAssetData
This is needed to replace `assetDataUtils.decodeAssetDataOrThrow`.
Because it's used in packages and not only contracts, we should wait
to deploy the updated contract so we can update `@0x/contract-artifacts`,
`@0x/abi-gen-wrappers`, and `@0x/contract-wrappers` first.
* remove usages of signatureUtils
* fix test for optimised encoding
* refactor @0x/contracts-integrations
* update changelogs
* Move @0x/contracts-dev-utils from devDependencies to dependencies
It is exported as part of the package
2019-11-06 19:40:20 -08:00
Greg Hysen
68656c4083
Fixes intermittent test failure by removing block timestamp contraints from staking scheduler tests
2019-11-05 16:57:37 -08:00
Greg Hysen
a7f0717afb
Unit tests for MixinCumulativeRewards
2019-11-05 15:32:04 -08:00
Greg Hysen
9b2231ed24
Improved readability on some tests + updated staking changelog
2019-11-05 14:59:55 -08:00
Greg Hysen
c123200f38
Unit tests for MixinScheduler
2019-11-04 15:44:46 -08:00
Lawrence Forman
47e050cbaf
Merge pull request #2312 from 0xProject/feat/contracts/staking/MixinStakingPoolRewards-unit-tests
...
MixinStakingPoolRewards unit tests
2019-11-04 17:19:03 -05:00
Lawrence Forman
c957b48281
@0x/contracts-staking
: Run prettier.
2019-11-04 11:10:07 -05:00
Lawrence Forman
c15c5e12b0
@0x/contracts-staking
: Fix event name collision in MixinStakingPoolRewards
unit tests.
2019-11-04 11:09:21 -05:00
Lawrence Forman
15c3c8074c
@0x/contracts-staking
: Add separate unit tests for withdrawDelegatorRewards()
and _withdrawAndSyncDelegatorRewards()
.
2019-11-04 10:43:37 -05:00
Lawrence Forman
cba72c811d
@0x/contracts-staking
: Add _computePoolRewardsSplit()
tests to MixinStakingPoolRewards
unit tests.
2019-11-04 10:43:37 -05:00
Lawrence Forman
28a2e56003
@0x/contracts-staking
: Add more MixinStakingPoolRewards
unit tests.
2019-11-04 10:43:37 -05:00
Lawrence Forman
8c4c3d56c6
@0x/contracts-staking
: Create MixinStakingPoolRewards
unit tests.
2019-11-04 10:43:37 -05:00
Lawrence Forman
4f56d68689
@0x/contracts-staking
: Fix overflow w/ LibFixedMath._mul(-1, -2*255)
.
2019-11-01 13:35:23 -04:00
Greg Hysen
3a1c464543
Readability improvements to Staking Proxy unit tests + one extra case
2019-11-01 09:59:17 -07:00
Greg Hysen
7bfbf0ad3a
Staking Proxy unit tests + Staking Proxy fallback reverts if no staking contract is attached
2019-10-31 18:22:49 -07:00
Lawrence Forman
a02892cbc8
@0x/contracts-staking
: Remove duplicated test case in MixinStakeBalances
unit tests.
2019-10-29 07:37:06 -04:00
Lawrence Forman
49c67fbb18
@0x/contracts-staking
: Remove unused lodash import and only
modifier from MixinStakeBalances
unit tests.
2019-10-29 07:37:06 -04:00
Lawrence Forman
6f2e79208a
@0x/contracts-staking
: Add MixinStakeBalances
unit tests.
2019-10-29 07:37:06 -04:00
Greg Hysen
9c181f09ba
Removed LibProxy and inlined proxy call in StakingProxy.
2019-10-28 16:42:52 -07:00
Amir Bandeali
f246314b1d
Update default alpha from 1/2 to 2/3
2019-10-27 16:53:57 -07:00
Amir Bandeali
33a0c22021
Remove tests related to read-only mode
2019-10-27 11:12:22 -07:00
Lawrence Forman
b1b1162b60
@0x/contracts-staking
: Add MixinStakingPool
unit tests.
2019-10-25 10:55:03 -04:00
Greg Hysen
cc7452da8f
Replaced protocolFeePaid
-> protocolFeeAmount
. Changed some wording in comments.
2019-10-24 15:58:18 -07:00
Lawrence Forman
703e890918
@0x/contracts-staking
: Call StakingProxy.assertValidStorageParams()
in MixinParams.setParams()
2019-10-23 04:40:47 -04:00
Greg Hysen
c676ecb8cf
Force no-op when moving zero stake or moving from undelegated to undelegated.
2019-10-22 15:39:24 -07:00
Greg Hysen
c44e16a88f
Removed assertion that protocol fee != 0 from staking contract.
2019-10-22 12:42:04 -07:00
Greg Hysen
22e39f782f
Some (more) readability improvements and minor optimizations to staking finalization.
2019-10-22 12:09:18 -07:00
Greg Hysen
d91a7fc663
Some readability improvements and minor optimizations to staking finalization.
2019-10-22 11:02:25 -07:00
Greg Hysen
ce8fd44234
Removed lingering references to stale terminology ("active pools")
2019-10-22 11:02:25 -07:00
Greg Hysen
6617ad9531
Refactored finalization state.
...
1. Removes state variables:
- totalWeightedStakeThisEpoch
- totalFeesCollectedThisEpoch
- numActivePoolsThisEpoch
2. No longer indexes by epoch % 2
3. Renamed event StakingPoolActivated → StakingPoolEarnedRewards.
4. Renamed structs:
- ActivePool → PoolStats. This holds stats for a pool that earned rewards.
- UnfinalizedState → AggregatedStats. This aggregates stats from the former struct.
2019-10-22 11:02:25 -07:00
Amir Bandeali
359b804001
Add test for withdrawing rewards before epoch is finalized
2019-10-21 22:27:06 -07:00
Amir Bandeali
44dac2cd80
Fix tests that assume touching stake will finalize pool
2019-10-21 22:27:06 -07:00
Amir Bandeali
1885957bd3
Update tests to start at epoch 1
2019-10-21 22:27:06 -07:00
Lawrence Forman
c7ca625408
@0x/contracts-staking
: Fix MixinStake
unit tests typo.
2019-10-18 10:45:07 -04:00
Lawrence Forman
e46f51339a
@0x/contracts-staking
: Address review comments.
2019-10-18 10:42:47 -04:00
Lawrence Forman
008938cf5b
@0x/contracts-staking
: Check order of increase and derease balance operations in MixinStake
unit tests.
2019-10-17 14:09:46 +10:00
Lawrence Forman
b793a31cdd
@0x/contracts-staking
: Create MixinStake
unit tests.
2019-10-16 22:53:36 +10:00
Lawrence Forman
54a03eacd6
@0x/contracts-staking
: Refactor MixinCumulativeRewards
and MixinStakingPoolRewards
to better encapsulate cumulative rewards.
...
`@0x/contracts-staking`: Make sure we don't overwrite an existing CR.
`@0x/contracts-staking`: Remove the need to initialize cumulative rewards when creating a pool.
`@0x/contracts-staking`: Just return an empty CR in `_getCumulativeRewardAtEpoch()` if one can't be found.
2019-10-14 12:36:26 +10:00
Amir Bandeali
ce6c05637f
Update cumulative rewards tracking tests
2019-10-13 17:31:55 +09:00
Lawrence Forman
9f6d113fe8
Merge pull request #2255 from 0xProject/fix/3.0-audit/staking/LibFixedMath-arithmetic-overflows
...
Fix LibFixedMath arithmetic overflows
2019-10-12 07:38:05 +09:00
Greg Hysen
361576814c
Removed loadSyncedBalance and loadUnsyncedBalance
2019-10-10 15:51:24 +09:00
Lawrence Forman
22fc0b4337
@0x/contracts-staking
: Add another LibFixedMath.add()
test.
2019-10-10 09:31:53 +09:00
Lawrence Forman
063d6ff24e
@0x/contracts-staking
: Add more overflow safeguards to LibFixedMath
.
2019-10-10 09:16:01 +09:00
Lawrence Forman
a42f3d189c
@0x/contracts-staking
: Implement better overflow detection in LibFixedMath
.
2019-10-10 09:16:01 +09:00
Amir Bandeali
93edb083fa
Remove payable fallback from IStakingProxy, fix linting errors
2019-10-09 17:27:37 +09:00
Amir Bandeali
9e41c648dc
Add backstop tests
2019-10-09 17:27:37 +09:00
Amir Bandeali
681e6eab7a
Cleanup language used in comments and variable names
2019-10-09 17:15:25 +09:00
Amir Bandeali
701b203c58
Fix tests
2019-10-09 17:15:25 +09:00
Amir Bandeali
aa0a1bb54d
Fix tests to no longer utilize active stake
2019-10-09 17:15:25 +09:00
Amir Bandeali
43399a9ad9
Refactor tests to use new getters
2019-10-09 17:15:25 +09:00