Lawrence Forman
e4475c08e8
@0x/contracts-exchange
: Switch to consolidated IncompleteFillError
rich error.
...
`@0x/contracts-exchange`: Allow `marketSell/BuyOrdersNoThrow` to be destructive to orders again.
2019-08-21 10:59:34 -04:00
Lawrence Forman
edef3bc30e
@0x/contracts-exchange
: Fix failing wrapper.ts
test.
2019-08-21 10:59:34 -04:00
Lawrence Forman
0c7f09b832
ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
34d075ce8c
@0x/contracts-exchange
: Update marketBuy/SellOrdersNoThrow()
to NOT be destructive to the orders.
...
`@0x/contracts-exchange`: Fix wrapper unit tests to use the actual order hash algorithm, since it can't be overridden anymore.
2019-08-21 10:59:34 -04:00
Lawrence Forman
8c06d660ea
Update CHANGELOGs with PR numbers.
2019-08-21 10:59:34 -04:00
Lawrence Forman
748566b4fb
@0x/contracts-exchange
: Tweak exchangeDataEncoder
test utility to work with marketBuy/SellFillOrKill()
functions.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fb38867e78
Ran prettier
2019-08-21 10:59:34 -04:00
Lawrence Forman
a2613625c6
@0x/contracts-exchange
: Squelch linter errors in LibExchangeRichErrorDecoder
.
2019-08-21 10:59:34 -04:00
Lawrence Forman
fd2a240c9f
@0x/contracts-exchange`: Update changelog.
2019-08-21 10:59:34 -04:00
Lawrence Forman
96bef08ac2
@0x/contracts-exchange
: Rename marketSellOrders
and marketBuyOrders
back to marketSellOrdersNoThrow
and marketBuyOrdersNoThrow
.
...
`@0x/contracts-exchange`: Introduce new `marketSellOrdersFillOrKill` and `marketBuyOrdersFillOrKill` functions.
`@0x/contracts-exchange`: Add new rich error types: `IncompleteMarketBuyError` and `IncompleteMarketSellError`.
`@0x/contracts-exchange`: Use `abi.decode()` in `LibExchangeRichErrorDecoder` over `LibBytes`.
2019-08-21 10:59:34 -04:00
Lawrence Forman
1698519a6a
@0x/contracts-exchange
: Overridden functions in ReentrancyTester
now return sane values.
2019-08-21 10:59:34 -04:00
Amir Bandeali
f09cadb7b3
Add truffle compile option to contract packages
2019-08-20 12:49:33 -07:00
Amir Bandeali
c366a4bd83
Update copyright dates
2019-08-20 12:49:01 -07:00
Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Amir Bandeali
4c78b7d4bb
Merge pull request #2055 from 0xProject/feat/3.0/optimizeConstants
...
Refactor library usage
2019-08-16 07:40:54 -07:00
Amir Bandeali
8402d211bf
Update CHANGELOGs
2019-08-15 16:51:50 -07:00
Amir Bandeali
7ac30c5153
Merge branch '3.0' into feat/3.0/optimizeConstants
2019-08-15 15:20:48 -07:00
Greg Hysz
64bc99101c
Merge pull request #2059 from 0xProject/feature/contracts/3.0/fillOrderAssertionWrapper
...
Fill Order Assertion Wrapper
2019-08-15 00:12:40 +02:00
Greg Hysen
09b5018e65
Readability improvements
2019-08-14 23:45:07 +02:00
Amir Bandeali
1dae1d244c
Rename hashing functions in LibOrder and LibZeroExTransaction
2019-08-14 13:38:12 -07:00
Alex Towle
6b4e632101
@0x:contracts-exchange
Refactored internal.ts so that it is more readable
2019-08-14 10:39:36 -07:00
Alex Towle
0134b2874b
@0x:contracts-exchange
Addressed remaining review comments
2019-08-13 17:05:38 -07:00
Alex Towle
e2308aabed
@0x:contracts-exchange
Reduced the code size of internal.ts
2019-08-13 17:04:42 -07:00
Alex Towle
36fac3532c
Removed unused reference functions
2019-08-13 17:04:42 -07:00
Alex Towle
327c6e8ac2
Completed the calculateMatchedFillResultsWithMaximalFill tests
2019-08-13 17:04:25 -07:00
Alex Towle
e9d49d96a6
Changed the testing style to be more assertion based rather than reference based to leverage the fixtures from the integration tests
2019-08-13 17:04:25 -07:00
Alex Towle
929bb86a54
Wrote some test cases for assertValidMatch
2019-08-13 17:04:25 -07:00
Alex Towle
f58e28d1be
Implemented reference functions and added tests for _calculateCompleteRightFill
2019-08-13 17:04:25 -07:00
Alex Towle
cdabe21e7a
Fixed the tests by using the IsolatedExchange
2019-08-13 17:04:25 -07:00
Alex Towle
a7520eeaa8
Wrote some initial test cases for the matchOrders calculate functions
2019-08-13 17:02:00 -07:00
Amir Bandeali
070147db52
Fix build errors
2019-08-13 16:43:55 -07:00
Amir Bandeali
dc31294440
Move LibExchangeRichErrors to exchange-libs package
2019-08-13 16:20:35 -07:00
Amir Bandeali
d3b8070fd6
Fix TestValidatorWallet by using new LibOrder and LibZeroExTransaction hashing
2019-08-13 16:19:48 -07:00
Amir Bandeali
26e4d66163
Remove unimplemented functions from interface
2019-08-13 16:19:48 -07:00
Amir Bandeali
0e2616f16b
Rename _rrevert to rrevert
2019-08-13 16:19:48 -07:00
Amir Bandeali
ccce7e001e
Compile all contracts by default, regenerate boilerplate
2019-08-13 16:19:48 -07:00
Amir Bandeali
d6772b4a0a
Fix linting errors
2019-08-13 16:11:57 -07:00
Amir Bandeali
5016d50c2b
Move calculateFillResults tests to exchange-libs package
2019-08-13 16:11:09 -07:00
Amir Bandeali
31c2b36039
Fix build errors in exchange package contracts
2019-08-13 16:11:09 -07:00
Amir Bandeali
9b786df828
Update test contracts
2019-08-13 16:11:09 -07:00
Amir Bandeali
ae859fa01e
Update Exchange contract to use libraries
2019-08-13 16:11:09 -07:00
Amir Bandeali
a8cd168345
Cleanup imports
2019-08-13 16:09:48 -07:00
Amir Bandeali
b05a2a90d0
Move FillResults calculations into LibFillResults
2019-08-13 16:09:48 -07:00
Amir Bandeali
242715240b
Do not inherit libs
2019-08-13 16:07:07 -07:00
Amir Bandeali
7d5276ad11
Remove LibExchangeSelectors.sol
2019-08-13 16:04:33 -07:00
Greg Hysen
dd4541c825
Fill Order Assertion Wrapper
2019-08-13 17:51:40 +02:00
Lawrence Forman
fc18db10be
@0x/contracts-exchange
: Add tests for when callback signature types return incorrect data.
2019-08-12 19:10:24 -04:00
Lawrence Forman
9382e2e8c7
@0x/contracts-exchange
: Fix bad resultData
assertion in fillOrderNoThrow()
.
2019-08-12 18:53:40 -04:00
Lawrence Forman
a3b2dbf8e2
@0x/contracts-exchange
: Remove redundant new bytes(0)
in ReentrancyTester.sol
.
2019-08-12 18:32:05 -04:00
Lawrence Forman
6df190edbb
@0x/contracts-exchange
: Light changes to address PR comments.
2019-08-12 18:20:50 -04:00