Alex Towle
22c8a25a26
Merge branch 'development' into 3.0
2019-08-19 11:13:21 -07:00
Alex Towle
327c6e8ac2
Completed the calculateMatchedFillResultsWithMaximalFill tests
2019-08-13 17:04:25 -07:00
Lawrence Forman
a2234b745c
@0x/contracts-exchange
: Create semi-automated reentrancy testing.
...
`@0x/contracts-exchange`: Remove old reentrancy tests.
`@0x/contracts-exchange`: Remove `ReentrantERC20Token` contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
6345faa4a9
`@0x/contracts-exchange-libs: Appease the linter and prettier gods.
2019-08-06 15:30:59 -04:00
Lawrence Forman
51391b7f0e
@0x/contracts-exchange-libs
: Correct internal variable naming in src/index.ts
.
...
`@0x/contracts-utils`: Correct internal variable naming in `src/index.ts`.
`@0x/contracts-exchange`: Remove functions from `TestExchangeInternals.sol` that are now in other packages.
`@0x/contracts-exchange`: Remove `TestExchangeMath.sol`. Exchange math functions are now tested in `@0x/contracts-exchange-libs`.
`@0x/contracts-exchange`: Move `ReferenceFunctions` to default package export.
`@0x/contracts-exchange`: Update `match_order.ts` tests to use reference math functions instead of `TestExchangeMath`.
`@0x/contracts-exchange`: Remove `_updateFilledState()` combinatorial tests in favor of normal unit testing. Combinatorial testing was overkill.
`@0x/contracts-exchange`: Update/refactor `calculateFillResults()` combinatorial tests to use the reference functions and hide them behind `TEST_ALL`.
2019-08-06 15:30:59 -04:00
Alex Towle
8c5c81fe70
Change all instances of throw to revert in it tests
2019-08-01 15:13:16 -07:00
Greg Hysen
df746c5ff4
Decode log arguments in awaitTransactionSuccessAsync
, when ABI is recognized.
2019-07-29 12:04:37 +02:00
Alex Towle
1d8cb1b107
Addressed lingering review comments
2019-07-23 15:53:26 -07:00
Alex Towle
50b22c673e
Addressed review comments
2019-07-23 15:53:26 -07:00
Alex Towle
4ef8b7f733
Rebased onto 3.0
2019-07-23 15:53:26 -07:00
James Towle
ffa32f7610
Changed the returndata for batchMatchOrders
2019-07-23 15:53:26 -07:00
James Towle
5611cb91a0
Adapted tests from matchOrders to test matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
e0cff4b74e
Updated batchMatchOrders to fix an edge case and added tests
2019-07-23 15:53:26 -07:00
James Towle
7bb9d8b03a
Created a test for case 3 of matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
0473c82029
Improved test coverage for batchMatchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
63bd1a4a22
Ran prettier
2019-07-23 15:53:26 -07:00
James Towle
0df68a6e06
Added testing for the BatchMatchOrdersError Rich Error
2019-07-23 15:53:26 -07:00
James Towle
29eff3b515
Rebased onto PR #1900
2019-07-23 15:53:26 -07:00
James Towle
073976de10
Split up TestExchangeInternals into two contracts
2019-07-23 15:53:26 -07:00
James Towle
1fe159f432
Polished MixinMatchOrders and removed unimplemented test
2019-07-23 15:53:26 -07:00
James Towle
adad7f4e3f
Modified the matchOrders tests to test matchOrdersWithMaximalFill
2019-07-23 15:53:26 -07:00
James Towle
d6d613ca37
Added a new test
2019-07-23 15:53:26 -07:00
James Towle
29be79814f
Added a test for partial matching
2019-07-23 15:53:25 -07:00
James Towle
1ea220f44f
Removed batchMatchOrdersWithMaximumFill
2019-07-23 15:53:25 -07:00
James Towle
6cf11554de
Created tests for batchMatchOrders
2019-07-23 15:53:25 -07:00
James Towle
f937a0b038
@0x:contracts-utils
Added RichErrors to ReentrancyGuard
2019-07-23 15:53:25 -07:00
Lawrence Forman
2f464ee8f0
@0x/contracts-exchange
: Fix critical error in fillOrder()
and matchOrders()
redundant transfer optimization code.
...
`@0x/contracts-exchange`: Rearrange `Fill` event params to make regular `emit` code work without breaking the stack.
`@0x/contracts-exchange`: Add edge case tests for redundant transfer optimizations.
2019-07-23 15:46:15 -07:00
Lawrence Forman
ee89f74afd
@0x/contracts-exchange
: Avoid redundant transfer in matchOrders()
when maker/feeRecipient and takerAssetData/makerFeeAssetData are the same.
...
`@0x/conracts-exchange`: Disable combinatorial tests by default. Can be run by setting env var `TEST_ALL=1`.
2019-07-23 15:46:15 -07:00
Lawrence Forman
cd08c3e8fa
@0x/contracts-exchange
: Avoid redundant trasfer in fillOrder()
when maker/taker is the same as feeRecipient and the assets match.
...
`@0x/contracts-exchange`: Swap fill order in `fillOrder()` from maker -> taker to taker -> maker first
2019-07-23 15:46:15 -07:00
Lawrence Forman
91c27ff972
@0x/contracts-exchange
: Fix build error.
2019-07-23 15:46:15 -07:00
Lawrence Forman
07e3ba014c
@0x/contracts-exchange
: Fully incorporate ERC1155 and MultiAsset tests into the fillOrder
and matchOrders
test suites.
2019-07-23 15:46:15 -07:00
Lawrence Forman
816368b1fe
@0x/contracts-exchange
: Re-eanble all exchange tests.
...
`@0x/contracts-echange`: Set up 1155 and MAP proxies for `matchOrders()` tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
518f351235
@0x/contracts-exchange
: Correct coding convention in match_orders.ts
2019-07-23 15:44:58 -07:00
Lawrence Forman
aebb923c2d
@0x/contracts-exchange
: Major rework of fill_order_combinatorial_utils
.
...
`@0x/contracts-exchange`: Add more arbitrary fee token tests.
`@0x/contracts-exchange`: Fix broken tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
9d257497bd
Ran prettier and fixed linter errors
2019-07-23 15:23:40 -07:00
Lawrence Forman
79f40b4ce0
@0x/contracts-exchange
: Enable all exchange tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
1ab62b7a80
@0x/contracts-exchange
: Fix broken match orders tests
2019-07-23 15:23:40 -07:00
Lawrence Forman
c326ec9d1e
@0x/contracts-exchange
: Rewrote MatchOrderTester
class to be simpler and more flexible.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c84a0b8415
@0x/contracts-exchange
: Fix matchOrders
and signature tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
8aa3b535f0
@0x/contracts-exchange
: Update fill order tests for arbitrary fee tokens. (Still more to do)
2019-07-23 15:23:40 -07:00
Amir Bandeali
3e461ac2e5
Rename internal and private functions
2019-07-23 15:21:14 -07:00
Lawrence Forman
61bdbd2d74
Rebased against 3.0
.
...
Run prettier/linter.
2019-07-23 15:21:14 -07:00
Lawrence Forman
d942c47f08
In @0x/contracts-exchange
: Change parameter order and naming of some rich revert errors.
...
In `@0x/order-utils`: Change parameter order for `OrderStatusError`.
2019-07-23 15:21:14 -07:00
Amir Bandeali
fc2a59ceaa
Update imports in tests
2019-07-23 15:21:13 -07:00
Lawrence Forman
a0223835b8
In @0x/order-utils
: Add signerAddress
and signature
to ExchangeRevertErrors.SignatureError
.
...
In `@0x/contracts-exchange`: Add `signerAddress` and `signature` to `SignatureError` reverts.
2019-07-23 15:17:56 -07:00
Lawrence Forman
ac18359410
Switch order of parameters in some rich reverts for easier dirty parsing.
2019-07-23 15:17:56 -07:00
Lawrence Forman
233336ea16
Ran prettier and linter
2019-07-23 15:17:56 -07:00
Lawrence Forman
20d8c1b51a
In @0x/contracts-exchange
: Update tests for rich reverts
2019-07-23 15:17:56 -07:00
Lawrence Forman
4408604c2d
In @0x/contracts-exchange
: upgrading tests...
2019-07-23 15:17:56 -07:00
Lawrence Forman
b8f056b82f
Update coordinator
, exchange-forwarder
, exchange-libs
, exchange
, and extensions
contract tests to use new order and transaction structure
2019-07-23 15:08:00 -07:00