Amir Bandeali
d463d4c46b
Add transaction expiration tests
2019-07-23 15:46:15 -07:00
Amir Bandeali
4f818d55fa
Add TransactionExecution log tests
2019-07-23 15:46:15 -07:00
Amir Bandeali
c96a81e319
Fix exchange package build
2019-07-23 15:46:15 -07:00
Lawrence Forman
95e7999e45
@0x/contracts-exchange
: Update settlement test simulators to match settlement optimizations in the Exchange.
2019-07-23 15:46:15 -07:00
Lawrence Forman
2f464ee8f0
@0x/contracts-exchange
: Fix critical error in fillOrder()
and matchOrders()
redundant transfer optimization code.
...
`@0x/contracts-exchange`: Rearrange `Fill` event params to make regular `emit` code work without breaking the stack.
`@0x/contracts-exchange`: Add edge case tests for redundant transfer optimizations.
2019-07-23 15:46:15 -07:00
Lawrence Forman
de896f9159
@0x/contracts-exchange
: Remove TODO
comment in fill_order_combinatorial_utils.ts
.
2019-07-23 15:46:15 -07:00
Lawrence Forman
ee89f74afd
@0x/contracts-exchange
: Avoid redundant transfer in matchOrders()
when maker/feeRecipient and takerAssetData/makerFeeAssetData are the same.
...
`@0x/conracts-exchange`: Disable combinatorial tests by default. Can be run by setting env var `TEST_ALL=1`.
2019-07-23 15:46:15 -07:00
Lawrence Forman
cd08c3e8fa
@0x/contracts-exchange
: Avoid redundant trasfer in fillOrder()
when maker/taker is the same as feeRecipient and the assets match.
...
`@0x/contracts-exchange`: Swap fill order in `fillOrder()` from maker -> taker to taker -> maker first
2019-07-23 15:46:15 -07:00
Lawrence Forman
91c27ff972
@0x/contracts-exchange
: Fix build error.
2019-07-23 15:46:15 -07:00
Lawrence Forman
07e3ba014c
@0x/contracts-exchange
: Fully incorporate ERC1155 and MultiAsset tests into the fillOrder
and matchOrders
test suites.
2019-07-23 15:46:15 -07:00
Lawrence Forman
816368b1fe
@0x/contracts-exchange
: Re-eanble all exchange tests.
...
`@0x/contracts-echange`: Set up 1155 and MAP proxies for `matchOrders()` tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
85ea291745
@0x/contracts-exchange
: Add MultiAssetProxy
, ERC1155Fungible
, and ERC1155NonFungible
combinatorial tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
518f351235
@0x/contracts-exchange
: Correct coding convention in match_orders.ts
2019-07-23 15:44:58 -07:00
Lawrence Forman
f7f55cad43
@0x/contracts-exchange
: Removed dependency on OrderValidationUtils. The tests using it didn't really warrant the full validation suite.
...
`@0x/contracts-test-utils`: Move all the `OrderScenario` related types into the `contracts-exchange` package because no one else is using them.
2019-07-23 15:43:23 -07:00
Lawrence Forman
53ff248176
@0x/contracts-exchange
: Revert internal tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
aebb923c2d
@0x/contracts-exchange
: Major rework of fill_order_combinatorial_utils
.
...
`@0x/contracts-exchange`: Add more arbitrary fee token tests.
`@0x/contracts-exchange`: Fix broken tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
d11444b983
@0x/contracts-exchange
: Fix Exchange Wrappers tests.
2019-07-23 15:26:59 -07:00
Lawrence Forman
0508a45681
@0x/contracts-echange
: Fix transactions test bug with ExchangeWrapper
example due to deduping.
2019-07-23 15:26:59 -07:00
Lawrence Forman
9d257497bd
Ran prettier and fixed linter errors
2019-07-23 15:23:40 -07:00
Lawrence Forman
79f40b4ce0
@0x/contracts-exchange
: Enable all exchange tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
1ab62b7a80
@0x/contracts-exchange
: Fix broken match orders tests
2019-07-23 15:23:40 -07:00
Lawrence Forman
d2f10d5834
@0x/contracts-exchange
: Allow custom ExchangeWrapper.matchOrders()
call in MatchOrdersTester
.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c326ec9d1e
@0x/contracts-exchange
: Rewrote MatchOrderTester
class to be simpler and more flexible.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c84a0b8415
@0x/contracts-exchange
: Fix matchOrders
and signature tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
be5336d074
@0x/contracts-exchange
: Enable all tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
aecb2efad9
@0x/contracts-exchange
: Fix combinatorial fillOrder
test bugs.
...
`@0x/contracts-exchange`: Fix emit `Fill` event code.
2019-07-23 15:23:40 -07:00
Lawrence Forman
8aa3b535f0
@0x/contracts-exchange
: Update fill order tests for arbitrary fee tokens. (Still more to do)
2019-07-23 15:23:40 -07:00
Amir Bandeali
051997acb0
Fix linting errors
2019-07-23 15:23:40 -07:00
Amir Bandeali
51ef0e1e6d
Add tests for cancelOrderNoThrow and batchCancelOrdersNoThrow
2019-07-23 15:23:40 -07:00
Amir Bandeali
ed0fcf2829
Remove LibAbiEncoder
2019-07-23 15:23:40 -07:00
Amir Bandeali
6b40812e6d
Fix incorrect CancelUpTo event args
2019-07-23 15:21:14 -07:00
Amir Bandeali
3e461ac2e5
Rename internal and private functions
2019-07-23 15:21:14 -07:00
Lawrence Forman
46af2ffcea
In @0x/contracts-exchange
: Merge new transaction tests from rebase.
2019-07-23 15:21:14 -07:00
Lawrence Forman
61bdbd2d74
Rebased against 3.0
.
...
Run prettier/linter.
2019-07-23 15:21:14 -07:00
Lawrence Forman
a1293f160f
In @0x/contracts-exchange
: Remove only
from lib_exchange_rich_error_decoder
tests.
2019-07-23 15:21:14 -07:00
Lawrence Forman
847503bff1
In @0x/contracts-exchange
: Add more tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
576242551f
In @0x/contracts-exchange
: Add more tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdb6bee65f
In @0x/contracts-exchange
: Add tests for LibExchangeRichErrorDecoder
.
2019-07-23 15:21:14 -07:00
Lawrence Forman
d942c47f08
In @0x/contracts-exchange
: Change parameter order and naming of some rich revert errors.
...
In `@0x/order-utils`: Change parameter order for `OrderStatusError`.
2019-07-23 15:21:14 -07:00
Lawrence Forman
fdaee1375c
In @0x/contracts-exchange
: Update tests for rich reverts
2019-07-23 15:21:14 -07:00
Lawrence Forman
d25a510291
In @0x/contracts-exchange
: upgrading tests...
2019-07-23 15:21:14 -07:00
Amir Bandeali
f1a78682aa
Add batch fill method tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
dc4bfde76d
Fix linting errors
2019-07-23 15:21:14 -07:00
Amir Bandeali
e717625f86
Add batchExecuteTransactions tests
2019-07-23 15:21:14 -07:00
Amir Bandeali
41444e7ede
Refactor transaction tests to iclude more combinations and to cover all revert cases
2019-07-23 15:21:14 -07:00
Amir Bandeali
fc2a59ceaa
Update imports in tests
2019-07-23 15:21:13 -07:00
Amir Bandeali
72f4b216c1
Move exchange specific types. constants, and utils into exchange package
2019-07-23 15:21:13 -07:00
Amir Bandeali
24906138c7
Make preSign compatible with executeTransaction
2019-07-23 15:19:33 -07:00
Amir Bandeali
6fc30d31bf
Fix missed conflicts and rebuild
2019-07-23 15:18:26 -07:00
Lawrence Forman
0bcd47b394
Add OrderValidator and WalletOrderValidator signature strategies to Exchange ( #1774 )
...
* In `@0x/contracts-exchange`: Add `SignatureType.OrderValidator` support to contracts and refactor signature validation functions.
* In `@0x/types`: Add `SignatureType.OrderValidator` and `RevertReason.InappropriateSignature`.
* In `@0x/contracts-exchange`: Fix contracts and update tests for `SignatureType.OrderValidator`.
* Ran prettier/linter
* Update changelogs
* In `@0x/order-utils`: Add `SignatureOrderValidatorError` to `ExchangeRevertErrors`.
* In `@0x/contracts-exchange`: Add `SignatureOrderValidatorError` rich revert. Fix rebase issues. Rename `IValidator.isValidOrder` to `IValidator.isValidOrderSignature`.
* In `@0x/contracts-exchange`: Add revert test cases for `OrderValidator` signature type.
* In `@0x/order-utils`: Update changelog.
* In `@0x/contracts-exchange`: Split off `SignatureType.OrderValidator` scheme into its own interface and registry.
* In `@0x/types`: Add `SignatureType.WalletOrderValidator`.
* In `@0x/order-utils`: Add `SignatureWalletOrderValidatorError`.
* In `@0x/contracts-exchange`: Add `SignatureType.WalletOrderValidator` support.
* Ran prettier
* In `@0x/types`: Remove `RevertReason.WalletOrderValidator`.
* Update/fix changelogs in `@0x/contracts-exchange`, `@0x/order-utils`, and `@0x/types`.
* In `@0x/contracts-exchange`: Make `isValidOrderSignature` `external` instead of `public`.
* In `@0x/contracts-exchange`: Change `isValidOrderSignature` back to `public` because passing `calldata` to internal functions isn't supported.
2019-07-23 15:18:26 -07:00