Amir Bandeali
dcff7d511b
Add tests for detachProtocolFeeCollector
2019-10-27 11:41:06 -07:00
Amir Bandeali
16a5475d24
Add detachProtocolFeeCollector function (in order to have a separate timelock for detaching)
2019-10-27 11:40:28 -07:00
Amir Bandeali
9312d5d9f7
remove read-only mode related code from integrations
2019-10-27 11:12:22 -07:00
Amir Bandeali
33a0c22021
Remove tests related to read-only mode
2019-10-27 11:12:22 -07:00
Amir Bandeali
58e9c70203
Remove read-only mode related functions, storage variables, and contracts
2019-10-27 11:12:16 -07:00
F. Eugene Aumson
0067f10a6a
@0x/utils: fix wrong RPC method in getChainIdAsync() ( #2270 )
...
It was using net_version, but it should be using the eth_chainId method
introduced in EIP-695. I'm not sure whether/how the network ID differs
from the chain ID on mainnet and the testnets, but in Ganache in
particular, the network ID is 50 while the chain ID is 1337, and this
difference was causing problems for Python tests. Specifically, the
Web3.py interface `Web3.eth.chainId` invokes the eth_chainId method, and
the result feeds into the order hash, which wasn't lining up with the
non-Python side of things.
2019-10-25 21:08:31 -04:00
Lawrence Forman
1c695b2759
Rebase onto 3.0
2019-10-25 10:56:03 -04:00
Lawrence Forman
c7222c17ae
@0x/contracts-test-utils
: prettier
2019-10-25 10:55:03 -04:00
Lawrence Forman
0f237d22f9
@0x/contracts-test-utils
: Refactor verifyEvents()
to just use verifyEventsFromLogs()
.
2019-10-25 10:55:03 -04:00
Lawrence Forman
b1b1162b60
@0x/contracts-staking
: Add MixinStakingPool
unit tests.
2019-10-25 10:55:03 -04:00
Lawrence Forman
6ee1605a77
@0x/contracts-test-utils
: Add verifyEventsFromLogs()
.
2019-10-25 10:54:38 -04:00
Greg Hysen
8e8ea6a3ab
Created IZrxVaultBackstop and updated IStaking.
2019-10-24 15:58:51 -07:00
Greg Hysen
cc7452da8f
Replaced protocolFeePaid
-> protocolFeeAmount
. Changed some wording in comments.
2019-10-24 15:58:18 -07:00
Amir Bandeali
281658ba34
Rename withdrawTo to bridgeTransferFrom
2019-10-23 09:42:37 -07:00
Lawrence Forman
07e1d502e7
@0x/contracts-staking
: Update changelog.
2019-10-23 04:40:47 -04:00
Lawrence Forman
703e890918
@0x/contracts-staking
: Call StakingProxy.assertValidStorageParams()
in MixinParams.setParams()
2019-10-23 04:40:47 -04:00
Michael Zhu
8869d79c68
rebase
2019-10-22 17:05:08 -07:00
Michael Zhu
752dd04546
address comments
2019-10-22 17:05:08 -07:00
Michael Zhu
3e5d166ec4
moving away from extending DeploymentManager in case we want to deploy multiple extensions alongside one another
2019-10-22 17:05:08 -07:00
Michael Zhu
64bc1b0990
update coordinator tests to use deployment manager, balance stores, actor mixins
2019-10-22 17:05:08 -07:00
Michael Zhu
548b0db6ea
coordinator deployment manager
2019-10-22 17:05:08 -07:00
Greg Hysen
c676ecb8cf
Force no-op when moving zero stake or moving from undelegated to undelegated.
2019-10-22 15:39:24 -07:00
Alex Towle
1a1dc89454
CI
Fix build failure
2019-10-22 14:53:13 -07:00
James Towle
e427698956
Merge pull request #2252 from 0xProject/feature/sandstorm/function-assertions
...
Initial Sandstorm Framework
2019-10-22 13:45:42 -07:00
Greg Hysz
575af6b6e8
Merge pull request #2278 from 0xProject/fix/3.0/removeProtocolFeeZeroAssertion
...
Remove assertion that protocol fee != zero
2019-10-22 13:24:59 -07:00
Alex Towle
3a1fc9ee5f
@0x:contracts-integrations
Fixed package after rebase
2019-10-22 13:15:01 -07:00
mzhu25
1237c7d479
Merge pull request #2277 from 0xProject/fix/3.0/rmeove-staking-fallback
...
Remove payable fallback from Staking.sol
2019-10-22 12:46:13 -07:00
Greg Hysen
c44e16a88f
Removed assertion that protocol fee != 0 from staking contract.
2019-10-22 12:42:04 -07:00
Greg Hysz
06c180475e
Merge pull request #2276 from 0xProject/cleanup/staking/finalizationDataStructures
...
Refactored finalization state.
2019-10-22 12:37:50 -07:00
Michael Zhu
74a2c3a199
Remove payable fallback from Staking.sol
2019-10-22 12:15:07 -07:00
Greg Hysen
9ac715f99d
Protocol fee amount is not enforced by staking contract
2019-10-22 12:10:34 -07:00
Greg Hysen
22e39f782f
Some (more) readability improvements and minor optimizations to staking finalization.
2019-10-22 12:09:18 -07:00
Alex Towle
718407ba6f
@0x:contracts-integrations
Switched to object destructuring in the function assertion unit test
2019-10-22 12:07:50 -07:00
Alex Towle
e603a81a46
@0x:contracts-integrations
Simplified the tests
2019-10-22 12:07:50 -07:00
Alex Towle
03e35846fb
@0x:contracts-integrations
Removed the Cache
2019-10-22 12:07:50 -07:00
Alex Towle
c87364f86b
@0x:contracts-integrations
Addressed more review feedback
2019-10-22 12:07:50 -07:00
Alex Towle
a794a33551
@0x:contracts-integrations
Addressed review comments
2019-10-22 12:06:38 -07:00
Alex Towle
494b437f1a
@0x:contracts-integrations
Renamed some functions in Address Manager
2019-10-22 12:04:47 -07:00
Alex Towle
92b80fc436
@0x:contracts-integrations
Improved the caches
2019-10-22 12:04:47 -07:00
Alex Towle
d66101cd9d
@0x:contracts-integrations
Added unit tests for FunctionAssertion
2019-10-22 12:04:47 -07:00
Alex Towle
89ae04803f
@0x:contract-integrations
Added the integrations package to CI
2019-10-22 12:01:54 -07:00
Alex Towle
be95bce4cd
@0x:contract-integrations
Move caches to a new file
2019-10-22 12:01:30 -07:00
Alex Towle
01aee08c02
@0x:contracts-integrations
Wrote a simple integration test and AddressManager
2019-10-22 12:01:30 -07:00
Alex Towle
6cba9fd77f
@0x/contracts-integrations
Created the FunctionAssertion class and examples
2019-10-22 11:59:17 -07:00
mzhu25
673d45361f
Merge pull request #2273 from 0xProject/refactor/integrations/coordinator-tests
...
Coordinator test refactor [1/2] + actor mixin pattern
2019-10-22 11:37:02 -07:00
Greg Hysen
d91a7fc663
Some readability improvements and minor optimizations to staking finalization.
2019-10-22 11:02:25 -07:00
Greg Hysen
ce8fd44234
Removed lingering references to stale terminology ("active pools")
2019-10-22 11:02:25 -07:00
Greg Hysen
6617ad9531
Refactored finalization state.
...
1. Removes state variables:
- totalWeightedStakeThisEpoch
- totalFeesCollectedThisEpoch
- numActivePoolsThisEpoch
2. No longer indexes by epoch % 2
3. Renamed event StakingPoolActivated → StakingPoolEarnedRewards.
4. Renamed structs:
- ActivePool → PoolStats. This holds stats for a pool that earned rewards.
- UnfinalizedState → AggregatedStats. This aggregates stats from the former struct.
2019-10-22 11:02:25 -07:00
Amir Bandeali
e7dc7167d0
Sync delegatedStakeToPoolByOwner whenever _withdrawAndSyncDelegatorRewards is called
2019-10-22 09:38:18 -07:00
Amir Bandeali
359b804001
Add test for withdrawing rewards before epoch is finalized
2019-10-21 22:27:06 -07:00