Greg Hysen
f697814849
First balance test with intentional values
2018-08-24 18:18:30 -07:00
Greg Hysen
ca5c9e77c0
Ironing out the new set of test cases for order matchubng
2018-08-24 18:17:27 -07:00
Greg Hysen
a32b201afe
Rounding for fees in match orders addressed, plus example
2018-08-24 18:17:27 -07:00
Greg Hysen
0ecdf1e213
All existing tests pass.
2018-08-24 18:17:26 -07:00
Amir Bandeali
c28c3db63f
Only use one nonReentrant modifier, remove modifier from fillOrderNoThrow variations
2018-08-24 17:30:56 -07:00
Amir Bandeali
a09ee90739
Add tests for matchOrders
2018-08-24 17:30:56 -07:00
Amir Bandeali
7d5a23969d
Add reentrancy tests for fillOrder and wrapper functions
2018-08-24 17:30:56 -07:00
Amir Bandeali
74ce893f52
Merge pull request #1003 from 0xProject/feature/contracts/roundup
...
[contracts] Add getPartialAmountCeil and isRoundingErrorCeil
2018-08-24 17:29:09 -07:00
Amir Bandeali
cc1fac9bbe
Fix linting errors
2018-08-24 17:02:42 -07:00
Remco Bloemen
80291caf7c
Append -Floor to getPartialAmount and isRoundingError
2018-08-24 16:16:44 -07:00
Greg Hysen
a27112cbef
SignatureType.Trezor -> SignatureType.EthSign in Signature Validator tests
2018-08-24 14:40:00 -07:00
Greg Hysen
bb4d449e92
Test case for Trezor Model T signature
2018-08-24 14:40:00 -07:00
Greg Hysen
241534a63d
Fixed trezor personal message in client+contracts; added a test using message signed by Trezor One (firmware v1.6.2)
2018-08-24 14:40:00 -07:00
Amir Bandeali
1932aff35c
Remove Trezor SignatureType
2018-08-24 14:40:00 -07:00
Amir Bandeali
8ce4f9c784
Remove SignatureType.Caller
2018-08-24 14:39:08 -07:00
Remco Bloemen
7f78d7da9d
Add tests
2018-08-24 14:09:51 -07:00
Remco Bloemen
4219af1430
Add DIVISION_BY_ZERO to getPartialAmount for consistency
2018-08-24 14:09:51 -07:00
Remco Bloemen
c109d1f545
Remove .only
2018-08-24 14:09:51 -07:00
Remco Bloemen
3dad6ee55e
Add tests for getPartialAmountCeil
2018-08-24 14:09:51 -07:00
Amir Bandeali
6a9669a409
Rethrow Wallet and Validator errors
2018-08-24 14:06:46 -07:00
Remco Bloemen
4159e45aff
Update tests
2018-08-24 13:45:10 -07:00
Amir Bandeali
070eff6f3a
Rename TestStaticCall => TestStaticCallReceiver
2018-08-24 13:32:04 -07:00
Amir Bandeali
681ed822ec
Revert if undefined function called in AssetProxies
2018-08-24 13:19:07 -07:00
Amir Bandeali
0a1ae2c311
Remove pragma experimental v0.5.0 and use staticcall is assembly
2018-08-24 13:19:07 -07:00
Amir Bandeali
c5f8b9c2d2
Add pragma experimental v0.5.0 to SignatureValidator and add tests
2018-08-24 13:19:07 -07:00
Fabio Berger
b7c119b2aa
Fix many linter errors that showed up upon upgrading tsutil
2018-08-22 18:52:17 +01:00
Fabio Berger
0248add542
Merge development branch
2018-08-22 11:41:42 +01:00
Amir Bandeali
3760eb5baf
Add getBalancesAndAllowances
2018-08-21 18:14:22 -07:00
Fabio Berger
301cb296ec
Move types from sol-compiler to types so they can be used in other places without requiring sol-compiler as a dep
2018-08-21 23:58:06 +01:00
Amir Bandeali
7fa5b474eb
Add ZRX balances and allowances to TraderInfo
2018-08-21 13:53:44 -07:00
Amir Bandeali
dafb282432
Add tests
2018-08-21 11:47:28 -07:00
Amir Bandeali
1ba26ea5e8
Remove redundant constructor args
2018-08-21 10:59:54 -07:00
Amir Bandeali
8bce73dc67
Fix typos, run prettier, and allow anyone to call on DummyERC721Token
2018-08-16 17:32:16 -07:00
Amir Bandeali
09d3d15db0
Fix Geth tests
2018-08-16 17:31:21 -07:00
Amir Bandeali
633e6c38c8
Fix linting errors
2018-08-16 17:31:21 -07:00
Amir Bandeali
a4d6bc3190
Fix tests that assumed logs were being filtered
2018-08-16 17:31:21 -07:00
Amir Bandeali
0b9a9d92af
Add tests for ERC721Token
2018-08-16 17:31:21 -07:00
Amir Bandeali
4dd59a370d
Add tests for ERC20 token with no return values
2018-08-16 17:31:21 -07:00
Amir Bandeali
7a6e647386
Add constructor back to DummyERC721Token
2018-08-16 17:31:21 -07:00
Amir Bandeali
2743eee044
Update checking for erc721 existence
2018-08-16 17:31:21 -07:00
Fabio Berger
68d7eb5712
Fix comment
2018-08-16 17:02:47 -07:00
Fabio Berger
0337b5a401
Merge development
2018-08-16 15:10:12 -07:00
Jacob Evans
622509c508
[Order-utils] Order is valid when maker amount is very small
...
Previously our min fillable calculation would throw a rounding error
when encountering a valid order (with a small maker amount). This was
inconsistent with the on-chain logic which allowed this order to be
filled.
2018-08-15 13:06:32 +10:00
Fabio Berger
2f2582a0da
Merge development
2018-08-14 14:21:47 -07:00
Jacob Evans
e51deb93ee
Merge pull request #914 from 0xProject/feature/0x.js/ec-signature-string
...
0x.js Return signature as a hex encoded string
2018-08-14 09:36:11 +10:00
Jacob Evans
ca4905c343
Rename from SignerProviderType.EthSign to SignerType.Default
2018-08-11 18:27:21 +10:00
Amir Bandeali
1b5c5e7a3b
Change withdrawERC20 => withdrawAsset, reuse transfer logic
2018-08-09 14:07:27 -07:00
Amir Bandeali
b9d8d2d5e3
Make marketBuy functions revert if entire amount not filled
2018-08-09 11:26:32 -07:00
Amir Bandeali
b60a74c8bc
Merge pull request #941 from 0xProject/feature/contracts/returnValuesTests
...
[contracts] Test fillOrder return values and abiEncodeFillOrder
2018-08-09 10:39:14 -07:00
Jacob Evans
45e9fbe8f9
Introduce SignerProviderType
...
This allows the developer to indicate the nuanced signer provider. Some have different implementations (trezor, ledger) and others have different implementations (metamask). Breaking the abstraction of eth_sign. EthSign assumes a spec compliant implementation and can be used as a default
2018-08-09 12:02:12 +10:00