Amir Bandeali
654698b208
Merge pull request #571 from 0xProject/feature/contracts/proxyOwner
...
Update MultiSigWalletWithTimeLockExceptRemoveAuthorizedAddress
2018-05-24 17:24:52 -07:00
Fabio Berger
35121f0b78
Merge branch 'v2-prototype' into feature/contracts/eip712-order-hash
...
* v2-prototype:
Temporarily disable installation tests
Pin connect in sra-report
Fix a typo
Pin types in sra-report
Fix linter issues
Unpin types version in @0xproject/connect
Pin types version in website
Do a fake version bump on types so that yarn doesn't try to install updated version for not yet migrated packages
Migrate migrations to v2
# Conflicts:
# packages/contracts/src/utils/order_utils.ts
2018-05-24 16:30:30 -07:00
Jacob Evans
3cc8af819c
Use domain separator for exchange address
2018-05-24 16:00:22 -07:00
Jacob Evans
fcf4a958c3
publicGetOrderSchemaHash -> getOrderSchemaHash
2018-05-24 16:00:22 -07:00
Jacob Evans
65676c22f9
Update order hash to match latest eip712
2018-05-24 16:00:22 -07:00
Amir Bandeali
237ebb0716
Use web3-wrapper instead of 0x.js, update logDecoder
2018-05-24 15:39:19 -07:00
Amir Bandeali
fdea260e41
Cleanup tests
2018-05-24 15:39:19 -07:00
Amir Bandeali
d4aacd218a
Move readFirst4 to LibBytes
2018-05-24 15:39:19 -07:00
Amir Bandeali
326a566db2
Add old MultiSig to previous contracts, cleanup file structure
2018-05-24 15:39:19 -07:00
Amir Bandeali
84257dac2b
Fix build
2018-05-24 15:39:19 -07:00
Amir Bandeali
22ad9e1e1a
Address feedback, rename contract to AssetProxyOwner
2018-05-24 15:39:19 -07:00
Amir Bandeali
cc44f5f75d
Update multisig tests and utils
2018-05-24 15:39:19 -07:00
Amir Bandeali
23df5cc201
Update MultiSigWalletWithTimeLockExceptRemoveAuthorizedAddress to use a mapping of registered proxies
2018-05-24 15:39:19 -07:00
Leonid Logvinov
ea3f82ccc2
Fix linter issues
2018-05-24 14:56:20 -07:00
Leonid Logvinov
92b0efff5a
Migrate migrations to v2
2018-05-24 13:59:30 -07:00
Alex Browne
b05a3b7aed
Check transaction receipt status codes where applicable
2018-05-23 15:09:17 -07:00
Leonid Logvinov
6a77e0fe56
Move contract utils
2018-05-23 10:32:14 -07:00
Leonid Logvinov
0a725415a4
Merge branch 'v2-prototype' into feature/truffle-sol-cov
2018-05-23 10:19:10 -07:00
Leonid Logvinov
06be580d2c
Fix a bug in CALL-like opcode handling
2018-05-22 15:27:17 -07:00
Leonid Logvinov
1ff34bd0f4
Remove web3Factory.create and remove dev-tools dependency on sol-cov
2018-05-22 15:20:34 -07:00
Fabio Berger
9de9bf651b
Fix ExchangeWrapper
2018-05-22 13:15:01 -07:00
Fabio Berger
09d80b1e50
Fix imports
2018-05-22 13:14:38 -07:00
Fabio Berger
2b793f372a
Merge branch 'v2-prototype' into refactor/contracts/remove0xjsDep
...
* v2-prototype:
Fix tslint issues
Add `are` to boolean naming conventions
Fix tslint
Fix the tsutils version, fixing ts typings issue
Rename some variables in multi_sig_with_time_lock.ts
Remove extra awaitTransactionMinedAsync calls
Update artifacts
Update yarn.lock
Fix warnings in Metacoin
Upgrade UglifyJS to include ES6 support
Add CancelOrder and MatchOrder types
Add missing return types
Ignore classnames linter rule
Apply changes to test/exchange/match_orders.ts
Fix some unhandled promise rejections
Add awaitTransactionMinedAsync after every sent transaction
Add missing blockchainLifecycle calls to contracts tests
# Conflicts:
# packages/contracts/src/utils/exchange_wrapper.ts
# packages/contracts/test/asset_proxy/proxies.ts
# packages/contracts/test/exchange/dispatcher.ts
# packages/contracts/test/multi_sig_with_time_lock.ts
2018-05-22 13:02:21 -07:00
Alex Browne
cde85243d6
Merge pull request #601 from 0xProject/contracts-test-fixes
...
Contracts test fixes
2018-05-22 11:48:41 -07:00
Fabio Berger
a682b5d90e
Remove 0x.js dep from contracts
2018-05-22 11:18:50 -07:00
Remco Bloemen
b39f75a2e3
Add CancelOrder and MatchOrder types
2018-05-22 15:15:14 +02:00
Remco Bloemen
1dad14f8ea
Add missing return types
2018-05-22 13:50:07 +02:00
Alex Browne
2c496a92ad
Add awaitTransactionMinedAsync after every sent transaction
2018-05-21 16:52:49 -07:00
Greg Hysen
f4ebbfabf4
Added getNullFillResults
2018-05-18 17:07:00 -07:00
Greg Hysen
b5bcfc8fe7
orderFilledAmount -> orderTakerAssetFilledAmount
2018-05-18 17:07:00 -07:00
Greg Hysen
d13c08cc0d
Style improvements to order matching
2018-05-18 17:07:00 -07:00
Greg Hysen
89abd76570
Upgraded to Solidity 0.4.24
2018-05-18 17:07:00 -07:00
Greg Hysen
8c1ae35088
Rebased against v2-prototype
2018-05-18 17:05:36 -07:00
Greg Hysen
bb74789b42
Changed calculateFillResults to public visibility so that it can be used by the Forwarding Contract.
2018-05-18 17:01:06 -07:00
Greg Hysen
80285a300d
Wording of calculateMatchedFillResults
2018-05-18 17:01:06 -07:00
Greg Hysen
2eb5819851
Cleaned up interface for decoding proxy data. Added a general decoder, which should be useful for the forwarding contract code.
2018-05-18 17:01:06 -07:00
Greg Hysen
28bb11217c
Removed redundant log decode call
2018-05-18 17:01:06 -07:00
Greg Hysen
636dae6a79
The OrderInfo struct is now returned by the getOrderInfo function
2018-05-18 17:01:06 -07:00
Greg Hysen
c8f65a1bf9
Updated order of settleMatchedOrders to align with settleOrder
2018-05-18 17:01:06 -07:00
Greg Hysen
ce177ae6f6
IExchange inherits from all other interfaces (in the same order as Exchange inherits Mixins)
2018-05-18 17:01:06 -07:00
Greg Hysen
c79f3501cd
Renamed takerAssetFilledAmount to orderFilledAmount to more easily distinguish between fill results and order state
2018-05-18 17:01:06 -07:00
Greg Hysen
80114edc71
Comments for readability in exchange core and mixin match orders
2018-05-18 17:01:06 -07:00
Greg Hysen
71483e2865
Renamed "validate" functions to "assert" in mixin match.
2018-05-18 17:01:06 -07:00
Greg Hysen
93087324d9
Throw if the left or right orders do not compute the correct fill results. I like this better than just logging an error and failing silently.
2018-05-18 17:01:06 -07:00
Greg Hysen
061facdcce
Removed redundant status checks in matchOrders. Saves gas, plus follows pattern of fillOrder more closely.
2018-05-18 17:01:06 -07:00
Greg Hysen
3e6e7fb272
Token -> Asset in fillOrder spec
2018-05-18 17:01:06 -07:00
Greg Hysen
12d8c2398f
Reordered functions in mixin exchange core -- getOrderInfo is at the bottom
2018-05-18 17:01:06 -07:00
Greg Hysen
bb73963421
Changes based on style guidelines put out by Amir
2018-05-18 17:01:06 -07:00
Greg Hysen
1dd7688bdd
Reordered fund transfers for matched orders, plus added an extra sanity check to order matching calculations
2018-05-18 17:01:06 -07:00
Greg Hysen
5735095521
Style changes to atomic order matching
2018-05-18 17:01:06 -07:00