Amir Bandeali
070147db52
Fix build errors
2019-08-13 16:43:55 -07:00
Amir Bandeali
dc31294440
Move LibExchangeRichErrors to exchange-libs package
2019-08-13 16:20:35 -07:00
Amir Bandeali
d3b8070fd6
Fix TestValidatorWallet by using new LibOrder and LibZeroExTransaction hashing
2019-08-13 16:19:48 -07:00
Amir Bandeali
26e4d66163
Remove unimplemented functions from interface
2019-08-13 16:19:48 -07:00
Amir Bandeali
0e2616f16b
Rename _rrevert to rrevert
2019-08-13 16:19:48 -07:00
Amir Bandeali
ccce7e001e
Compile all contracts by default, regenerate boilerplate
2019-08-13 16:19:48 -07:00
Amir Bandeali
d6772b4a0a
Fix linting errors
2019-08-13 16:11:57 -07:00
Amir Bandeali
5016d50c2b
Move calculateFillResults tests to exchange-libs package
2019-08-13 16:11:09 -07:00
Amir Bandeali
31c2b36039
Fix build errors in exchange package contracts
2019-08-13 16:11:09 -07:00
Amir Bandeali
9b786df828
Update test contracts
2019-08-13 16:11:09 -07:00
Amir Bandeali
ae859fa01e
Update Exchange contract to use libraries
2019-08-13 16:11:09 -07:00
Amir Bandeali
a8cd168345
Cleanup imports
2019-08-13 16:09:48 -07:00
Amir Bandeali
b05a2a90d0
Move FillResults calculations into LibFillResults
2019-08-13 16:09:48 -07:00
Amir Bandeali
242715240b
Do not inherit libs
2019-08-13 16:07:07 -07:00
Amir Bandeali
7d5276ad11
Remove LibExchangeSelectors.sol
2019-08-13 16:04:33 -07:00
Lawrence Forman
fc18db10be
@0x/contracts-exchange
: Add tests for when callback signature types return incorrect data.
2019-08-12 19:10:24 -04:00
Lawrence Forman
9382e2e8c7
@0x/contracts-exchange
: Fix bad resultData
assertion in fillOrderNoThrow()
.
2019-08-12 18:53:40 -04:00
Lawrence Forman
a3b2dbf8e2
@0x/contracts-exchange
: Remove redundant new bytes(0)
in ReentrancyTester.sol
.
2019-08-12 18:32:05 -04:00
Lawrence Forman
6df190edbb
@0x/contracts-exchange
: Light changes to address PR comments.
2019-08-12 18:20:50 -04:00
Lawrence Forman
5b0b8a9717
@0x/contracts-exchange
: Remove explicit signerAddress
parameter from many MixinSignatureValidator
functions.
2019-08-12 18:10:57 -04:00
Lawrence Forman
a8ddbe4127
@0x/contracts-exchange
: Update IWallet
for new legacy wallet spec.
2019-08-12 17:30:24 -04:00
Lawrence Forman
ca33090793
@0x/contracts-exchange
: Add comments to LEGACY_WALLET_MAGIC_VALUE
constant in TestValidatorWallet.sol
.
...
`@0x/contracts-exchange`: Remove references to `LibExchangeSelectors` in the Exchange.
2019-08-09 22:15:33 -04:00
Lawrence Forman
370df0d495
@0x/contracts-dev-utils
: Prettier.
...
`@0x/contracts-exchange`: Update reentrancy tests.
`@0x/contracts-exchange`: Add all mutator functions to
`ExchangeFunctions` type.
`@0x/contracts-tes-utils`: Remove unused import.
2019-08-09 22:15:33 -04:00
Lawrence Forman
d4e300d0a4
@0x/contracts-dev-util
: Remove references to marketXOrdersNoThrow
.
...
`@0x/contracts-exchange`: Remove references to `marketXOrdersNoThrow`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c83864af9c
@0x/contracts-exchange
: Fix broken tests.
...
`@0x/contracts-test-utils`: Remove unecessary wait timeout in
`LogDecoder`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
b1778825cb
@0x/contracts-exchange
: Remove ReentrantERC20Token
from compiler
...
config.
2019-08-09 22:15:33 -04:00
Lawrence Forman
cc8d5ac93a
Update changelogs.
2019-08-09 22:15:33 -04:00
Lawrence Forman
a2234b745c
@0x/contracts-exchange
: Create semi-automated reentrancy testing.
...
`@0x/contracts-exchange`: Remove old reentrancy tests.
`@0x/contracts-exchange`: Remove `ReentrantERC20Token` contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
3dd8dac146
@0x/contracts-exchange
: Update Wallet
signature type behavior to match v2.1.
...
`@0x/contracts-exchange`: Add EOA tests to `signature_validator`.
2019-08-09 22:15:33 -04:00
Lawrence Forman
0d05411cd2
@0x/contracts-exchange
: Update CHANGELOG, lint, prettify.
2019-08-09 22:15:33 -04:00
Lawrence Forman
7ce65e3cfe
@0x/contracts-exchange
: Wrap up tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ea1501abd1
@0x/contracts-exchange
: Change how order hashes and signatures are computed for wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ca28b8f93e
@0x/contracts-exchange
: Make marketBuy/SellNoThrow
the default.
...
`@0x/contracts-exchange`: Add more `wrapper_unit_tests` tests.
2019-08-09 22:15:33 -04:00
Lawrence Forman
566e74310a
@0x/contracts-exchange
: Remove assembly from fillOrderNoThrow()
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
c18e8ba242
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
1f3f0dce11
@0x/contracts-exchange
: Add fillOrderNoThrow
tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
b73008d83d
@0x/contracts-exchange
: Fix fillOrKillOrder()
tests in wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
10a8291391
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
ab094ab174
@0x/contracts-exchange
: Add more tests to wrapper_unit_tests
.
2019-08-09 22:15:33 -04:00
Lawrence Forman
29a82f8471
@0x/contracts
: Create TestWrapperFunctions
contract.
2019-08-09 22:15:33 -04:00
Lawrence Forman
e3aa76cd09
@0x/contracts-exchange
: Light refactoring in
...
`isolated_fill_order.ts` and `isolated_exchange_wrapper.ts`.
2019-08-08 11:43:55 -04:00
Lawrence Forman
6d502b6898
@0x/contracts-exchange
: Use TransactionHelper
to call and execute
...
contract functions.
2019-08-06 15:31:30 -04:00
Lawrence Forman
b6dfc791d4
@0x/contracts-exchange
: Correct test case name.
2019-08-06 15:31:30 -04:00
Lawrence Forman
7002dc63bd
@0x/contracts-exchange
: Fix typos in comments.
2019-08-06 15:31:30 -04:00
Lawrence Forman
fddbfc2d32
Update CHANGELOGs
2019-08-06 15:31:30 -04:00
Lawrence Forman
6345faa4a9
`@0x/contracts-exchange-libs: Appease the linter and prettier gods.
2019-08-06 15:30:59 -04:00
Lawrence Forman
4711ce5532
@0x/contracts-exchange
: Remove _assertValidFill()
.
...
`@0x/contracts-exchange`: Add `_settleOrder()` unit tests.
`@0x/contracts-exchange`: Add explicit tests for
`_calculateFillResults()`.
`@0x/contracts-exchange`: Add overflow tests to `isolated_fill_order`
tests.
`@0x/contracts-exchange`: Add explicit `takerAssetFillAmount = 0` test
to `isolated_fill_order` tests.
2019-08-06 15:30:59 -04:00
Lawrence Forman
afb310e90a
@0x/contracts-exchange
: Update changelog.
2019-08-06 15:30:59 -04:00
Lawrence Forman
51391b7f0e
@0x/contracts-exchange-libs
: Correct internal variable naming in src/index.ts
.
...
`@0x/contracts-utils`: Correct internal variable naming in `src/index.ts`.
`@0x/contracts-exchange`: Remove functions from `TestExchangeInternals.sol` that are now in other packages.
`@0x/contracts-exchange`: Remove `TestExchangeMath.sol`. Exchange math functions are now tested in `@0x/contracts-exchange-libs`.
`@0x/contracts-exchange`: Move `ReferenceFunctions` to default package export.
`@0x/contracts-exchange`: Update `match_order.ts` tests to use reference math functions instead of `TestExchangeMath`.
`@0x/contracts-exchange`: Remove `_updateFilledState()` combinatorial tests in favor of normal unit testing. Combinatorial testing was overkill.
`@0x/contracts-exchange`: Update/refactor `calculateFillResults()` combinatorial tests to use the reference functions and hide them behind `TEST_ALL`.
2019-08-06 15:30:59 -04:00
Lawrence Forman
a3cdb63ae1
@0x/contracts-exchange
: Rename TestIsolatedExchange
to just IsolatedExchange
.
2019-08-06 15:30:30 -04:00