Remco Bloemen
d92fd43791
Update for new assertValidFill signature
2018-08-24 16:46:23 -07:00
Remco Bloemen
e706fa76ac
Add overfill and price assertion to assertValidFill
2018-08-24 16:46:23 -07:00
Remco Bloemen
11328bd93d
Skip self-transfers
2018-08-24 16:26:48 -07:00
Remco Bloemen
bc686fcbf3
Stylistic fixes
2018-08-24 16:17:02 -07:00
Remco Bloemen
80291caf7c
Append -Floor to getPartialAmount and isRoundingError
2018-08-24 16:16:44 -07:00
Amir Bandeali
1932aff35c
Remove Trezor SignatureType
2018-08-24 14:40:00 -07:00
Amir Bandeali
8ce4f9c784
Remove SignatureType.Caller
2018-08-24 14:39:08 -07:00
Remco Bloemen
f6080367fe
Disambiguate the operator precedence
2018-08-24 14:11:45 -07:00
Remco Bloemen
7f78d7da9d
Add tests
2018-08-24 14:09:51 -07:00
Remco Bloemen
6734f2f1bc
Add docs
2018-08-24 14:09:51 -07:00
Remco Bloemen
0fb7617a78
Fix incorect modulus
2018-08-24 14:09:51 -07:00
Remco Bloemen
4219af1430
Add DIVISION_BY_ZERO to getPartialAmount for consistency
2018-08-24 14:09:51 -07:00
Remco Bloemen
50fab9feb3
Improve getPartialAmountCeil docs
2018-08-24 14:09:51 -07:00
Remco Bloemen
3dad6ee55e
Add tests for getPartialAmountCeil
2018-08-24 14:09:51 -07:00
Remco Bloemen
5d70df771b
Add isRoundingErrorCeil
2018-08-24 14:09:50 -07:00
Remco Bloemen
ab5df342e1
Add getPartialAmountCeil
2018-08-24 14:09:50 -07:00
Amir Bandeali
6a9669a409
Rethrow Wallet and Validator errors
2018-08-24 14:06:46 -07:00
Remco Bloemen
e68942ee78
Handle zero case
2018-08-24 13:45:10 -07:00
Remco Bloemen
92497d7df4
Fix isRoundingError
2018-08-24 13:45:10 -07:00
Amir Bandeali
070eff6f3a
Rename TestStaticCall => TestStaticCallReceiver
2018-08-24 13:32:04 -07:00
Amir Bandeali
681ed822ec
Revert if undefined function called in AssetProxies
2018-08-24 13:19:07 -07:00
Amir Bandeali
0a1ae2c311
Remove pragma experimental v0.5.0 and use staticcall is assembly
2018-08-24 13:19:07 -07:00
Amir Bandeali
c5f8b9c2d2
Add pragma experimental v0.5.0 to SignatureValidator and add tests
2018-08-24 13:19:07 -07:00
Amir Bandeali
3760eb5baf
Add getBalancesAndAllowances
2018-08-21 18:14:22 -07:00
Amir Bandeali
7fa5b474eb
Add ZRX balances and allowances to TraderInfo
2018-08-21 13:53:44 -07:00
Amir Bandeali
0918f95421
Don't throw if ERC721 token isn't owned
2018-08-21 11:47:28 -07:00
Amir Bandeali
be67c25b0a
Add OrderValidator contract
2018-08-21 11:47:28 -07:00
Amir Bandeali
1ba26ea5e8
Remove redundant constructor args
2018-08-21 10:59:54 -07:00
Amir Bandeali
8bce73dc67
Fix typos, run prettier, and allow anyone to call on DummyERC721Token
2018-08-16 17:32:16 -07:00
Amir Bandeali
a82e36c1d4
Add ERC721Receiver that returns incorrect value
2018-08-16 17:31:21 -07:00
Amir Bandeali
6dde6d7cb7
Increase max mintable amount
2018-08-16 17:31:21 -07:00
Amir Bandeali
1d70724bcf
Fix DummyERC721Receiver
2018-08-16 17:31:21 -07:00
Amir Bandeali
4dd59a370d
Add tests for ERC20 token with no return values
2018-08-16 17:31:21 -07:00
Amir Bandeali
7a6e647386
Add constructor back to DummyERC721Token
2018-08-16 17:31:21 -07:00
Amir Bandeali
f5459164d2
Restructure directories
2018-08-16 17:31:21 -07:00
Amir Bandeali
bb3c345891
Update ERC20Token
2018-08-16 17:31:21 -07:00
Amir Bandeali
0f3201d72a
Optimize ERC721Token
2018-08-16 17:31:21 -07:00
Amir Bandeali
1b5c5e7a3b
Change withdrawERC20 => withdrawAsset, reuse transfer logic
2018-08-09 14:07:27 -07:00
Amir Bandeali
b9d8d2d5e3
Make marketBuy functions revert if entire amount not filled
2018-08-09 11:26:32 -07:00
Amir Bandeali
d10e2652ae
Revert incrementing memory ptr in dispatchTransferFrom
2018-08-08 15:44:43 -07:00
Amir Bandeali
9a5d7b7635
Test abiEncodeFillOrder as part of combinatorial follOrder tests
2018-08-08 15:44:43 -07:00
Amir Bandeali
1fb3da6b53
Increment free memory pointer for internal Exchange functions that use asm
2018-08-08 15:44:43 -07:00
Amir Bandeali
68fb1bf376
fix comments and styling for MixinSignatureValidator
2018-08-08 13:58:29 -07:00
Amir Bandeali
149c07dfd2
Use asm for hashEIP712Message, increment free memory pointer after asm hashing functions
2018-08-08 11:15:38 -07:00
Amir Bandeali
3d6cf50364
Fix comments, styling, and optimize hashOrder
2018-08-07 14:34:28 -07:00
Alex Browne
554d5f97df
Add combinatorial tests for internal Exchange functions ( #807 )
...
* WIP add combinatorial tests for internal Exchange functions
* Change combinitorial testing strategy based on feedback
* Check value of filled[orderHash] in updateFilledState tests
* Add combinatorial tests for addFillResults
* Add combinatorial tests for getPartialAmount
* Implement generic `testWithReferenceFuncAsync`
* Implement generic `testCombinatoriallyWithReferenceFuncAsync`
* Add combinatorial tests for isRoundingError
* Add combinatorial tests for calculateFillResults
* Add support for Geth in internal contract tests
* Fix contract artifacts
* Change DECIMAL_PLACES to 78 and add a note.
* Document new functions in utils
* Optimize tests by only reseting state when needed
* Rename/move some files
* Print parameter names on failure in testWithReferenceFuncAsync
* Add to changelog for utils package
* Appease various linters
* Rename some more things related to FillOrderCombinatorialUtils
* Remove .only from test/exchange/internal.ts
* Remove old test for isRoundingError and getPartialAmount
* Appease linters again
* Remove old todos
* Fix typos, add comments, rename some things
* Re-add some LibMath tests
* Update contract internal tests to use new SafeMath revert reasons
* Apply PR feedback from Amir
* Apply PR feedback from Remco
* Re-add networks to ZRXToken artifact
* Remove duplicate Whitelist in compiler.json
2018-07-26 22:09:55 -07:00
Fabio Berger
24ab24879c
Modify WETH9 event arg names to be identical to ERC20 standard suggested names
2018-07-25 18:10:10 +02:00
Amir Bandeali
fac90c446c
Update orderEpoch comments
2018-07-24 10:46:08 -07:00
Amir Bandeali
06396b8874
Remove ERC721 callback functions
2018-07-23 10:02:51 -05:00
Amir Bandeali
e5e68de2d7
Use != instead of > in loops, add sanity checks to market fill functions
2018-07-23 10:02:51 -05:00
