James Towle
015c35f2b2
@0x:contracts-exchange
Updated MixinSignatureValidator to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
5a491b2624
@0x:contracts-exchange
Updated MixinWrapperFunctions to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
3d95817dbe
@0x:contracts-exchange
Updated MixinAssetProxyDispatcher and MixinExchangeCore to use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
96ab74dea4
@0x:contracts-utils
Refactored utils to exclusively use library RichErrors
2019-07-23 15:53:25 -07:00
James Towle
f937a0b038
@0x:contracts-utils
Added RichErrors to ReentrancyGuard
2019-07-23 15:53:25 -07:00
James Towle
da38285046
@0x:contracts-utils
Added RichErrors to LibAddressArray
2019-07-23 15:53:25 -07:00
James Towle
d3db2dcfbb
@0x:contracts-utils
Added RichErrors to LibBytes
2019-07-23 15:53:25 -07:00
Lawrence Forman
c788db785b
@0x/contracts-exchange
: Use named return values in MixinSignatureValidator.sol
2019-07-23 15:53:25 -07:00
Lawrence Forman
6df41d2562
@0x/contracts-exchange
: REALLY make assertValidFill()
internal again.
2019-07-23 15:53:25 -07:00
Lawrence Forman
74fb43998e
@0x/contracts-exchange
: Make assertValidFill()
internal again.
2019-07-23 15:53:25 -07:00
Lawrence Forman
c1f8eabd12
@0x/contracts-exchange
: Cosmetic changes to contracts.
2019-07-23 15:53:25 -07:00
Lawrence Forman
2f5a1eebe0
@0x/contracts-exchange
: Make assertValidFill
and calculateMatchedFillResults
public
2019-07-23 15:53:25 -07:00
Lawrence Forman
4791c120fe
@0x/contracts-exchange
: Run contracts:gen
2019-07-23 15:53:24 -07:00
Lawrence Forman
d6ba03916a
@0x/contracts-exchange
: Update tests for new/consolidated signature types.
...
`@0x/contracts-exchange`: Update `Whitelist` example for new signature types.
2019-07-23 15:53:24 -07:00
Lawrence Forman
4734acbe61
@0x/contracts-test-utils
: Add hexConcat()
in hex_utils.ts
.
2019-07-23 15:53:24 -07:00
Lawrence Forman
527256b416
@0x/contracts-exchange
: Remove isValidOrderSignature()
from IWallet
.
2019-07-23 15:53:24 -07:00
Lawrence Forman
7a0dc7a364
@0x/contracts-exchange
: Add isValidHashSignature()
back.
...
`@0x/contracts-exchange`: Remove references to removed signature types and associated functions.
2019-07-23 15:53:24 -07:00
Lawrence Forman
588ca3a315
@0x/contracts-exchange
: Fix linearization issues.
2019-07-23 15:53:24 -07:00
Lawrence Forman
eb9b2f355e
@0x/contracts-exchange
: Consolidate signature types.
...
`@0x/contracts-exchange`: Fighting with linearization issues.
2019-07-23 15:53:24 -07:00
Lawrence Forman
cf6144599d
Fix linter errors
2019-07-23 15:53:24 -07:00
Lawrence Forman
c23bb5e589
@0x/contracts-exchange
: Add comments about preserving signatures in MixinSignatureValidator.sol
2019-07-23 15:53:24 -07:00
Lawrence Forman
0eb5c825a5
@0x/contracts-exchange
: Refactor out EIP1271_MAGIC_VALUE
into a LibEIP1271
contract and inherit from that.
...
`@0x/contracts-exchange`: Use `LibBytes.readBytes4()` to validate EIP1271 return values and be more permissive of shorter return values.
`@0x/contracts-exchange`: Use `abi.decode()` for `EIP1271OrderWallet` in `TestSignatureValidator.sol`.
`@0x/contracts-exchange`: Correct minor formatting changes in contracts.
2019-07-23 15:53:24 -07:00
Lawrence Forman
5dfb65b084
@0x/contracts-exchange
: Fix comments in test/signature_validator.ts
2019-07-23 15:53:24 -07:00
Lawrence Forman
ddbe2acbf5
@0x/contracts-utils
: Add LibEIP1271.sol
2019-07-23 15:53:24 -07:00
Lawrence Forman
2ff3735adc
Rebase against 3.0
2019-07-23 15:53:24 -07:00
Lawrence Forman
c2752d5931
Update changelogs
2019-07-23 15:53:24 -07:00
Lawrence Forman
309dd7f300
Run prettier/linter
2019-07-23 15:53:24 -07:00
Lawrence Forman
33df11b755
@0x/contracts-exchange
: Rename WalletOrderValidator
to OrderWallet
signature type
...
`@0x/contracts-exchange`: Rename `SignatureWalletOrderValidatorError` to `SignatureOrderWalletError`
`@0x/contracts-exchange`: Add `IEIP1271Wallet` interface
`@0x/contracts-exchange`: Add `EIP1271Wallet` and `EIP1271OrderWallet` to `SignatureType`
`@0x/contracts-exchange`: Always check `OrderValidator`, `OrderWallet`, `EIP1271OrderWallet` signature types on every fill
`@0x/contracts-exchange`: Add tests for EIP1271 signature types.
`@0x/contracts-exchange`: Update `LibExchangeRichErrorDecoder` for new/renamed Error types.
2019-07-23 15:53:24 -07:00
Lawrence Forman
dee5ff852d
@0x/contracts-exchange
: Have TestValidatorWallet
always accept WalletOrderValidator
if makerAddress == this
.
...
`@0x/contracts-exchange`: Update tests for repeatable signature validation.
2019-07-23 15:53:24 -07:00
Lawrence Forman
01574c5a87
@0x/contracts-exchange
: Update changelog
2019-07-23 15:53:24 -07:00
Lawrence Forman
42f7b7cc19
@0x/contracts-exchange
: Always check OrderValidator
and WalletOrderValidator
signature types on every fill
...
`@0x/contracts-exchange`: Add `validatorAddress` field to `SignatureValidatorError` and `SignatureOrderValidatorError` rich reverts
`@0x/contracts-exchange`: Add separate `SignatureOrderValidatorNotApprovedError` for `OrderValidator` signatures
`@0x/contracts-exchange`: Consolidate Wallet and Validator test contracts into a single configurable `TestValidatorWallet` contract.
`@0x/contracts-exchange`: Rewrite many tests in `signature_validator.ts` for brevity.
2019-07-23 15:53:24 -07:00
Lawrence Forman
5f8ebc3601
@0x/base-contract
: Make PromiseWithTransactionHash
fully compatible with regular Promise
types.
...
`@0x/contracts/exchange` Make `OrderValidator` and `WalletOrderValidator` signature types checked for every fill (not just first)'
2019-07-23 15:53:24 -07:00
Amir Bandeali
d73f7beb2f
Fix StaticCallProxy Exchange integration tests
2019-07-23 15:52:20 -07:00
Amir Bandeali
4f6f126952
Fix build
2019-07-23 15:52:20 -07:00
Amir Bandeali
0099cdd6ad
Update comments and add a catch-all else in getSimulatedOrderTransferResults function
2019-07-23 15:52:20 -07:00
Amir Bandeali
2b7114b704
Update CHANGELOGs
2019-07-23 15:52:20 -07:00
Amir Bandeali
2041d0d000
Add fillOrder transfer ordering tests
2019-07-23 15:52:20 -07:00
Amir Bandeali
698f313b73
Reorder matchOrder transfers and remove redundant checks
2019-07-23 15:52:20 -07:00
Amir Bandeali
1940458306
Add tests for OrderTransferSimulationUtils
2019-07-23 15:52:20 -07:00
Amir Bandeali
983def2bbd
Add OrderTransferSimulationUtils
2019-07-23 15:52:20 -07:00
Amir Bandeali
9213bf47ae
Swap ordering of transfers in fills and remove redundant checks
2019-07-23 15:52:20 -07:00
Amir Bandeali
f01743e27c
Add tests for simulateTransferFromCalls
2019-07-23 15:52:20 -07:00
Amir Bandeali
9be58972a0
Add MixinTransferSimulator
2019-07-23 15:52:20 -07:00
James Towle
a1a6c3e40c
Updated the DivisionByZeroError to not use assembly
2019-07-23 15:52:20 -07:00
James Towle
a2b19a1b9d
Updated DivisionByZero error
2019-07-23 15:52:20 -07:00
James Towle
4d1a942e79
Removed unnecessary files and code
2019-07-23 15:52:20 -07:00
James Towle
eb4afa8f2c
Update contracts/exchange-libs/contracts/src/interfaces/IMixinLibMathRichErrors.sol
...
Co-Authored-By: Lawrence Forman <lawrence@0xproject.com>
2019-07-23 15:52:20 -07:00
James Towle
468bbea44d
Update contracts/exchange-libs/contracts/src/interfaces/IMixinLibMathRichErrors.sol
...
Co-Authored-By: Lawrence Forman <lawrence@0xproject.com>
2019-07-23 15:52:20 -07:00
James Towle
b75aa02b0d
Update contracts/exchange/test/internal.ts
...
Co-Authored-By: Lawrence Forman <lawrence@0xproject.com>
2019-07-23 15:52:20 -07:00
James Towle
a39f93bcff
Update contracts/exchange/test/internal.ts
...
Co-Authored-By: Lawrence Forman <lawrence@0xproject.com>
2019-07-23 15:52:20 -07:00