crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Takeout redundant check, and make function name more clear

Browse Source
This commit is contained in:
Steve Klebanoff
2018-11-21 09:41:44 -08:00
parent 22a3124662
commit ffa2f4554b
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/instant/webpack.config.js
View File

@@ -67,7 +67,7 @@ const getRollbarPlugin = environmentName => {
return new RollbarSourceMapPlugin(rollbarPluginOptions);
};
const validateRollbar = (environmentName, rollbarPlugin) => {
const validateRollbarPresence = (environmentName, rollbarPlugin) => {
const requiresRollbar = environmentName === 'dogfood' || environmentName === 'staging';
if (!requiresRollbar) {
@@ -79,11 +79,9 @@ const validateRollbar = (environmentName, rollbarPlugin) => {
}
if (!rollbarPlugin) {
if (environmentName === 'dogfood' || environmentName === 'staging') {
throw new Error(
`Please set rollbar env var ${ROLLBAR_PUBLISH_TOKEN_ENV_NAME} to a Rollbar project access token with post_server_item permissions to deploy source maps to ${environmentName}`,
);
}
throw new Error(
`Please set rollbar env var ${ROLLBAR_PUBLISH_TOKEN_ENV_NAME} to a Rollbar project access token with post_server_item permissions to deploy source maps to ${environmentName}`,
);
}
};
@@ -111,7 +109,7 @@ module.exports = (env, argv) => {
} else {
console.log('Not using rollbar plugin');
}
validateRollbar(environmentName, rollbarPlugin);
validateRollbarPresence(environmentName, rollbarPlugin);
const config = {
entry: {