Add validation for rounding error

2017-11-13 18:09:18 -05:00
parent 315e4015de
commit f936363440
1 changed files with 7 additions and 0 deletions
--- a/packages/0x.js/src/utils/order_state_utils.ts
+++ b/packages/0x.js/src/utils/order_state_utils.ts
@@ -117,6 +117,13 @@ export class OrderStateUtils {
                throw new Error(ExchangeContractErrs.InsufficientMakerFeeAllowance);
            }
        }
+        const minimumFillableTakerTokenAmountWithingNoRoundingErrorRange = signedOrder.takerTokenAmount
+                                                                           .times(1000)
+                                                                           .dividedBy(signedOrder.makerTokenAmount);
+        if (orderRelevantState.remainingFillableTakerTokenAmount
+            .lessThan(minimumFillableTakerTokenAmountWithingNoRoundingErrorRange)) {
+            throw new Error(ExchangeContractErrs.OrderFillRoundingError);
+        }
        // TODO Add linear function solver when maker token is ZRX #badass
        // Return the max amount that's fillable
    }