crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove containerId option and throw if passing in shouldOpenInNewTab with type ReactScroll

Browse Source
This commit is contained in:
Fabio Berger 2018-10-05 12:00:24 +01:00
parent e7de4b953f
commit f7aee9c7a9
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/react-shared/src/components/link.tsx
View File

@ -6,7 +6,7 @@ import { Link as ScrollLink } from 'react-scroll';
import { LinkType } from '../types'; import { LinkType } from '../types';
import { constants } from '../utils/constants'; import { constants } from '../utils/constants';
export interface LinkProps { interface LinkProps {
to: string; to: string;
type?: LinkType; type?: LinkType;
shouldOpenInNewTab?: boolean; shouldOpenInNewTab?: boolean;
@ -15,7 +15,6 @@ export interface LinkProps {
onMouseOver?: (event: React.MouseEvent<HTMLElement>) => void; onMouseOver?: (event: React.MouseEvent<HTMLElement>) => void;
onMouseLeave?: (event: React.MouseEvent<HTMLElement>) => void; onMouseLeave?: (event: React.MouseEvent<HTMLElement>) => void;
onMouseEnter?: (event: React.MouseEvent<HTMLElement>) => void; onMouseEnter?: (event: React.MouseEvent<HTMLElement>) => void;
containerId?: string;
} }
export interface LinkState {} export interface LinkState {}
@ -35,7 +34,6 @@ export class Link extends React.Component<LinkProps, LinkState> {
onMouseOver: _.noop.bind(_), onMouseOver: _.noop.bind(_),
onMouseLeave: _.noop.bind(_), onMouseLeave: _.noop.bind(_),
onMouseEnter: _.noop.bind(_), onMouseEnter: _.noop.bind(_),
containerId: constants.DOCS_CONTAINER_ID,
}; };
private _outerReactScrollSpan: HTMLSpanElement | null; private _outerReactScrollSpan: HTMLSpanElement | null;
constructor(props: LinkProps) { constructor(props: LinkProps) {
@ -43,6 +41,10 @@ export class Link extends React.Component<LinkProps, LinkState> {
this._outerReactScrollSpan = null; this._outerReactScrollSpan = null;
} }
public render(): React.ReactNode { public render(): React.ReactNode {
if (this.props.type === LinkType.ReactScroll && this.props.shouldOpenInNewTab) {
throw new Error(`Cannot open LinkType.ReactScroll links in new tab. link.to: ${this.props.to}`);
}
const styleWithDefault = { const styleWithDefault = {
textDecoration: 'none', textDecoration: 'none',
cursor: 'pointer', cursor: 'pointer',
@ -91,7 +93,7 @@ export class Link extends React.Component<LinkProps, LinkState> {
offset={0} offset={0}
hashSpy={true} hashSpy={true}
duration={constants.DOCS_SCROLL_DURATION_MS} duration={constants.DOCS_SCROLL_DURATION_MS}
containerId={this.props.containerId} containerId={constants.DOCS_CONTAINER_ID}
className={this.props.className} className={this.props.className}
style={styleWithDefault} style={styleWithDefault}
> >