crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename validation functions

Browse Source
This commit is contained in:
Leonid Logvinov
2017-06-02 17:35:05 +02:00
parent 9756aa86b0
commit ef3a27ed05
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/contract_wrappers/exchange_wrapper.ts
View File

@@ -79,7 +79,7 @@ export class ExchangeWrapper extends ContractWrapper {
const senderAddress = await this.web3Wrapper.getSenderAddressOrThrowAsync(); const senderAddress = await this.web3Wrapper.getSenderAddressOrThrowAsync();
const exchangeInstance = await this.getExchangeContractAsync(); const exchangeInstance = await this.getExchangeContractAsync();
const zrxTokenAddress = await this.getZRXTokenAddressAsync(exchangeInstance); const zrxTokenAddress = await this.getZRXTokenAddressAsync(exchangeInstance);
await this.validateFillOrderAsync(signedOrder, fillTakerAmount, senderAddress, zrxTokenAddress); await this.validateFillOrderAndThrowIfInvalidAsync(signedOrder, fillTakerAmount, senderAddress, zrxTokenAddress);
const orderAddresses: OrderAddresses = [ const orderAddresses: OrderAddresses = [
signedOrder.maker, signedOrder.maker,
@@ -123,8 +123,8 @@ export class ExchangeWrapper extends ContractWrapper {
); );
this.throwErrorLogsAsErrors(response.logs); this.throwErrorLogsAsErrors(response.logs);
} }
private async validateFillOrderAsync(signedOrder: SignedOrder, fillTakerAmount: BigNumber.BigNumber, private async validateFillOrderAndThrowIfInvalidAsync(signedOrder: SignedOrder, fillTakerAmount: BigNumber.BigNumber,
senderAddress: string, zrxTokenAddress: string): Promise<void> { senderAddress: string, zrxTokenAddress: string): Promise<void> {
if (fillTakerAmount.eq(0)) { if (fillTakerAmount.eq(0)) {
throw new Error(FillOrderValidationErrs.FILL_AMOUNT_IS_ZERO); throw new Error(FillOrderValidationErrs.FILL_AMOUNT_IS_ZERO);
} }
@@ -135,7 +135,7 @@ export class ExchangeWrapper extends ContractWrapper {
throw new Error(FillOrderValidationErrs.EXPIRED); throw new Error(FillOrderValidationErrs.EXPIRED);
} }
await this.validateFillOrderBalancesAndAllowancesAsync(signedOrder, fillTakerAmount, await this.validateFillOrderBalancesAndAllowancesAndThrowIfInvalidAsync(signedOrder, fillTakerAmount,
senderAddress, zrxTokenAddress); senderAddress, zrxTokenAddress);
if (await this.isRoundingErrorAsync(signedOrder.takerTokenAmount, fillTakerAmount, if (await this.isRoundingErrorAsync(signedOrder.takerTokenAmount, fillTakerAmount,
@@ -143,10 +143,10 @@ export class ExchangeWrapper extends ContractWrapper {
throw new Error(FillOrderValidationErrs.ROUNDING_ERROR); throw new Error(FillOrderValidationErrs.ROUNDING_ERROR);
} }
} }
private async validateFillOrderBalancesAndAllowancesAsync(signedOrder: SignedOrder, private async validateFillOrderBalancesAndAllowancesAndThrowIfInvalidAsync(signedOrder: SignedOrder,
fillTakerAmount: BigNumber.BigNumber, fillTakerAmount: BigNumber.BigNumber,
senderAddress: string, senderAddress: string,
zrxTokenAddress: string): Promise<void> { zrxTokenAddress: string): Promise<void> {
// TODO: There is a possibility that the user might have enough funds // TODO: There is a possibility that the user might have enough funds
// to fulfill the order or pay fees but not both. This will happen if // to fulfill the order or pay fees but not both. This will happen if
// makerToken === zrxToken || makerToken === zrxToken // makerToken === zrxToken || makerToken === zrxToken