crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-zero-ex: Address review feedback.

Browse Source
This commit is contained in:
Lawrence Forman
2020-07-06 12:29:23 -04:00
parent bdc1dbf08a
commit e8106f04b5
14 changed files with 135 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
contracts/zero-ex/test/features/signature_validator_test.ts
View File

@@ -66,13 +66,12 @@ blockchainTests.resets('SignatureValidator feature', env => {
const hash = hexUtils.random();
const signer = _.sampleSize(signers, 1)[0];
const signature = hexUtils.slice(await signatureUtils.ecSignHashAsync(env.provider, hash, signer), 1);
const notSigner = randomAddress();
const tx = feature.validateHashSignature(hash, notSigner, signature).callAsync();
const tx = feature.validateHashSignature(hash, signer, signature).callAsync();
return expect(tx).to.revertWith(
new ZeroExRevertErrors.SignatureValidator.SignatureValidationError(
ZeroExRevertErrors.SignatureValidator.SignatureValidationErrorCodes.InvalidLength,
hash,
notSigner,
signer,
signature,
),
);